From 61476afc0417a60785d01e5f02af8c8a804167d5 Mon Sep 17 00:00:00 2001 From: Juha Sointusalo Date: Sat, 28 Oct 2017 00:06:45 +0300 Subject: [PATCH] mgr: remove CDlgEventLogListCtrl::GetBackgroundColour() Since the method is overridden to be private it isn't callable from outside the class and the method isn't used inside the class either. And overriding a base class method just to return a constant color isn't very useful when the same effect can be had by, e.g., calling SetBackgroundColour() in class' constructor. On the other hand, trying to force the background color to white may conflict with the color scheme user has chosen and should not be done. All in all, remove the code as not useful. Part of #1083. --- clientgui/DlgEventLogListCtrl.cpp | 5 ----- clientgui/DlgEventLogListCtrl.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/clientgui/DlgEventLogListCtrl.cpp b/clientgui/DlgEventLogListCtrl.cpp index 278653aaa2..e49cd03057 100644 --- a/clientgui/DlgEventLogListCtrl.cpp +++ b/clientgui/DlgEventLogListCtrl.cpp @@ -137,11 +137,6 @@ wxListItemAttr* CDlgEventLogListCtrl::OnGetItemAttr(long item) const { } -wxColour CDlgEventLogListCtrl::GetBackgroundColour() { - return *wxWHITE; -} - - void CDlgEventLogListCtrl::OnMouseUp(wxMouseEvent& event) { m_pParentView->UpdateButtons(); event.Skip(); diff --git a/clientgui/DlgEventLogListCtrl.h b/clientgui/DlgEventLogListCtrl.h index 4cb55c4b8a..175c97414c 100644 --- a/clientgui/DlgEventLogListCtrl.h +++ b/clientgui/DlgEventLogListCtrl.h @@ -33,8 +33,6 @@ class CDlgEventLog; class CDlgEventLogListCtrl : public DLG_LISTCTRL_BASE { -using DLG_LISTCTRL_BASE::GetBackgroundColour; - DECLARE_DYNAMIC_CLASS(CDlgEventLogListCtrl) DECLARE_EVENT_TABLE() @@ -54,7 +52,6 @@ private: virtual wxString OnGetItemText(long item, long column) const; virtual int OnGetItemImage(long item) const; virtual wxListItemAttr* OnGetItemAttr(long item) const; - virtual wxColour GetBackgroundColour(); void OnMouseUp(wxMouseEvent& event); void OnShow( wxShowEvent& event );