Rooba
/
ReC98
mirror of https://github.com/nmlgc/ReC98.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ReC98/th04/main/circle.hpp

18 lines
550 B
C++
Raw Normal View History

[Maintenance] [th04/th05] Declare circles in C land No structure declaration in the header file needed, since the game doesn't party on its members from outside, for once! Part of P0112, funded by [Anonymous] and Blue Bolt.
2020-08-25 13:40:41 +00:00
// Growing or shrinking circles
// ----------------------------
[Maintenance] Move `extern "C"` into the headers it applies to The translation units were probably a better place back when most of the codebase was still compiled in C mode, we only had a few C++ TUs, almost everything needed to be declared as `extern "C"`, and moving these declarations into the headers would have been really noisy with all the `#ifdef __cplusplus` / `#endif` required. Nowadays though, we've greatly reduced that surface area. And given that headers will include even more headers as part of the upcoming `#include` cleanup, it makes sense to make the jump now. Part of P0284, funded by [Anonymous] and Blue Bolt.
2024-05-26 17:39:06 +00:00
extern "C" {
[Maintenance] Fix comment↔code associations • Comments that describe all lines of code until a blank one are placed into the lines immediately above • Comments that describe an entire demarcated block are placed immediately below the dash row at the top • In any case, there should be a blank line after the top comment of a demarcated block, to keep IntelliSense-style systems from applying the block comment to the first actual line of code… • …but there shouldn't be one before the dash row at the bottom, where it'd be redundant. Part of P0207, funded by GhostPhanom.
2022-08-04 13:29:34 +00:00
[Maintenance] #include each header's dependencies within the header itself OK, this is the big one. We still keep using `#include` guards only where we absolutely need to, but with each header now being valid in isolation, this can now actually help *minimize* the length of each translation unit's `#include` list. Turns out that after removing all the duplicates, we only *actually* need to guard 29 headers across all 5 games. Part of P0285, funded by [Anonymous] and iruleatgames.
2024-05-25 18:31:09 +00:00
#include "th01/math/subpixel.hpp"
[Maintenance] [th04/th05] Declare circles in C land No structure declaration in the header file needed, since the game doesn't party on its members from outside, for once! Part of P0112, funded by [Anonymous] and Blue Bolt.
2020-08-25 13:40:41 +00:00
// [center_x] and [center_y] are *passed* as subpixels, but stored at pixel
// precision, as master.lib's grcg_circle() function doesn't support more than
// that anyway.
void pascal circles_add_growing(subpixel_t center_x, subpixel_t center_y);
void pascal circles_add_shrinking(subpixel_t center_x, subpixel_t center_y);
void pascal near circles_update(void);
void pascal near circles_render(void);
[Maintenance] Move `extern "C"` into the headers it applies to The translation units were probably a better place back when most of the codebase was still compiled in C mode, we only had a few C++ TUs, almost everything needed to be declared as `extern "C"`, and moving these declarations into the headers would have been really noisy with all the `#ifdef __cplusplus` / `#endif` required. Nowadays though, we've greatly reduced that surface area. And given that headers will include even more headers as part of the upcoming `#include` cleanup, it makes sense to make the jump now. Part of P0284, funded by [Anonymous] and Blue Bolt.
2024-05-26 17:39:06 +00:00
}
[Maintenance] [th04/th05] Declare circles in C land No structure declaration in the header file needed, since the game doesn't party on its members from outside, for once! Part of P0112, funded by [Anonymous] and Blue Bolt.
2020-08-25 13:40:41 +00:00
// ----------------------------