From a1e17d9f9a580bd83a6932dac2a8cdc36f77462d Mon Sep 17 00:00:00 2001 From: pgrohe Date: Wed, 14 Feb 2018 23:59:26 -0500 Subject: [PATCH 1/2] Fix for issue 226. Changed register view --info option / -i to --hide-info / -I. Still defaults to on, must explicitly be disabled --- voltron/plugins/view/register.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/voltron/plugins/view/register.py b/voltron/plugins/view/register.py index 4ca0649..3938466 100644 --- a/voltron/plugins/view/register.py +++ b/voltron/plugins/view/register.py @@ -415,8 +415,8 @@ class RegisterView (TerminalView): sp.add_argument('--fpu', '-p', dest="sections", action='append_const', const="fpu", help='show fpu registers') sp.add_argument('--no-fpu', '-P', dest="sections", action='append_const', const="no_fpu", help='hide fpu registers') - sp.add_argument('--info', '-i', action='store_true', help='show info (pointer derefs, ascii) for registers', - default=True) + sp.add_argument('--hide-info', '-I',dest="hide_info", action='store_true', help='show info (pointer derefs, ascii) for registers', + default=False) def __init__(self, *args, **kwargs): super(RegisterView, self).__init__(*args, **kwargs) @@ -528,7 +528,7 @@ class RegisterView (TerminalView): formatted[fmt['format_name']] = formatted_reg # Format the info - if self.args.info: + if not self.args.hide_info: info = "" try: l = {2: 'H', 4: 'L', 8: 'Q'}[t_res.targets[0]['addr_size']] From 524634d1e36b22bf93d823a6eafa65c125bda845 Mon Sep 17 00:00:00 2001 From: pgrohe Date: Thu, 15 Feb 2018 00:22:07 -0500 Subject: [PATCH 2/2] Fix for 226. Updated help text for --hide-info / -I --- voltron/plugins/view/register.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/voltron/plugins/view/register.py b/voltron/plugins/view/register.py index 3938466..a4a0a4a 100644 --- a/voltron/plugins/view/register.py +++ b/voltron/plugins/view/register.py @@ -415,7 +415,7 @@ class RegisterView (TerminalView): sp.add_argument('--fpu', '-p', dest="sections", action='append_const', const="fpu", help='show fpu registers') sp.add_argument('--no-fpu', '-P', dest="sections", action='append_const', const="no_fpu", help='hide fpu registers') - sp.add_argument('--hide-info', '-I',dest="hide_info", action='store_true', help='show info (pointer derefs, ascii) for registers', + sp.add_argument('--hide-info', '-I',dest="hide_info", action='store_true', help='hide extra info (pointer derefs, ascii) for registers', default=False) def __init__(self, *args, **kwargs):