From 644fd81bce6f6cca1df3cc4ce217a02eaa58c85a Mon Sep 17 00:00:00 2001 From: Joshua Coales Date: Tue, 2 Mar 2021 10:05:52 +0000 Subject: [PATCH] Adding a test case for tqdm_asyncio.gather, mirroring tqdm_asyncio.as_completed --- tests/py37_asyncio.py | 20 ++++++++++++++++++++ tqdm/asyncio.py | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/tests/py37_asyncio.py b/tests/py37_asyncio.py index be1903f2..1e051178 100644 --- a/tests/py37_asyncio.py +++ b/tests/py37_asyncio.py @@ -10,6 +10,7 @@ from .tests_tqdm import StringIO, closing, mark tqdm = partial(tqdm_asyncio, miniters=0, mininterval=0) trange = partial(tarange, miniters=0, mininterval=0) as_completed = partial(tqdm_asyncio.as_completed, miniters=0, mininterval=0) +gather = partial(tqdm_asyncio.gather, miniters=0, mininterval=0) def count(start=0, step=1): @@ -112,3 +113,22 @@ async def test_as_completed(capsys, tol): except AssertionError: if retry == 2: raise + + +@mark.slow +@mark.asyncio +@mark.parametrize("tol", [0.2 if platform.startswith("darwin") else 0.1]) +async def test_gather(capsys, tol): + """Test asyncio gather""" + for retry in range(3): + t = time() + skew = time() - t + await gather([asyncio.sleep(0.01 * i) for i in range(30, 0, -1)]) + t = time() - t - 2 * skew + try: + assert 0.3 * (1 - tol) < t < 0.3 * (1 + tol), t + _, err = capsys.readouterr() + assert '30/30' in err + except AssertionError: + if retry == 2: + raise diff --git a/tqdm/asyncio.py b/tqdm/asyncio.py index 3c643e41..0d527916 100644 --- a/tqdm/asyncio.py +++ b/tqdm/asyncio.py @@ -67,7 +67,7 @@ class tqdm_asyncio(std_tqdm): total=total, **tqdm_kwargs) @classmethod - def gather( + async def gather( cls, fs: List[Awaitable[T]], *,