From f48578cce3f9e1978554a1bcd2c82a7403bcd6c7 Mon Sep 17 00:00:00 2001 From: Ben Darnell Date: Wed, 13 Jun 2012 23:08:06 -0700 Subject: [PATCH] Better way to force a getaddrinfo error. This fixes the tests for users behind misbehaving DNS servers. Closes #534. --- tornado/test/iostream_test.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tornado/test/iostream_test.py b/tornado/test/iostream_test.py index f62e4801..4bb4f21c 100644 --- a/tornado/test/iostream_test.py +++ b/tornado/test/iostream_test.py @@ -103,7 +103,11 @@ class TestIOStream(AsyncHTTPTestCase, LogTrapTestCase): s = socket.socket(socket.AF_INET, socket.SOCK_STREAM, 0) stream = IOStream(s, io_loop=self.io_loop) stream.set_close_callback(self.stop) - stream.connect(('adomainthatdoesntexist.asdf', 54321)) + # To reliably generate a gaierror we use a malformed domain name + # instead of a name that's simply unlikely to exist (since + # opendns and some ISPs return bogus addresses for nonexistent + # domains instead of the proper error codes). + stream.connect(('an invalid domain', 54321)) self.assertTrue(isinstance(stream.error, socket.gaierror), stream.error) def test_connection_closed(self):