diff --git a/tornado/test/httpclient_test.py b/tornado/test/httpclient_test.py index 7ffddbc3..78daa74d 100644 --- a/tornado/test/httpclient_test.py +++ b/tornado/test/httpclient_test.py @@ -356,11 +356,10 @@ Transfer-Encoding: chunked @gen_test def test_future_http_error(self): - try: + with self.assertRaises(HTTPError) as context: yield self.http_client.fetch(self.get_url('/notfound')) - except HTTPError as e: - self.assertEqual(e.code, 404) - self.assertEqual(e.response.code, 404) + self.assertEqual(context.exception.code, 404) + self.assertEqual(context.exception.response.code, 404) @gen_test def test_reuse_request_from_response(self): diff --git a/tornado/test/template_test.py b/tornado/test/template_test.py index f3a9e059..32bbe421 100644 --- a/tornado/test/template_test.py +++ b/tornado/test/template_test.py @@ -182,6 +182,7 @@ three """}) try: loader.load("test.html").generate() + self.fail("did not get expected exception") except ZeroDivisionError: self.assertTrue("# test.html:2" in traceback.format_exc()) @@ -192,6 +193,7 @@ three{%end%} """}) try: loader.load("test.html").generate() + self.fail("did not get expected exception") except ZeroDivisionError: self.assertTrue("# test.html:2" in traceback.format_exc()) @@ -202,6 +204,7 @@ three{%end%} }, namespace={"_tt_modules": ObjectDict({"Template": lambda path, **kwargs: loader.load(path).generate(**kwargs)})}) try: loader.load("base.html").generate() + self.fail("did not get expected exception") except ZeroDivisionError: exc_stack = traceback.format_exc() self.assertTrue('# base.html:1' in exc_stack) @@ -214,6 +217,7 @@ three{%end%} }) try: loader.load("base.html").generate() + self.fail("did not get expected exception") except ZeroDivisionError: self.assertTrue("# sub.html:1 (via base.html:1)" in traceback.format_exc()) @@ -225,6 +229,7 @@ three{%end%} }) try: loader.load("sub.html").generate() + self.fail("did not get expected exception") except ZeroDivisionError: exc_stack = traceback.format_exc() self.assertTrue("# base.html:1" in exc_stack) @@ -240,6 +245,7 @@ three{%end%} """}) try: loader.load("sub.html").generate() + self.fail("did not get expected exception") except ZeroDivisionError: self.assertTrue("# sub.html:4 (via base.html:1)" in traceback.format_exc()) @@ -252,6 +258,7 @@ three{%end%} }) try: loader.load("a.html").generate() + self.fail("did not get expected exception") except ZeroDivisionError: self.assertTrue("# c.html:1 (via b.html:1, a.html:1)" in traceback.format_exc())