Rooba
/
tornado
mirror of https://github.com/tornadoweb/tornado.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable port-allocation test on mac to avoid annoying firewall prompts.

This commit is contained in:
Ben Darnell 2014-02-21 20:42:10 -05:00
parent 2ad4a90845
commit 559514de8c
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tornado/test/netutil_test.py
View File

@ -1,5 +1,6 @@
from __future__ import absolute_import, division, print_function, with_statement from __future__ import absolute_import, division, print_function, with_statement
import platform
import signal import signal
import socket import socket
from subprocess import Popen from subprocess import Popen
@ -146,6 +147,13 @@ class IsValidIPTest(unittest.TestCase):
self.assertTrue(not is_valid_ip('\x00')) self.assertTrue(not is_valid_ip('\x00'))
# The mac firewall prompts when listening on "localhost" instead of
# "127.0.0.1" like the other tests use (maybe due to the ipv6
# link-local address fe80::1%lo0?), and it doesn't remember whether
# you've previously allowed or denied access. It's better to skip this
# test on the mac than to have the prompts come up for every configuration
# in tox.ini.
@unittest.skipIf(platform.system() == 'Darwin', 'avoid firewall prompts on Mac')
class TestPortAllocation(unittest.TestCase): class TestPortAllocation(unittest.TestCase):
def test_same_port_allocation(self): def test_same_port_allocation(self):
sockets = bind_sockets(None, 'localhost') sockets = bind_sockets(None, 'localhost')