From 330729617e292ec68378ce7c3527704f1a6a0044 Mon Sep 17 00:00:00 2001 From: Ben Darnell Date: Sun, 21 May 2017 19:16:58 -0400 Subject: [PATCH] testing: Remove deprecated get_unused_port() This function never did a good job and has long since been deprecated in favor of bind_unused_port. --- docs/testing.rst | 2 -- tornado/testing.py | 18 ------------------ 2 files changed, 20 deletions(-) diff --git a/docs/testing.rst b/docs/testing.rst index 334d2587..c8219738 100644 --- a/docs/testing.rst +++ b/docs/testing.rst @@ -36,6 +36,4 @@ .. autofunction:: bind_unused_port - .. autofunction:: get_unused_port - .. autofunction:: get_async_test_timeout diff --git a/tornado/testing.py b/tornado/testing.py index 3c30c9ee..46c2d5e1 100644 --- a/tornado/testing.py +++ b/tornado/testing.py @@ -73,24 +73,6 @@ else: except ImportError: import unittest # type: ignore -_next_port = 10000 - - -def get_unused_port(): - """Returns a (hopefully) unused port number. - - This function does not guarantee that the port it returns is available, - only that a series of get_unused_port calls in a single process return - distinct ports. - - .. deprecated:: - Use bind_unused_port instead, which is guaranteed to find an unused port. - """ - global _next_port - port = _next_port - _next_port = _next_port + 1 - return port - def bind_unused_port(reuse_port=False): """Binds a server socket to an available port on localhost.