From 067e465b9267d8065647020a3e764d7c6b18179e Mon Sep 17 00:00:00 2001 From: Ben Darnell Date: Mon, 23 Jan 2012 10:20:35 -0800 Subject: [PATCH] Document curl_httpclient empty password fix. Accept None as auth_password in simple_httpclient for consistency with curl_httpclient. --- tornado/simple_httpclient.py | 2 +- website/sphinx/releases/next.rst | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tornado/simple_httpclient.py b/tornado/simple_httpclient.py index ad5b7e09..376d410c 100644 --- a/tornado/simple_httpclient.py +++ b/tornado/simple_httpclient.py @@ -257,7 +257,7 @@ class _HTTPConnection(object): username, password = parsed.username, parsed.password elif self.request.auth_username is not None: username = self.request.auth_username - password = self.request.auth_password + password = self.request.auth_password or '' if username is not None: auth = utf8(username) + b(":") + utf8(password) self.request.headers["Authorization"] = (b("Basic ") + diff --git a/website/sphinx/releases/next.rst b/website/sphinx/releases/next.rst index fa940c89..aec080bf 100644 --- a/website/sphinx/releases/next.rst +++ b/website/sphinx/releases/next.rst @@ -32,6 +32,8 @@ Backwards-incompatible changes responses with no content, or empty ``POST``/``PUT`` response bodies. * `SimpleAsyncHTTPClient` now supports 303 and 307 redirect codes. * `tornado.curl_httpclient` now accepts non-integer timeouts. +* `tornado.curl_httpclient` now supports basic authentication with an + empty password. ``tornado.httpserver`` ~~~~~~~~~~~~~~~~~~~~~~