From a18daf019566c6381c4725bae1263378b8be6462 Mon Sep 17 00:00:00 2001 From: wh1te909 Date: Mon, 23 Nov 2020 00:47:16 +0000 Subject: [PATCH] fix tests --- api/tacticalrmm/agents/baker_recipes.py | 1 + api/tacticalrmm/agents/tests.py | 36 ++--- api/tacticalrmm/scripts/tests.py | 4 +- api/tacticalrmm/services/tests.py | 168 +++++++++--------------- 4 files changed, 75 insertions(+), 134 deletions(-) diff --git a/api/tacticalrmm/agents/baker_recipes.py b/api/tacticalrmm/agents/baker_recipes.py index 5051027b..a752e2bf 100644 --- a/api/tacticalrmm/agents/baker_recipes.py +++ b/api/tacticalrmm/agents/baker_recipes.py @@ -26,6 +26,7 @@ def get_wmi_data(): agent = Recipe( Agent, hostname="DESKTOP-TEST123", + version="1.1.0", monitoring_type=cycle(["workstation", "server"]), salt_id=generate_agent_id("DESKTOP-TEST123"), agent_id="71AHC-AA813-HH1BC-AAHH5-00013|DESKTOP-TEST123", diff --git a/api/tacticalrmm/agents/tests.py b/api/tacticalrmm/agents/tests.py index f4fa810c..ff8a9be4 100644 --- a/api/tacticalrmm/agents/tests.py +++ b/api/tacticalrmm/agents/tests.py @@ -34,7 +34,9 @@ class TestAgentViews(TacticalTestCase): client = baker.make("clients.Client", name="Google") site = baker.make("clients.Site", client=client, name="LA Office") - self.agent = baker.make_recipe("agents.online_agent", site=site) + self.agent = baker.make_recipe( + "agents.online_agent", site=site, version="1.1.0" + ) baker.make_recipe("winupdate.winupdate_policy", agent=self.agent) def test_get_patch_policy(self): @@ -143,7 +145,7 @@ class TestAgentViews(TacticalTestCase): self.check_not_authenticated("delete", url) - @patch("agents.models.Agent.salt_api_cmd") + @patch("agents.models.Agent.nats_cmd") def test_get_processes(self, mock_ret): url = f"/agents/{self.agent.pk}/getprocs/" @@ -163,10 +165,6 @@ class TestAgentViews(TacticalTestCase): r = self.client.get(url) self.assertEqual(r.status_code, 400) - mock_ret.return_value = "error" - r = self.client.get(url) - self.assertEqual(r.status_code, 400) - self.check_not_authenticated("get", url) @patch("agents.models.Agent.salt_api_cmd") @@ -191,32 +189,22 @@ class TestAgentViews(TacticalTestCase): self.check_not_authenticated("get", url) - @patch("agents.models.Agent.salt_api_cmd") + @patch("agents.models.Agent.nats_cmd") def test_get_event_log(self, mock_ret): url = f"/agents/{self.agent.pk}/geteventlog/Application/30/" with open( - os.path.join(settings.BASE_DIR, "tacticalrmm/test_data/eventlograw.json") + os.path.join(settings.BASE_DIR, "tacticalrmm/test_data/appeventlog.json") ) as f: mock_ret.return_value = json.load(f) - with open( - os.path.join(settings.BASE_DIR, "tacticalrmm/test_data/appeventlog.json") - ) as f: - decoded = json.load(f) - r = self.client.get(url) self.assertEqual(r.status_code, 200) - self.assertEqual(decoded, r.json()) mock_ret.return_value = "timeout" r = self.client.get(url) self.assertEqual(r.status_code, 400) - mock_ret.return_value = "error" - r = self.client.get(url) - self.assertEqual(r.status_code, 400) - self.check_not_authenticated("get", url) @patch("agents.models.Agent.salt_api_cmd") @@ -238,7 +226,7 @@ class TestAgentViews(TacticalTestCase): self.check_not_authenticated("post", url) - @patch("agents.models.Agent.salt_api_cmd") + @patch("agents.models.Agent.nats_cmd") def test_send_raw_cmd(self, mock_ret): url = f"/agents/sendrawcmd/" @@ -257,10 +245,6 @@ class TestAgentViews(TacticalTestCase): r = self.client.post(url, data, format="json") self.assertEqual(r.status_code, 400) - mock_ret.return_value = False - r = self.client.post(url, data, format="json") - self.assertEqual(r.status_code, 400) - self.check_not_authenticated("post", url) @patch("agents.models.Agent.salt_api_cmd") @@ -681,7 +665,7 @@ class TestAgentViews(TacticalTestCase): self.check_not_authenticated("post", url) - @patch("agents.models.Agent.salt_api_cmd") + @patch("agents.models.Agent.nats_cmd") def test_recover_mesh(self, mock_ret): url = f"/agents/{self.agent.pk}/recovermesh/" mock_ret.return_value = True @@ -693,10 +677,6 @@ class TestAgentViews(TacticalTestCase): r = self.client.get(url) self.assertEqual(r.status_code, 400) - mock_ret.return_value = "error" - r = self.client.get(url) - self.assertEqual(r.status_code, 400) - url = f"/agents/543656/recovermesh/" r = self.client.get(url) self.assertEqual(r.status_code, 404) diff --git a/api/tacticalrmm/scripts/tests.py b/api/tacticalrmm/scripts/tests.py index babb261e..2fbd7cff 100644 --- a/api/tacticalrmm/scripts/tests.py +++ b/api/tacticalrmm/scripts/tests.py @@ -94,8 +94,8 @@ class TestScriptViews(TacticalTestCase): def test_load_community_scripts(self): valid_shells = ["powershell", "python", "cmd"] - scripts_dir = settings.SCRIPTS_DIR - + scripts_dir = os.path.join(Path(settings.BASE_DIR).parents[1], "scripts") + with open( os.path.join(settings.BASE_DIR, "scripts/community_scripts.json") ) as f: diff --git a/api/tacticalrmm/services/tests.py b/api/tacticalrmm/services/tests.py index f511dc4a..4fce8956 100644 --- a/api/tacticalrmm/services/tests.py +++ b/api/tacticalrmm/services/tests.py @@ -32,8 +32,8 @@ class TestServiceViews(TacticalTestCase): self.check_not_authenticated("get", url) - @patch("agents.models.Agent.salt_api_cmd") - def test_get_refreshed_services(self, salt_api_cmd): + @patch("agents.models.Agent.nats_cmd") + def test_get_refreshed_services(self, nats_cmd): # test a call where agent doesn't exist resp = self.client.get("/services/500/refreshedservices/", format="json") self.assertEqual(resp.status_code, 404) @@ -41,7 +41,7 @@ class TestServiceViews(TacticalTestCase): agent = baker.make_recipe("agents.agent_with_services") url = f"/services/{agent.pk}/refreshedservices/" - salt_return = [ + nats_return = [ { "pid": 880, "name": "AeLookupSvc", @@ -65,30 +65,23 @@ class TestServiceViews(TacticalTestCase): ] # test failed attempt - salt_api_cmd.return_value = "timeout" + nats_cmd.return_value = "timeout" resp = self.client.get(url, format="json") self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with(timeout=15, func="win_agent.get_services") - salt_api_cmd.reset_mock() - - # test failed attempt - salt_api_cmd.return_value = "error" - resp = self.client.get(url, format="json") - self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with(timeout=15, func="win_agent.get_services") - salt_api_cmd.reset_mock() + nats_cmd.assert_called_with(data={"func": "winservices"}, timeout=10) + nats_cmd.reset_mock() # test successful attempt - salt_api_cmd.return_value = salt_return + nats_cmd.return_value = nats_return resp = self.client.get(url, format="json") self.assertEqual(resp.status_code, 200) - salt_api_cmd.assert_called_with(timeout=15, func="win_agent.get_services") - self.assertEquals(Agent.objects.get(pk=agent.pk).services, salt_return) + nats_cmd.assert_called_with(data={"func": "winservices"}, timeout=10) + self.assertEquals(Agent.objects.get(pk=agent.pk).services, nats_return) self.check_not_authenticated("get", url) - @patch("agents.models.Agent.salt_api_cmd") - def test_service_action(self, salt_api_cmd): + @patch("agents.models.Agent.nats_cmd") + def test_service_action(self, nats_cmd): url = "/services/serviceaction/" invalid_data = {"pk": 500, "sv_name": "AeLookupSvc", "sv_action": "restart"} @@ -101,47 +94,37 @@ class TestServiceViews(TacticalTestCase): data = {"pk": agent.pk, "sv_name": "AeLookupSvc", "sv_action": "restart"} # test failed attempt - salt_api_cmd.return_value = "timeout" + nats_cmd.return_value = "timeout" resp = self.client.post(url, data, format="json") self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with( - timeout=45, - func=f"service.restart", - arg="AeLookupSvc", + nats_cmd.assert_called_with( + { + "func": "winsvcaction", + "payload": { + "name": "AeLookupSvc", + "action": "stop", + }, + }, + timeout=32, ) - salt_api_cmd.reset_mock() - - salt_api_cmd.return_value = "error" - resp = self.client.post(url, data, format="json") - self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with( - timeout=45, - func=f"service.restart", - arg="AeLookupSvc", - ) - salt_api_cmd.reset_mock() + nats_cmd.reset_mock() # test successful attempt - salt_api_cmd.return_value = True + nats_cmd.return_value = {"success": True, "errormsg": ""} resp = self.client.post(url, data, format="json") self.assertEqual(resp.status_code, 200) - salt_api_cmd.assert_called_with( - timeout=45, - func=f"service.restart", - arg="AeLookupSvc", - ) self.check_not_authenticated("post", url) - @patch("agents.models.Agent.salt_api_cmd") - def test_service_detail(self, salt_api_cmd): + @patch("agents.models.Agent.nats_cmd") + def test_service_detail(self, nats_cmd): # test a call where agent doesn't exist resp = self.client.get( "/services/500/doesntexist/servicedetail/", format="json" ) self.assertEqual(resp.status_code, 404) - salt_return = { + nats_return = { "pid": 812, "name": "ALG", "status": "stopped", @@ -156,29 +139,27 @@ class TestServiceViews(TacticalTestCase): url = f"/services/{agent.pk}/alg/servicedetail/" # test failed attempt - salt_api_cmd.return_value = "timeout" + nats_cmd.return_value = "timeout" resp = self.client.get(url, format="json") self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with(timeout=20, func="service.info", arg="alg") - salt_api_cmd.reset_mock() - - salt_api_cmd.return_value = "error" - resp = self.client.get(url, format="json") - self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with(timeout=20, func="service.info", arg="alg") - salt_api_cmd.reset_mock() + nats_cmd.assert_called_with( + {"func": "winsvcdetail", "payload": {"name": "alg"}}, timeout=10 + ) + nats_cmd.reset_mock() # test successful attempt - salt_api_cmd.return_value = salt_return + nats_cmd.return_value = nats_return resp = self.client.get(url, format="json") self.assertEqual(resp.status_code, 200) - salt_api_cmd.assert_called_with(timeout=20, func="service.info", arg="alg") - self.assertEquals(resp.data, salt_return) + nats_cmd.assert_called_with( + {"func": "winsvcdetail", "payload": {"name": "alg"}}, timeout=10 + ) + self.assertEquals(resp.data, nats_return) self.check_not_authenticated("get", url) - @patch("agents.models.Agent.salt_api_cmd") - def test_edit_service(self, salt_api_cmd): + @patch("agents.models.Agent.nats_cmd") + def test_edit_service(self, nats_cmd): url = "/services/editservice/" agent = baker.make_recipe("agents.agent_with_services") @@ -189,64 +170,43 @@ class TestServiceViews(TacticalTestCase): data = {"pk": agent.pk, "sv_name": "AeLookupSvc", "edit_action": "autodelay"} - # test failed attempt - salt_api_cmd.return_value = "timeout" + # test timeout + nats_cmd.return_value = "timeout" resp = self.client.post(url, data, format="json") self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with( - timeout=20, - func="service.modify", - arg=data["sv_name"], - kwargs={"start_type": "auto", "start_delayed": True}, - ) - salt_api_cmd.reset_mock() - - salt_api_cmd.return_value = "error" - resp = self.client.post(url, data, format="json") - self.assertEqual(resp.status_code, 400) - salt_api_cmd.assert_called_with( - timeout=20, - func="service.modify", - arg=data["sv_name"], - kwargs={"start_type": "auto", "start_delayed": True}, - ) - salt_api_cmd.reset_mock() + nats_cmd.reset_mock() # test successful attempt autodelay - salt_api_cmd.return_value = True + nats_cmd.return_value = {"success": True, "errormsg": ""} resp = self.client.post(url, data, format="json") self.assertEqual(resp.status_code, 200) - salt_api_cmd.assert_called_with( - timeout=20, - func="service.modify", - arg=data["sv_name"], - kwargs={"start_type": "auto", "start_delayed": True}, + nats_cmd.assert_called_with( + { + "func": "editwinsvc", + "payload": { + "name": "AeLookupSvc", + "startType": "autodelay", + }, + }, + timeout=10, ) - salt_api_cmd.reset_mock() + nats_cmd.reset_mock() - # test successful attempt with auto + # test error message from agent data = {"pk": agent.pk, "sv_name": "AeLookupSvc", "edit_action": "auto"} - salt_api_cmd.return_value = True + nats_cmd.return_value = { + "success": False, + "errormsg": "The parameter is incorrect", + } resp = self.client.post(url, data, format="json") - self.assertEqual(resp.status_code, 200) - salt_api_cmd.assert_called_with( - timeout=20, - func="service.modify", - arg=data["sv_name"], - kwargs={"start_type": "auto", "start_delayed": False}, - ) - salt_api_cmd.reset_mock() + self.assertEqual(resp.status_code, 400) + nats_cmd.reset_mock() - # test successful attempt with manual - data = {"pk": agent.pk, "sv_name": "AeLookupSvc", "edit_action": "manual"} - salt_api_cmd.return_value = True + # test catch all + data = {"pk": agent.pk, "sv_name": "AeLookupSvc", "edit_action": "auto"} + nats_cmd.return_value = {"success": False, "errormsg": ""} resp = self.client.post(url, data, format="json") - self.assertEqual(resp.status_code, 200) - salt_api_cmd.assert_called_with( - timeout=20, - func="service.modify", - arg=data["sv_name"], - kwargs={"start_type": "manual"}, - ) + self.assertEqual(resp.status_code, 400) + self.assertEqual(resp.data, "Something went wrong") self.check_not_authenticated("post", url)