Fix integer overflow for scene size on 32bit systems (#994)

* Fix integer overflow for scene size on 32bit systems
* Cast to double in sqlite to prevent potential overflow
* Add migration to reset scene sizes and scan logic to repopulate if empty

graphql/schema/types/stats.graphql

@@ -1,8 +1,8 @@
 type StatsResultType {
   scene_count: Int!
-  scenes_size: Int!
+  scenes_size: Float!
   image_count: Int!
-  images_size: Int!
+  images_size: Float!
   gallery_count: Int!
   performer_count: Int!
   studio_count: Int!

pkg/api/resolver.go

@@ -133,9 +133,9 @@ func (r *queryResolver) Stats(ctx context.Context) (*models.StatsResultType, err
 	tagsCount, _ := tagsQB.Count()
 	return &models.StatsResultType{
 		SceneCount:     scenesCount,
-		ScenesSize:     int(scenesSize),
+		ScenesSize:     scenesSize,
 		ImageCount:     imageCount,
-		ImagesSize:     int(imageSize),
+		ImagesSize:     imageSize,
 		GalleryCount:   galleryCount,
 		PerformerCount: performersCount,
 		StudioCount:    studiosCount,

pkg/database/database.go

@@ -20,7 +20,7 @@ import (
 
 var DB *sqlx.DB
 var dbPath string
-var appSchemaVersion uint = 16
+var appSchemaVersion uint = 17
 var databaseSchemaVersion uint
 
 const sqlite3Driver = "sqlite3ex"

pkg/database/migrations/17_reset_scene_size.up.sql

@@ -0,0 +1 @@
+UPDATE `scenes` SET `size` = NULL;

pkg/manager/task_scan.go

@@ -360,7 +360,7 @@ func (t *ScanTask) scanScene() *models.Scene {
 		// if the mod time of the file is different than that of the associated
 		// scene, then recalculate the checksum and regenerate the thumbnail
 		modified := t.isFileModified(fileModTime, scene.FileModTime)
-		if modified {
+		if modified || !scene.Size.Valid {
 			scene, err = t.rescanScene(scene, fileModTime)
 			if err != nil {
 				logger.Error(err.Error())
@@ -534,7 +534,7 @@ func (t *ScanTask) scanScene() *models.Scene {
 			Height:     sql.NullInt64{Int64: int64(videoFile.Height), Valid: true},
 			Framerate:  sql.NullFloat64{Float64: videoFile.FrameRate, Valid: true},
 			Bitrate:    sql.NullInt64{Int64: videoFile.Bitrate, Valid: true},
-			Size:       sql.NullString{String: strconv.Itoa(int(videoFile.Size)), Valid: true},
+			Size:       sql.NullString{String: strconv.FormatInt(videoFile.Size, 10), Valid: true},
 			FileModTime: models.NullSQLiteTimestamp{
 				Timestamp: fileModTime,
 				Valid:     true,
@@ -610,7 +610,7 @@ func (t *ScanTask) rescanScene(scene *models.Scene, fileModTime time.Time) (*mod
 		Height:     &sql.NullInt64{Int64: int64(videoFile.Height), Valid: true},
 		Framerate:  &sql.NullFloat64{Float64: videoFile.FrameRate, Valid: true},
 		Bitrate:    &sql.NullInt64{Int64: videoFile.Bitrate, Valid: true},
-		Size:       &sql.NullString{String: strconv.Itoa(int(videoFile.Size)), Valid: true},
+		Size:       &sql.NullString{String: strconv.FormatInt(videoFile.Size, 10), Valid: true},
 		FileModTime: &models.NullSQLiteTimestamp{
 			Timestamp: fileModTime,
 			Valid:     true,

pkg/models/querybuilder_image.go

@@ -246,8 +246,8 @@ func (qb *ImageQueryBuilder) Count() (int, error) {
 	return runCountQuery(buildCountQuery("SELECT images.id FROM images"), nil)
 }
 
-func (qb *ImageQueryBuilder) Size() (uint64, error) {
+func (qb *ImageQueryBuilder) Size() (float64, error) {
-	return runSumQuery("SELECT SUM(size) as sum FROM images", nil)
+	return runSumQuery("SELECT SUM(cast(size as double)) as sum FROM images", nil)
 }
 
 func (qb *ImageQueryBuilder) CountByStudioID(studioID int) (int, error) {

pkg/models/querybuilder_scene.go

@@ -254,8 +254,8 @@ func (qb *SceneQueryBuilder) Count() (int, error) {
 	return runCountQuery(buildCountQuery("SELECT scenes.id FROM scenes"), nil)
 }
 
-func (qb *SceneQueryBuilder) Size() (uint64, error) {
+func (qb *SceneQueryBuilder) Size() (float64, error) {
-	return runSumQuery("SELECT SUM(size) as sum FROM scenes", nil)
+	return runSumQuery("SELECT SUM(cast(size as double)) as sum FROM scenes", nil)
 }
 
 func (qb *SceneQueryBuilder) CountByStudioID(studioID int) (int, error) {

pkg/models/querybuilder_sql.go

@@ -332,16 +332,16 @@ func runCountQuery(query string, args []interface{}) (int, error) {
 	return result.Int, nil
 }
 
-func runSumQuery(query string, args []interface{}) (uint64, error) {
+func runSumQuery(query string, args []interface{}) (float64, error) {
 	// Perform query and fetch result
 	result := struct {
-		Uint uint64 `db:"sum"`
+		Float64 float64 `db:"sum"`
 	}{0}
 	if err := database.DB.Get(&result, query, args...); err != nil && err != sql.ErrNoRows {
 		return 0, err
 	}
 
-	return result.Uint, nil
+	return result.Float64, nil
 }
 
 func executeFindQuery(tableName string, body string, args []interface{}, sortAndPagination string, whereClauses []string, havingClauses []string) ([]int, int) {

ui/v2.5/src/components/Changelog/versions/v050.md

@@ -1,3 +1,5 @@
+#### 💥 **Note: After upgrading, all scene file sizes will be 0B until a new [scan](/settings?tab=tasks) is run.
+
 ### ✨ New Features
 * Add organized flag for scenes, galleries and images.
 * Allow configuration of visible navbar items.
@@ -14,4 +16,5 @@
 * Support configurable number of threads for scanning and generation.
 
 ### 🐛 Bug fixes
+* Corrected file sizes on 32bit platforms
 * Fixed login redirect to remember the current page.