From b94eecae2423a0535c5ff61ec974f8001ee45ef4 Mon Sep 17 00:00:00 2001 From: SmallCoccinelle <89733524+SmallCoccinelle@users.noreply.github.com> Date: Tue, 28 Sep 2021 01:28:05 +0200 Subject: [PATCH] Fix integration-testing in the build action (#1784) When the golangci workflow action was added, we moved large parts of validation to the parallel action. However, integration testing still has to happen on the main build action, as it isn't covered by the validation action. Reenable the `it` target through docker container build. This fixes backend test errors sneaking through the build action. --- .github/workflows/build.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e49867cee..8c2cf3452 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -68,7 +68,15 @@ jobs: if: ${{ github.event_name != 'pull_request' || steps.cache-ui.outputs.cache-hit != 'true' }} run: docker exec -t build /bin/bash -c "make validate-frontend" - # Backend validation happens in parallel to the build in the golangci-lint action + # Static validation happens in the linter workflow in parallel to this workflow + # Run Dynamic validation here, to make sure we pass all the projects integration tests + # + # create UI file so that the embed doesn't fail + - name: Test Backend + run: | + mkdir -p ui/v2.5/build + touch ui/v2.5/build/index.html + docker exec -t build /bin/bash -c "make it" - name: Build UI # skip UI build for pull requests if UI is unchanged (UI was cached)