From 54430dbc114c869f01ea8dd2d62b0fab278aec13 Mon Sep 17 00:00:00 2001 From: WithoutPants <53250216+WithoutPants@users.noreply.github.com> Date: Mon, 6 Jul 2020 08:58:35 +1000 Subject: [PATCH] Fix travis not validating UI (#653) * Fix travis not validating UI * Fix lint errors --- .travis.yml | 2 +- .../src/components/Scenes/SceneDetails/SceneScrapeDialog.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 462596fb2..1f9876c3c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -16,7 +16,7 @@ before_install: - nvm install 12 - travis_retry make pre-ui - make generate -- CI=false make ui-only +- CI=false make ui-validate ui-only #- go get -v github.com/mgechev/revive script: # left lint off to avoid getting extra dependency diff --git a/ui/v2.5/src/components/Scenes/SceneDetails/SceneScrapeDialog.tsx b/ui/v2.5/src/components/Scenes/SceneDetails/SceneScrapeDialog.tsx index b9ba06cfc..700129e74 100644 --- a/ui/v2.5/src/components/Scenes/SceneDetails/SceneScrapeDialog.tsx +++ b/ui/v2.5/src/components/Scenes/SceneDetails/SceneScrapeDialog.tsx @@ -222,7 +222,7 @@ export const SceneScrapeDialog: React.FC = ( // sort by id numerically ret.sort((a, b) => { - return parseInt(a) - parseInt(b); + return parseInt(a, 10) - parseInt(b, 10); }); return ret; @@ -236,7 +236,7 @@ export const SceneScrapeDialog: React.FC = ( const ret = _.clone(idList); // sort by id numerically ret.sort((a, b) => { - return parseInt(a) - parseInt(b); + return parseInt(a, 10) - parseInt(b, 10); }); return ret;