From 3ac3fe09b8d9dd465c112ab1dbb8836b69b48156 Mon Sep 17 00:00:00 2001 From: A Ghoul Coder Date: Wed, 26 Oct 2022 01:18:02 +0300 Subject: [PATCH] add `pre-ui` to default make target and update documentation (#3030) Without `pre-ui`, `make` fails. `pre-ui` is already used in the GitHub workflows but omitted from the Makefile and docs. --- Makefile | 2 +- docs/DEVELOPMENT.md | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 8c6d613eb..51be95071 100644 --- a/Makefile +++ b/Makefile @@ -31,7 +31,7 @@ export CGO_ENABLED = 1 .PHONY: release pre-build -release: generate ui build-release +release: pre-ui generate ui build-release pre-build: ifndef BUILD_DATE diff --git a/docs/DEVELOPMENT.md b/docs/DEVELOPMENT.md index 2160e4b1c..4df0729c0 100644 --- a/docs/DEVELOPMENT.md +++ b/docs/DEVELOPMENT.md @@ -43,9 +43,10 @@ NOTE: The `make` command in Windows will be `mingw32-make` with MingW. For examp ## Building a release -1. Run `make generate` to create generated files -2. Run `make ui` to compile the frontend -3. Run `make build` to build the executable for your current platform +1. Run `make pre-ui` to install UI dependencies +2. Run `make generate` to create generated files +3. Run `make ui` to compile the frontend +4. Run `make build` to build the executable for your current platform ## Cross compiling