From 13a24a634dd9d4193b3c55a04a0e4b0d987aeccc Mon Sep 17 00:00:00 2001 From: DingDongSoLong4 <99329275+DingDongSoLong4@users.noreply.github.com> Date: Wed, 22 Nov 2023 00:52:36 +0200 Subject: [PATCH] Ignore mousemove when just clicking (#4302) --- .../components/ScenePlayer/ScenePlayerScrubber.tsx | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ui/v2.5/src/components/ScenePlayer/ScenePlayerScrubber.tsx b/ui/v2.5/src/components/ScenePlayer/ScenePlayerScrubber.tsx index c6cf120fb..93e45a7e7 100644 --- a/ui/v2.5/src/components/ScenePlayer/ScenePlayerScrubber.tsx +++ b/ui/v2.5/src/components/ScenePlayer/ScenePlayerScrubber.tsx @@ -220,15 +220,21 @@ export const ScenePlayerScrubber: React.FC = ({ (event: MouseEvent) => { if (!mouseDown.current) return; + // negative dragging right (past), positive left (future) + const delta = event.clientX - lastMouseEvent.current!.clientX; + if (lastMouseEvent.current === startMouseEvent.current) { + // this is the first mousemove event after mousedown + + // #4295: a mousemove with delta 0 can be sent when just clicking + // ignore such an event to prevent pausing the player + if (delta === 0) return; + onScroll(); } contentEl.current!.classList.add("dragging"); - // negative dragging right (past), positive left (future) - const delta = event.clientX - lastMouseEvent.current!.clientX; - const movement = event.movementX; velocity.current = movement;