stash/pkg/logger/plugin.go

212 lines
4.8 KiB
Go
Raw Normal View History

package logger
import (
"bufio"
"fmt"
"io"
"os"
"strconv"
"strings"
)
// PluginLogLevel represents a logging level for plugins to send log messages to stash.
type PluginLogLevel struct {
char byte
name string
}
// Valid Level values.
var (
TraceLevel = PluginLogLevel{
char: 't',
name: "trace",
}
DebugLevel = PluginLogLevel{
char: 'd',
name: "debug",
}
InfoLevel = PluginLogLevel{
char: 'i',
name: "info",
}
WarningLevel = PluginLogLevel{
char: 'w',
name: "warning",
}
ErrorLevel = PluginLogLevel{
char: 'e',
name: "error",
}
ProgressLevel = PluginLogLevel{
char: 'p',
name: "progress",
}
NoneLevel = PluginLogLevel{
name: "none",
}
)
var validLevels = []PluginLogLevel{
TraceLevel,
DebugLevel,
InfoLevel,
WarningLevel,
ErrorLevel,
ProgressLevel,
NoneLevel,
}
const startLevelChar byte = 1
const endLevelChar byte = 2
func (l PluginLogLevel) prefix() string {
return string([]byte{
startLevelChar,
byte(l.char),
endLevelChar,
})
}
// Log prints the provided message to os.Stderr in a format that provides the correct LogLevel for stash.
// The message is formatted in the same way as fmt.Println.
func (l PluginLogLevel) Log(args ...interface{}) {
if l.char == 0 {
return
}
argsToUse := []interface{}{
l.prefix(),
}
argsToUse = append(argsToUse, args...)
fmt.Fprintln(os.Stderr, argsToUse...)
}
// Logf prints the provided message to os.Stderr in a format that provides the correct LogLevel for stash.
// The message is formatted in the same way as fmt.Printf.
func (l PluginLogLevel) Logf(format string, args ...interface{}) {
if l.char == 0 {
return
}
formatToUse := string(l.prefix()) + format + "\n"
fmt.Fprintf(os.Stderr, formatToUse, args...)
}
// PluginLogLevelFromName returns the PluginLogLevel that matches the provided name or nil if
// the name does not match a valid value.
func PluginLogLevelFromName(name string) *PluginLogLevel {
for _, l := range validLevels {
if l.name == name {
return &l
}
}
return nil
}
// detectLogLevel returns the Level and the logging string for a provided line
// of plugin output. It parses the string for logging control characters and
// determines the log level, if present. If not present, the plugin output
// is returned unchanged with a nil Level.
func detectLogLevel(line string) (*PluginLogLevel, string) {
if len(line) < 4 || line[0] != startLevelChar || line[2] != endLevelChar {
return nil, line
}
char := line[1]
var level *PluginLogLevel
for _, l := range validLevels {
if l.char == char {
l := l // Make a copy of the loop variable
level = &l
break
}
}
if level == nil {
return nil, line
}
line = strings.TrimSpace(line[3:])
return level, line
}
// PluginLogger interprets incoming log messages from plugins and logs to the appropriate log level.
type PluginLogger struct {
// Logger is the LoggerImpl to forward log messages to.
Logger LoggerImpl
// Prefix is the prefix to prepend to log messages.
Prefix string
// DefaultLogLevel is the log level used if a log level prefix is not present in the received log message.
DefaultLogLevel *PluginLogLevel
// ProgressChan is a channel that receives float64s indicating the current progress of an operation.
ProgressChan chan float64
}
func (log *PluginLogger) handleStderrLine(line string) {
if log.Logger == nil {
return
}
logger := log.Logger
level, ll := detectLogLevel(line)
// if no log level, just output to info
if level == nil {
if log.DefaultLogLevel != nil {
level = log.DefaultLogLevel
} else {
level = &InfoLevel
}
}
switch *level {
case TraceLevel:
logger.Trace(log.Prefix, ll)
case DebugLevel:
logger.Debug(log.Prefix, ll)
case InfoLevel:
logger.Info(log.Prefix, ll)
case WarningLevel:
logger.Warn(log.Prefix, ll)
case ErrorLevel:
logger.Error(log.Prefix, ll)
case ProgressLevel:
p, err := strconv.ParseFloat(ll, 64)
if err != nil {
logger.Errorf("Error parsing progress value '%s': %s", ll, err.Error())
Enable gocritic (#1848) * Don't capitalize local variables ValidCodecs -> validCodecs * Capitalize deprecation markers A deprecated marker should be capitalized. * Use re.MustCompile for static regexes If the regex fails to compile, it's a programmer error, and should be treated as such. The regex is entirely static. * Simplify else-if constructions Rewrite else { if cond {}} to else if cond {} * Use a switch statement to analyze formats Break an if-else chain. While here, simplify code flow. Also introduce a proper static error for unsupported image formats, paving the way for being able to check against the error. * Rewrite ifElse chains into switch statements The "Effective Go" https://golang.org/doc/effective_go#switch document mentions it is more idiomatic to write if-else chains as switches when it is possible. Find all the plain rewrite occurrences in the code base and rewrite. In some cases, the if-else chains are replaced by a switch scrutinizer. That is, the code sequence if x == 1 { .. } else if x == 2 { .. } else if x == 3 { ... } can be rewritten into switch x { case 1: .. case 2: .. case 3: .. } which is clearer for the compiler: it can decide if the switch is better served by a jump-table then a branch-chain. * Rewrite switches, introduce static errors Introduce two new static errors: * `ErrNotImplmented` * `ErrNotSupported` And use these rather than forming new generative errors whenever the code is called. Code can now test on the errors (since they are static and the pointers to them wont change). Also rewrite ifElse chains into switches in this part of the code base. * Introduce a StashBoxError in configuration Since all stashbox errors are the same, treat them as such in the code base. While here, rewrite an ifElse chain. In the future, it might be beneifical to refactor configuration errors into one error which can handle missing fields, which context the error occurs in and so on. But for now, try to get an overview of the error categories by hoisting them into static errors. * Get rid of an else-block in transaction handling If we succesfully `recover()`, we then always `panic()`. This means the rest of the code is not reachable, so we can avoid having an else-block here. It also solves an ifElse-chain style check in the code base. * Use strings.ReplaceAll Rewrite strings.Replace(s, o, n, -1) into strings.ReplaceAll(s, o, n) To make it consistent and clear that we are doing an all-replace in the string rather than replacing parts of it. It's more of a nitpick since there are no implementation differences: the stdlib implementation is just to supply -1. * Rewrite via gocritic's assignOp Statements of the form x = x + e is rewritten into x += e where applicable. * Formatting * Review comments handled Stash-box is a proper noun. Rewrite a switch into an if-chain which returns on the first error encountered. * Use context.TODO() over context.Background() Patch in the same vein as everything else: use the TODO() marker so we can search for it later and link it into the context tree/tentacle once it reaches down to this level in the code base. * Tell the linter to ignore a section in manager_tasks.go The section is less readable, so mark it with a nolint for now. Because the rewrite enables a ifElseChain, also mark that as nolint for now. * Use strings.ReplaceAll over strings.Replace * Apply an ifElse rewrite else { if .. { .. } } rewrite into else if { .. } * Use switch-statements over ifElseChains Rewrite chains of if-else into switch statements. Where applicable, add an early nil-guard to simplify case analysis. Also, in ScanTask's Start(..), invert the logic to outdent the whole block, and help the reader: if it's not a scene, the function flow is now far more local to the top of the function, and it's clear that the rest of the function has to do with scene management. * Enable gocritic on the code base. Disable appendAssign for now since we aren't passing that check yet. * Document the nolint additions * Document StashBoxBatchPerformerTagInput
2021-10-18 03:12:40 +00:00
} else if log.ProgressChan != nil { // only pass progress through if channel present
// don't block on this
select {
case log.ProgressChan <- p:
default:
}
}
}
}
// ReadLogMessages reads plugin log messages from src, forwarding them to the PluginLoggers Logger.
// ProgressLevel messages are parsed as float64 and forwarded to ProgressChan. If ProgressChan is full,
// then the progress message is not forwarded.
// This method only returns when it reaches the end of src or encounters an error while reading src.
// This method closes src before returning.
func (log *PluginLogger) ReadLogMessages(src io.ReadCloser) {
// pipe plugin stderr to our logging
scanner := bufio.NewScanner(src)
for scanner.Scan() {
str := scanner.Text()
if str != "" {
log.handleStderrLine(str)
}
}
str := scanner.Text()
if str != "" {
log.handleStderrLine(str)
}
src.Close()
}