2021-09-08 05:30:15 +00:00
|
|
|
//go:build integration
|
2021-01-18 01:23:20 +00:00
|
|
|
// +build integration
|
|
|
|
|
|
|
|
package sqlite_test
|
|
|
|
|
|
|
|
import (
|
2021-03-01 02:30:40 +00:00
|
|
|
"strconv"
|
2021-01-18 01:23:20 +00:00
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
|
|
|
|
"github.com/stashapp/stash/pkg/models"
|
|
|
|
)
|
|
|
|
|
|
|
|
func TestGalleryFind(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
gqb := r.Gallery()
|
|
|
|
|
|
|
|
const galleryIdx = 0
|
|
|
|
gallery, err := gqb.Find(galleryIDs[galleryIdx])
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Equal(t, getGalleryStringValue(galleryIdx, "Path"), gallery.Path.String)
|
|
|
|
|
|
|
|
gallery, err = gqb.Find(0)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Nil(t, gallery)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryFindByChecksum(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
gqb := r.Gallery()
|
|
|
|
|
|
|
|
const galleryIdx = 0
|
|
|
|
galleryChecksum := getGalleryStringValue(galleryIdx, "Checksum")
|
|
|
|
gallery, err := gqb.FindByChecksum(galleryChecksum)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Equal(t, getGalleryStringValue(galleryIdx, "Path"), gallery.Path.String)
|
|
|
|
|
|
|
|
galleryChecksum = "not exist"
|
|
|
|
gallery, err = gqb.FindByChecksum(galleryChecksum)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Nil(t, gallery)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryFindByPath(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
gqb := r.Gallery()
|
|
|
|
|
|
|
|
const galleryIdx = 0
|
|
|
|
galleryPath := getGalleryStringValue(galleryIdx, "Path")
|
|
|
|
gallery, err := gqb.FindByPath(galleryPath)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Equal(t, galleryPath, gallery.Path.String)
|
|
|
|
|
|
|
|
galleryPath = "not exist"
|
|
|
|
gallery, err = gqb.FindByPath(galleryPath)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Nil(t, gallery)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryFindBySceneID(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
gqb := r.Gallery()
|
|
|
|
|
|
|
|
sceneID := sceneIDs[sceneIdxWithGallery]
|
2021-02-01 20:56:54 +00:00
|
|
|
galleries, err := gqb.FindBySceneID(sceneID)
|
2021-01-18 01:23:20 +00:00
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
2021-02-01 20:56:54 +00:00
|
|
|
assert.Equal(t, getGalleryStringValue(galleryIdxWithScene, "Path"), galleries[0].Path.String)
|
2021-01-18 01:23:20 +00:00
|
|
|
|
2021-02-01 20:56:54 +00:00
|
|
|
galleries, err = gqb.FindBySceneID(0)
|
2021-01-18 01:23:20 +00:00
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error finding gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
2021-02-01 20:56:54 +00:00
|
|
|
assert.Nil(t, galleries)
|
2021-01-18 01:23:20 +00:00
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryQ(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
const galleryIdx = 0
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdx, pathField)
|
|
|
|
|
|
|
|
sqb := r.Gallery()
|
|
|
|
|
|
|
|
galleryQueryQ(t, sqb, q, galleryIdx)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func galleryQueryQ(t *testing.T, qb models.GalleryReader, q string, expectedGalleryIdx int) {
|
|
|
|
filter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
galleries, _, err := qb.Query(nil, &filter)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error querying gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
gallery := galleries[0]
|
|
|
|
assert.Equal(t, galleryIDs[expectedGalleryIdx], gallery.ID)
|
|
|
|
|
|
|
|
// no Q should return all results
|
|
|
|
filter.Q = nil
|
|
|
|
galleries, _, err = qb.Query(nil, &filter)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error querying gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Len(t, galleries, totalGalleries)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryPath(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
const galleryIdx = 1
|
|
|
|
galleryPath := getGalleryStringValue(galleryIdx, "Path")
|
|
|
|
|
|
|
|
pathCriterion := models.StringCriterionInput{
|
|
|
|
Value: galleryPath,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
}
|
|
|
|
|
|
|
|
verifyGalleriesPath(t, r.Gallery(), pathCriterion)
|
|
|
|
|
|
|
|
pathCriterion.Modifier = models.CriterionModifierNotEquals
|
|
|
|
verifyGalleriesPath(t, r.Gallery(), pathCriterion)
|
|
|
|
|
2021-02-01 20:57:56 +00:00
|
|
|
pathCriterion.Modifier = models.CriterionModifierMatchesRegex
|
|
|
|
pathCriterion.Value = "gallery.*1_Path"
|
|
|
|
verifyGalleriesPath(t, r.Gallery(), pathCriterion)
|
|
|
|
|
|
|
|
pathCriterion.Modifier = models.CriterionModifierNotMatchesRegex
|
|
|
|
verifyGalleriesPath(t, r.Gallery(), pathCriterion)
|
|
|
|
|
2021-01-18 01:23:20 +00:00
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func verifyGalleriesPath(t *testing.T, sqb models.GalleryReader, pathCriterion models.StringCriterionInput) {
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Path: &pathCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries, _, err := sqb.Query(&galleryFilter, nil)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error querying gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
verifyNullString(t, gallery.Path, pathCriterion)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-05-03 03:09:46 +00:00
|
|
|
func TestGalleryQueryPathOr(t *testing.T) {
|
|
|
|
const gallery1Idx = 1
|
|
|
|
const gallery2Idx = 2
|
|
|
|
|
|
|
|
gallery1Path := getGalleryStringValue(gallery1Idx, "Path")
|
|
|
|
gallery2Path := getGalleryStringValue(gallery2Idx, "Path")
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Path: &models.StringCriterionInput{
|
|
|
|
Value: gallery1Path,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
},
|
|
|
|
Or: &models.GalleryFilterType{
|
|
|
|
Path: &models.StringCriterionInput{
|
|
|
|
Value: gallery2Path,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 2)
|
|
|
|
assert.Equal(t, gallery1Path, galleries[0].Path.String)
|
|
|
|
assert.Equal(t, gallery2Path, galleries[1].Path.String)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryPathAndRating(t *testing.T) {
|
|
|
|
const galleryIdx = 1
|
|
|
|
galleryPath := getGalleryStringValue(galleryIdx, "Path")
|
|
|
|
galleryRating := getRating(galleryIdx)
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Path: &models.StringCriterionInput{
|
|
|
|
Value: galleryPath,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
},
|
|
|
|
And: &models.GalleryFilterType{
|
|
|
|
Rating: &models.IntCriterionInput{
|
|
|
|
Value: int(galleryRating.Int64),
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
assert.Equal(t, galleryPath, galleries[0].Path.String)
|
|
|
|
assert.Equal(t, galleryRating.Int64, galleries[0].Rating.Int64)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryPathNotRating(t *testing.T) {
|
|
|
|
const galleryIdx = 1
|
|
|
|
|
|
|
|
galleryRating := getRating(galleryIdx)
|
|
|
|
|
|
|
|
pathCriterion := models.StringCriterionInput{
|
|
|
|
Value: "gallery_.*1_Path",
|
|
|
|
Modifier: models.CriterionModifierMatchesRegex,
|
|
|
|
}
|
|
|
|
|
|
|
|
ratingCriterion := models.IntCriterionInput{
|
|
|
|
Value: int(galleryRating.Int64),
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Path: &pathCriterion,
|
|
|
|
Not: &models.GalleryFilterType{
|
|
|
|
Rating: &ratingCriterion,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
verifyNullString(t, gallery.Path, pathCriterion)
|
|
|
|
ratingCriterion.Modifier = models.CriterionModifierNotEquals
|
|
|
|
verifyInt64(t, gallery.Rating, ratingCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryIllegalQuery(t *testing.T) {
|
|
|
|
assert := assert.New(t)
|
|
|
|
|
|
|
|
const galleryIdx = 1
|
|
|
|
subFilter := models.GalleryFilterType{
|
|
|
|
Path: &models.StringCriterionInput{
|
|
|
|
Value: getGalleryStringValue(galleryIdx, "Path"),
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
galleryFilter := &models.GalleryFilterType{
|
|
|
|
And: &subFilter,
|
|
|
|
Or: &subFilter,
|
|
|
|
}
|
|
|
|
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
|
|
|
|
_, _, err := sqb.Query(galleryFilter, nil)
|
|
|
|
assert.NotNil(err)
|
|
|
|
|
|
|
|
galleryFilter.Or = nil
|
|
|
|
galleryFilter.Not = &subFilter
|
|
|
|
_, _, err = sqb.Query(galleryFilter, nil)
|
|
|
|
assert.NotNil(err)
|
|
|
|
|
|
|
|
galleryFilter.And = nil
|
|
|
|
galleryFilter.Or = &subFilter
|
|
|
|
_, _, err = sqb.Query(galleryFilter, nil)
|
|
|
|
assert.NotNil(err)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-04-09 05:05:11 +00:00
|
|
|
func TestGalleryQueryURL(t *testing.T) {
|
|
|
|
const sceneIdx = 1
|
|
|
|
galleryURL := getGalleryStringValue(sceneIdx, urlField)
|
|
|
|
|
|
|
|
urlCriterion := models.StringCriterionInput{
|
|
|
|
Value: galleryURL,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
}
|
|
|
|
|
|
|
|
filter := models.GalleryFilterType{
|
|
|
|
URL: &urlCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
verifyFn := func(g *models.Gallery) {
|
|
|
|
t.Helper()
|
|
|
|
verifyNullString(t, g.URL, urlCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
verifyGalleryQuery(t, filter, verifyFn)
|
|
|
|
|
|
|
|
urlCriterion.Modifier = models.CriterionModifierNotEquals
|
|
|
|
verifyGalleryQuery(t, filter, verifyFn)
|
|
|
|
|
|
|
|
urlCriterion.Modifier = models.CriterionModifierMatchesRegex
|
|
|
|
urlCriterion.Value = "gallery_.*1_URL"
|
|
|
|
verifyGalleryQuery(t, filter, verifyFn)
|
|
|
|
|
|
|
|
urlCriterion.Modifier = models.CriterionModifierNotMatchesRegex
|
|
|
|
verifyGalleryQuery(t, filter, verifyFn)
|
|
|
|
|
|
|
|
urlCriterion.Modifier = models.CriterionModifierIsNull
|
|
|
|
urlCriterion.Value = ""
|
|
|
|
verifyGalleryQuery(t, filter, verifyFn)
|
|
|
|
|
|
|
|
urlCriterion.Modifier = models.CriterionModifierNotNull
|
|
|
|
verifyGalleryQuery(t, filter, verifyFn)
|
|
|
|
}
|
|
|
|
|
|
|
|
func verifyGalleryQuery(t *testing.T, filter models.GalleryFilterType, verifyFn func(s *models.Gallery)) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
t.Helper()
|
|
|
|
sqb := r.Gallery()
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &filter, nil)
|
|
|
|
|
|
|
|
// assume it should find at least one
|
|
|
|
assert.Greater(t, len(galleries), 0)
|
|
|
|
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
verifyFn(gallery)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-01-18 01:23:20 +00:00
|
|
|
func TestGalleryQueryRating(t *testing.T) {
|
|
|
|
const rating = 3
|
|
|
|
ratingCriterion := models.IntCriterionInput{
|
|
|
|
Value: rating,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
}
|
|
|
|
|
|
|
|
verifyGalleriesRating(t, ratingCriterion)
|
|
|
|
|
|
|
|
ratingCriterion.Modifier = models.CriterionModifierNotEquals
|
|
|
|
verifyGalleriesRating(t, ratingCriterion)
|
|
|
|
|
|
|
|
ratingCriterion.Modifier = models.CriterionModifierGreaterThan
|
|
|
|
verifyGalleriesRating(t, ratingCriterion)
|
|
|
|
|
|
|
|
ratingCriterion.Modifier = models.CriterionModifierLessThan
|
|
|
|
verifyGalleriesRating(t, ratingCriterion)
|
|
|
|
|
|
|
|
ratingCriterion.Modifier = models.CriterionModifierIsNull
|
|
|
|
verifyGalleriesRating(t, ratingCriterion)
|
|
|
|
|
|
|
|
ratingCriterion.Modifier = models.CriterionModifierNotNull
|
|
|
|
verifyGalleriesRating(t, ratingCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
func verifyGalleriesRating(t *testing.T, ratingCriterion models.IntCriterionInput) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Rating: &ratingCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries, _, err := sqb.Query(&galleryFilter, nil)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error querying gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
verifyInt64(t, gallery.Rating, ratingCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryIsMissingScene(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
qb := r.Gallery()
|
2021-02-01 20:56:54 +00:00
|
|
|
isMissing := "scenes"
|
2021-01-18 01:23:20 +00:00
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
IsMissing: &isMissing,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithScene, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries, _, err := qb.Query(&galleryFilter, &findFilter)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error querying gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
findFilter.Q = nil
|
|
|
|
galleries, _, err = qb.Query(&galleryFilter, &findFilter)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error querying gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
// ensure non of the ids equal the one with gallery
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
assert.NotEqual(t, galleryIDs[galleryIdxWithScene], gallery.ID)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-03-01 02:30:40 +00:00
|
|
|
func queryGallery(t *testing.T, sqb models.GalleryReader, galleryFilter *models.GalleryFilterType, findFilter *models.FindFilterType) []*models.Gallery {
|
|
|
|
galleries, _, err := sqb.Query(galleryFilter, findFilter)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Error querying gallery: %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
return galleries
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryIsMissingStudio(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
isMissing := "studio"
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
IsMissing: &isMissing,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithStudio, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
findFilter.Q = nil
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
|
|
|
|
// ensure non of the ids equal the one with studio
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
assert.NotEqual(t, galleryIDs[galleryIdxWithStudio], gallery.ID)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryIsMissingPerformers(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
isMissing := "performers"
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
IsMissing: &isMissing,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithPerformer, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
findFilter.Q = nil
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
|
|
|
|
assert.True(t, len(galleries) > 0)
|
|
|
|
|
|
|
|
// ensure non of the ids equal the one with movies
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
assert.NotEqual(t, galleryIDs[galleryIdxWithPerformer], gallery.ID)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryIsMissingTags(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
isMissing := "tags"
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
IsMissing: &isMissing,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithTwoTags, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
findFilter.Q = nil
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
|
|
|
|
assert.True(t, len(galleries) > 0)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryPerformers(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
performerCriterion := models.MultiCriterionInput{
|
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(performerIDs[performerIdxWithGallery]),
|
|
|
|
strconv.Itoa(performerIDs[performerIdx1WithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Performers: &performerCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 2)
|
|
|
|
|
|
|
|
// ensure ids are correct
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
assert.True(t, gallery.ID == galleryIDs[galleryIdxWithPerformer] || gallery.ID == galleryIDs[galleryIdxWithTwoPerformers])
|
|
|
|
}
|
|
|
|
|
|
|
|
performerCriterion = models.MultiCriterionInput{
|
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(performerIDs[performerIdx1WithGallery]),
|
|
|
|
strconv.Itoa(performerIDs[performerIdx2WithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludesAll,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
assert.Equal(t, galleryIDs[galleryIdxWithTwoPerformers], galleries[0].ID)
|
|
|
|
|
|
|
|
performerCriterion = models.MultiCriterionInput{
|
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(performerIDs[performerIdx1WithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierExcludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithTwoPerformers, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryTags(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
Tag hierarchy (#1519)
* Add migration script for tag relations table
* Expand hierarchical filter features
Expand the features of the hierarchical multi input filter with support
for using a relations table, which only has parent_id and child_id
columns, and support adding an additional intermediate table to join on,
for example for scenes and tags which are linked by the scenes_tags
table as well.
* Add hierarchical filtering for tags
* Add hierarchical tags support to scene markers
Refactor filtering of scene markers to filterBuilder and in the process
add support for hierarchical tags as well.
* List parent and child tags on tag details page
* Support setting parent and child tags
Add support for setting parent and child tags during tag creation and
tag updates.
* Validate no loops are created in tags hierarchy
* Update tag merging to support tag hierarcy
* Add unit tests for tags.EnsureUniqueHierarchy
* Fix applying recursive to with clause
The SQL `RECURSIVE` of a `WITH` clause only needs to be applied once,
imediately after the `WITH`. So this fixes the query building to do just
that, automatically applying the `RECURSIVE` keyword when any added with
clause is added as recursive.
* Rename hierarchical root id column
* Rewrite hierarchical filtering for performance
Completely rewrite the hierarchical filtering to optimize for
performance. Doing the recursive query in combination with a complex
query seems to break SQLite optimizing some things which means that the
recursive part might be 2,5 second slower than adding a static
`VALUES()` list. This is mostly noticable in case of the tag hierarchy
where setting an exclusion with any depth (or depth: all) being applied
has this performance impact of 2,5 second. "Include" also suffered this
issue, but some rewritten query by joining in the *_tags table in one
pass and applying a `WHERE x IS NOT NULL` filter did seem to optimize
that case. But that optimization isn't applied to the `IS NULL` filter
of "exclude". Running a simple query beforehand to get all (recursive)
items and then applying them to the query doesn't have this performance
penalty.
* Remove UI references to child studios and tags
* Add parents to tag export
* Support importing of parent relationship for tags
* Assign stable ids to parent / child badges
* Silence Apollo warning on parents/children fields on tags
Silence warning triggered by Apollo GraphQL by explicitly instructing it
to use the incoming parents/children values. By default it already does
this, but it triggers a warning as it might be unintended that it uses
the incoming values (instead of for example merging both arrays).
Setting merge to false still applies the same behaviour (use only
incoming values) but silences the warning as it's explicitly configured
to work like this.
* Rework detecting unique tag hierarchy
Completely rework the unique tag hierarchy to detect invalid hierarchies
for which a tag is "added in the middle". So when there are tags A <- B
and A <- C, you could previously edit tag B and add tag C as a sub tag
without it being noticed as parent A being applied twice (to tag C).
While afterwards saving tag C would fail as tag A was applied as parent
twice. The updated code correctly detects this scenario as well.
Furthermore the error messaging has been reworked a bit and the message
now mentions both the direct parent / sub tag as well as the tag which
would results in the error. So in aboves example it would now show the
message that tag C can't be applied because tag A already is a parent.
* Update relations on cached tags when needed
Update the relations on cached tags when a tag is created / updated /
deleted so these always reflect the correct state. Otherwise (re)opening
a tag might still show the old relations untill the page is fully
reloaded or the list is navigated. But this obviously is strange when
you for example have tag A, create or update tag B to have a relation to
tag A, and from tags B page click through to tag A and it doesn't show
that it is linked to tag B.
2021-09-09 04:58:43 +00:00
|
|
|
tagCriterion := models.HierarchicalMultiCriterionInput{
|
2021-03-01 02:30:40 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(tagIDs[tagIdxWithGallery]),
|
|
|
|
strconv.Itoa(tagIDs[tagIdx1WithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Tags: &tagCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Len(t, galleries, 2)
|
|
|
|
|
|
|
|
// ensure ids are correct
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
assert.True(t, gallery.ID == galleryIDs[galleryIdxWithTag] || gallery.ID == galleryIDs[galleryIdxWithTwoTags])
|
|
|
|
}
|
|
|
|
|
Tag hierarchy (#1519)
* Add migration script for tag relations table
* Expand hierarchical filter features
Expand the features of the hierarchical multi input filter with support
for using a relations table, which only has parent_id and child_id
columns, and support adding an additional intermediate table to join on,
for example for scenes and tags which are linked by the scenes_tags
table as well.
* Add hierarchical filtering for tags
* Add hierarchical tags support to scene markers
Refactor filtering of scene markers to filterBuilder and in the process
add support for hierarchical tags as well.
* List parent and child tags on tag details page
* Support setting parent and child tags
Add support for setting parent and child tags during tag creation and
tag updates.
* Validate no loops are created in tags hierarchy
* Update tag merging to support tag hierarcy
* Add unit tests for tags.EnsureUniqueHierarchy
* Fix applying recursive to with clause
The SQL `RECURSIVE` of a `WITH` clause only needs to be applied once,
imediately after the `WITH`. So this fixes the query building to do just
that, automatically applying the `RECURSIVE` keyword when any added with
clause is added as recursive.
* Rename hierarchical root id column
* Rewrite hierarchical filtering for performance
Completely rewrite the hierarchical filtering to optimize for
performance. Doing the recursive query in combination with a complex
query seems to break SQLite optimizing some things which means that the
recursive part might be 2,5 second slower than adding a static
`VALUES()` list. This is mostly noticable in case of the tag hierarchy
where setting an exclusion with any depth (or depth: all) being applied
has this performance impact of 2,5 second. "Include" also suffered this
issue, but some rewritten query by joining in the *_tags table in one
pass and applying a `WHERE x IS NOT NULL` filter did seem to optimize
that case. But that optimization isn't applied to the `IS NULL` filter
of "exclude". Running a simple query beforehand to get all (recursive)
items and then applying them to the query doesn't have this performance
penalty.
* Remove UI references to child studios and tags
* Add parents to tag export
* Support importing of parent relationship for tags
* Assign stable ids to parent / child badges
* Silence Apollo warning on parents/children fields on tags
Silence warning triggered by Apollo GraphQL by explicitly instructing it
to use the incoming parents/children values. By default it already does
this, but it triggers a warning as it might be unintended that it uses
the incoming values (instead of for example merging both arrays).
Setting merge to false still applies the same behaviour (use only
incoming values) but silences the warning as it's explicitly configured
to work like this.
* Rework detecting unique tag hierarchy
Completely rework the unique tag hierarchy to detect invalid hierarchies
for which a tag is "added in the middle". So when there are tags A <- B
and A <- C, you could previously edit tag B and add tag C as a sub tag
without it being noticed as parent A being applied twice (to tag C).
While afterwards saving tag C would fail as tag A was applied as parent
twice. The updated code correctly detects this scenario as well.
Furthermore the error messaging has been reworked a bit and the message
now mentions both the direct parent / sub tag as well as the tag which
would results in the error. So in aboves example it would now show the
message that tag C can't be applied because tag A already is a parent.
* Update relations on cached tags when needed
Update the relations on cached tags when a tag is created / updated /
deleted so these always reflect the correct state. Otherwise (re)opening
a tag might still show the old relations untill the page is fully
reloaded or the list is navigated. But this obviously is strange when
you for example have tag A, create or update tag B to have a relation to
tag A, and from tags B page click through to tag A and it doesn't show
that it is linked to tag B.
2021-09-09 04:58:43 +00:00
|
|
|
tagCriterion = models.HierarchicalMultiCriterionInput{
|
2021-03-01 02:30:40 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(tagIDs[tagIdx1WithGallery]),
|
|
|
|
strconv.Itoa(tagIDs[tagIdx2WithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludesAll,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
assert.Equal(t, galleryIDs[galleryIdxWithTwoTags], galleries[0].ID)
|
|
|
|
|
Tag hierarchy (#1519)
* Add migration script for tag relations table
* Expand hierarchical filter features
Expand the features of the hierarchical multi input filter with support
for using a relations table, which only has parent_id and child_id
columns, and support adding an additional intermediate table to join on,
for example for scenes and tags which are linked by the scenes_tags
table as well.
* Add hierarchical filtering for tags
* Add hierarchical tags support to scene markers
Refactor filtering of scene markers to filterBuilder and in the process
add support for hierarchical tags as well.
* List parent and child tags on tag details page
* Support setting parent and child tags
Add support for setting parent and child tags during tag creation and
tag updates.
* Validate no loops are created in tags hierarchy
* Update tag merging to support tag hierarcy
* Add unit tests for tags.EnsureUniqueHierarchy
* Fix applying recursive to with clause
The SQL `RECURSIVE` of a `WITH` clause only needs to be applied once,
imediately after the `WITH`. So this fixes the query building to do just
that, automatically applying the `RECURSIVE` keyword when any added with
clause is added as recursive.
* Rename hierarchical root id column
* Rewrite hierarchical filtering for performance
Completely rewrite the hierarchical filtering to optimize for
performance. Doing the recursive query in combination with a complex
query seems to break SQLite optimizing some things which means that the
recursive part might be 2,5 second slower than adding a static
`VALUES()` list. This is mostly noticable in case of the tag hierarchy
where setting an exclusion with any depth (or depth: all) being applied
has this performance impact of 2,5 second. "Include" also suffered this
issue, but some rewritten query by joining in the *_tags table in one
pass and applying a `WHERE x IS NOT NULL` filter did seem to optimize
that case. But that optimization isn't applied to the `IS NULL` filter
of "exclude". Running a simple query beforehand to get all (recursive)
items and then applying them to the query doesn't have this performance
penalty.
* Remove UI references to child studios and tags
* Add parents to tag export
* Support importing of parent relationship for tags
* Assign stable ids to parent / child badges
* Silence Apollo warning on parents/children fields on tags
Silence warning triggered by Apollo GraphQL by explicitly instructing it
to use the incoming parents/children values. By default it already does
this, but it triggers a warning as it might be unintended that it uses
the incoming values (instead of for example merging both arrays).
Setting merge to false still applies the same behaviour (use only
incoming values) but silences the warning as it's explicitly configured
to work like this.
* Rework detecting unique tag hierarchy
Completely rework the unique tag hierarchy to detect invalid hierarchies
for which a tag is "added in the middle". So when there are tags A <- B
and A <- C, you could previously edit tag B and add tag C as a sub tag
without it being noticed as parent A being applied twice (to tag C).
While afterwards saving tag C would fail as tag A was applied as parent
twice. The updated code correctly detects this scenario as well.
Furthermore the error messaging has been reworked a bit and the message
now mentions both the direct parent / sub tag as well as the tag which
would results in the error. So in aboves example it would now show the
message that tag C can't be applied because tag A already is a parent.
* Update relations on cached tags when needed
Update the relations on cached tags when a tag is created / updated /
deleted so these always reflect the correct state. Otherwise (re)opening
a tag might still show the old relations untill the page is fully
reloaded or the list is navigated. But this obviously is strange when
you for example have tag A, create or update tag B to have a relation to
tag A, and from tags B page click through to tag A and it doesn't show
that it is linked to tag B.
2021-09-09 04:58:43 +00:00
|
|
|
tagCriterion = models.HierarchicalMultiCriterionInput{
|
2021-03-01 02:30:40 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(tagIDs[tagIdx1WithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierExcludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithTwoTags, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryStudio(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
2021-06-03 10:52:19 +00:00
|
|
|
studioCriterion := models.HierarchicalMultiCriterionInput{
|
2021-03-01 02:30:40 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(studioIDs[studioIdxWithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Studios: &studioCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
|
|
|
|
// ensure id is correct
|
|
|
|
assert.Equal(t, galleryIDs[galleryIdxWithStudio], galleries[0].ID)
|
|
|
|
|
2021-06-03 10:52:19 +00:00
|
|
|
studioCriterion = models.HierarchicalMultiCriterionInput{
|
2021-03-01 02:30:40 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(studioIDs[studioIdxWithGallery]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierExcludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithStudio, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-06-03 10:52:19 +00:00
|
|
|
func TestGalleryQueryStudioDepth(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
2021-09-16 10:41:07 +00:00
|
|
|
depth := 2
|
2021-06-03 10:52:19 +00:00
|
|
|
studioCriterion := models.HierarchicalMultiCriterionInput{
|
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(studioIDs[studioIdxWithGrandChild]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludes,
|
2021-09-16 10:41:07 +00:00
|
|
|
Depth: &depth,
|
2021-06-03 10:52:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
Studios: &studioCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
|
2021-09-16 10:41:07 +00:00
|
|
|
depth = 1
|
2021-06-03 10:52:19 +00:00
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
studioCriterion.Value = []string{strconv.Itoa(studioIDs[studioIdxWithParentAndChild])}
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
|
|
|
|
// ensure id is correct
|
|
|
|
assert.Equal(t, galleryIDs[galleryIdxWithGrandChildStudio], galleries[0].ID)
|
|
|
|
|
2021-09-16 10:41:07 +00:00
|
|
|
depth = 2
|
|
|
|
|
2021-06-03 10:52:19 +00:00
|
|
|
studioCriterion = models.HierarchicalMultiCriterionInput{
|
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(studioIDs[studioIdxWithGrandChild]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierExcludes,
|
2021-09-16 10:41:07 +00:00
|
|
|
Depth: &depth,
|
2021-06-03 10:52:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithGrandChildStudio, pathField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
2021-09-16 10:41:07 +00:00
|
|
|
depth = 1
|
2021-06-03 10:52:19 +00:00
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
|
|
|
|
studioCriterion.Value = []string{strconv.Itoa(studioIDs[studioIdxWithParentAndChild])}
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-03-10 01:25:51 +00:00
|
|
|
func TestGalleryQueryPerformerTags(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
Tag hierarchy (#1519)
* Add migration script for tag relations table
* Expand hierarchical filter features
Expand the features of the hierarchical multi input filter with support
for using a relations table, which only has parent_id and child_id
columns, and support adding an additional intermediate table to join on,
for example for scenes and tags which are linked by the scenes_tags
table as well.
* Add hierarchical filtering for tags
* Add hierarchical tags support to scene markers
Refactor filtering of scene markers to filterBuilder and in the process
add support for hierarchical tags as well.
* List parent and child tags on tag details page
* Support setting parent and child tags
Add support for setting parent and child tags during tag creation and
tag updates.
* Validate no loops are created in tags hierarchy
* Update tag merging to support tag hierarcy
* Add unit tests for tags.EnsureUniqueHierarchy
* Fix applying recursive to with clause
The SQL `RECURSIVE` of a `WITH` clause only needs to be applied once,
imediately after the `WITH`. So this fixes the query building to do just
that, automatically applying the `RECURSIVE` keyword when any added with
clause is added as recursive.
* Rename hierarchical root id column
* Rewrite hierarchical filtering for performance
Completely rewrite the hierarchical filtering to optimize for
performance. Doing the recursive query in combination with a complex
query seems to break SQLite optimizing some things which means that the
recursive part might be 2,5 second slower than adding a static
`VALUES()` list. This is mostly noticable in case of the tag hierarchy
where setting an exclusion with any depth (or depth: all) being applied
has this performance impact of 2,5 second. "Include" also suffered this
issue, but some rewritten query by joining in the *_tags table in one
pass and applying a `WHERE x IS NOT NULL` filter did seem to optimize
that case. But that optimization isn't applied to the `IS NULL` filter
of "exclude". Running a simple query beforehand to get all (recursive)
items and then applying them to the query doesn't have this performance
penalty.
* Remove UI references to child studios and tags
* Add parents to tag export
* Support importing of parent relationship for tags
* Assign stable ids to parent / child badges
* Silence Apollo warning on parents/children fields on tags
Silence warning triggered by Apollo GraphQL by explicitly instructing it
to use the incoming parents/children values. By default it already does
this, but it triggers a warning as it might be unintended that it uses
the incoming values (instead of for example merging both arrays).
Setting merge to false still applies the same behaviour (use only
incoming values) but silences the warning as it's explicitly configured
to work like this.
* Rework detecting unique tag hierarchy
Completely rework the unique tag hierarchy to detect invalid hierarchies
for which a tag is "added in the middle". So when there are tags A <- B
and A <- C, you could previously edit tag B and add tag C as a sub tag
without it being noticed as parent A being applied twice (to tag C).
While afterwards saving tag C would fail as tag A was applied as parent
twice. The updated code correctly detects this scenario as well.
Furthermore the error messaging has been reworked a bit and the message
now mentions both the direct parent / sub tag as well as the tag which
would results in the error. So in aboves example it would now show the
message that tag C can't be applied because tag A already is a parent.
* Update relations on cached tags when needed
Update the relations on cached tags when a tag is created / updated /
deleted so these always reflect the correct state. Otherwise (re)opening
a tag might still show the old relations untill the page is fully
reloaded or the list is navigated. But this obviously is strange when
you for example have tag A, create or update tag B to have a relation to
tag A, and from tags B page click through to tag A and it doesn't show
that it is linked to tag B.
2021-09-09 04:58:43 +00:00
|
|
|
tagCriterion := models.HierarchicalMultiCriterionInput{
|
2021-03-10 01:25:51 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(tagIDs[tagIdxWithPerformer]),
|
|
|
|
strconv.Itoa(tagIDs[tagIdx1WithPerformer]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
PerformerTags: &tagCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Len(t, galleries, 2)
|
|
|
|
|
|
|
|
// ensure ids are correct
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
assert.True(t, gallery.ID == galleryIDs[galleryIdxWithPerformerTag] || gallery.ID == galleryIDs[galleryIdxWithPerformerTwoTags])
|
|
|
|
}
|
|
|
|
|
Tag hierarchy (#1519)
* Add migration script for tag relations table
* Expand hierarchical filter features
Expand the features of the hierarchical multi input filter with support
for using a relations table, which only has parent_id and child_id
columns, and support adding an additional intermediate table to join on,
for example for scenes and tags which are linked by the scenes_tags
table as well.
* Add hierarchical filtering for tags
* Add hierarchical tags support to scene markers
Refactor filtering of scene markers to filterBuilder and in the process
add support for hierarchical tags as well.
* List parent and child tags on tag details page
* Support setting parent and child tags
Add support for setting parent and child tags during tag creation and
tag updates.
* Validate no loops are created in tags hierarchy
* Update tag merging to support tag hierarcy
* Add unit tests for tags.EnsureUniqueHierarchy
* Fix applying recursive to with clause
The SQL `RECURSIVE` of a `WITH` clause only needs to be applied once,
imediately after the `WITH`. So this fixes the query building to do just
that, automatically applying the `RECURSIVE` keyword when any added with
clause is added as recursive.
* Rename hierarchical root id column
* Rewrite hierarchical filtering for performance
Completely rewrite the hierarchical filtering to optimize for
performance. Doing the recursive query in combination with a complex
query seems to break SQLite optimizing some things which means that the
recursive part might be 2,5 second slower than adding a static
`VALUES()` list. This is mostly noticable in case of the tag hierarchy
where setting an exclusion with any depth (or depth: all) being applied
has this performance impact of 2,5 second. "Include" also suffered this
issue, but some rewritten query by joining in the *_tags table in one
pass and applying a `WHERE x IS NOT NULL` filter did seem to optimize
that case. But that optimization isn't applied to the `IS NULL` filter
of "exclude". Running a simple query beforehand to get all (recursive)
items and then applying them to the query doesn't have this performance
penalty.
* Remove UI references to child studios and tags
* Add parents to tag export
* Support importing of parent relationship for tags
* Assign stable ids to parent / child badges
* Silence Apollo warning on parents/children fields on tags
Silence warning triggered by Apollo GraphQL by explicitly instructing it
to use the incoming parents/children values. By default it already does
this, but it triggers a warning as it might be unintended that it uses
the incoming values (instead of for example merging both arrays).
Setting merge to false still applies the same behaviour (use only
incoming values) but silences the warning as it's explicitly configured
to work like this.
* Rework detecting unique tag hierarchy
Completely rework the unique tag hierarchy to detect invalid hierarchies
for which a tag is "added in the middle". So when there are tags A <- B
and A <- C, you could previously edit tag B and add tag C as a sub tag
without it being noticed as parent A being applied twice (to tag C).
While afterwards saving tag C would fail as tag A was applied as parent
twice. The updated code correctly detects this scenario as well.
Furthermore the error messaging has been reworked a bit and the message
now mentions both the direct parent / sub tag as well as the tag which
would results in the error. So in aboves example it would now show the
message that tag C can't be applied because tag A already is a parent.
* Update relations on cached tags when needed
Update the relations on cached tags when a tag is created / updated /
deleted so these always reflect the correct state. Otherwise (re)opening
a tag might still show the old relations untill the page is fully
reloaded or the list is navigated. But this obviously is strange when
you for example have tag A, create or update tag B to have a relation to
tag A, and from tags B page click through to tag A and it doesn't show
that it is linked to tag B.
2021-09-09 04:58:43 +00:00
|
|
|
tagCriterion = models.HierarchicalMultiCriterionInput{
|
2021-03-10 01:25:51 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(tagIDs[tagIdx1WithPerformer]),
|
|
|
|
strconv.Itoa(tagIDs[tagIdx2WithPerformer]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierIncludesAll,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
|
|
|
|
assert.Len(t, galleries, 1)
|
|
|
|
assert.Equal(t, galleryIDs[galleryIdxWithPerformerTwoTags], galleries[0].ID)
|
|
|
|
|
Tag hierarchy (#1519)
* Add migration script for tag relations table
* Expand hierarchical filter features
Expand the features of the hierarchical multi input filter with support
for using a relations table, which only has parent_id and child_id
columns, and support adding an additional intermediate table to join on,
for example for scenes and tags which are linked by the scenes_tags
table as well.
* Add hierarchical filtering for tags
* Add hierarchical tags support to scene markers
Refactor filtering of scene markers to filterBuilder and in the process
add support for hierarchical tags as well.
* List parent and child tags on tag details page
* Support setting parent and child tags
Add support for setting parent and child tags during tag creation and
tag updates.
* Validate no loops are created in tags hierarchy
* Update tag merging to support tag hierarcy
* Add unit tests for tags.EnsureUniqueHierarchy
* Fix applying recursive to with clause
The SQL `RECURSIVE` of a `WITH` clause only needs to be applied once,
imediately after the `WITH`. So this fixes the query building to do just
that, automatically applying the `RECURSIVE` keyword when any added with
clause is added as recursive.
* Rename hierarchical root id column
* Rewrite hierarchical filtering for performance
Completely rewrite the hierarchical filtering to optimize for
performance. Doing the recursive query in combination with a complex
query seems to break SQLite optimizing some things which means that the
recursive part might be 2,5 second slower than adding a static
`VALUES()` list. This is mostly noticable in case of the tag hierarchy
where setting an exclusion with any depth (or depth: all) being applied
has this performance impact of 2,5 second. "Include" also suffered this
issue, but some rewritten query by joining in the *_tags table in one
pass and applying a `WHERE x IS NOT NULL` filter did seem to optimize
that case. But that optimization isn't applied to the `IS NULL` filter
of "exclude". Running a simple query beforehand to get all (recursive)
items and then applying them to the query doesn't have this performance
penalty.
* Remove UI references to child studios and tags
* Add parents to tag export
* Support importing of parent relationship for tags
* Assign stable ids to parent / child badges
* Silence Apollo warning on parents/children fields on tags
Silence warning triggered by Apollo GraphQL by explicitly instructing it
to use the incoming parents/children values. By default it already does
this, but it triggers a warning as it might be unintended that it uses
the incoming values (instead of for example merging both arrays).
Setting merge to false still applies the same behaviour (use only
incoming values) but silences the warning as it's explicitly configured
to work like this.
* Rework detecting unique tag hierarchy
Completely rework the unique tag hierarchy to detect invalid hierarchies
for which a tag is "added in the middle". So when there are tags A <- B
and A <- C, you could previously edit tag B and add tag C as a sub tag
without it being noticed as parent A being applied twice (to tag C).
While afterwards saving tag C would fail as tag A was applied as parent
twice. The updated code correctly detects this scenario as well.
Furthermore the error messaging has been reworked a bit and the message
now mentions both the direct parent / sub tag as well as the tag which
would results in the error. So in aboves example it would now show the
message that tag C can't be applied because tag A already is a parent.
* Update relations on cached tags when needed
Update the relations on cached tags when a tag is created / updated /
deleted so these always reflect the correct state. Otherwise (re)opening
a tag might still show the old relations untill the page is fully
reloaded or the list is navigated. But this obviously is strange when
you for example have tag A, create or update tag B to have a relation to
tag A, and from tags B page click through to tag A and it doesn't show
that it is linked to tag B.
2021-09-09 04:58:43 +00:00
|
|
|
tagCriterion = models.HierarchicalMultiCriterionInput{
|
2021-03-10 01:25:51 +00:00
|
|
|
Value: []string{
|
|
|
|
strconv.Itoa(tagIDs[tagIdx1WithPerformer]),
|
|
|
|
},
|
|
|
|
Modifier: models.CriterionModifierExcludes,
|
|
|
|
}
|
|
|
|
|
|
|
|
q := getGalleryStringValue(galleryIdxWithPerformerTwoTags, titleField)
|
|
|
|
findFilter := models.FindFilterType{
|
|
|
|
Q: &q,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries = queryGallery(t, sqb, &galleryFilter, &findFilter)
|
|
|
|
assert.Len(t, galleries, 0)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-04-09 08:46:00 +00:00
|
|
|
func TestGalleryQueryTagCount(t *testing.T) {
|
|
|
|
const tagCount = 1
|
|
|
|
tagCountCriterion := models.IntCriterionInput{
|
|
|
|
Value: tagCount,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
}
|
|
|
|
|
|
|
|
verifyGalleriesTagCount(t, tagCountCriterion)
|
|
|
|
|
|
|
|
tagCountCriterion.Modifier = models.CriterionModifierNotEquals
|
|
|
|
verifyGalleriesTagCount(t, tagCountCriterion)
|
|
|
|
|
|
|
|
tagCountCriterion.Modifier = models.CriterionModifierGreaterThan
|
|
|
|
verifyGalleriesTagCount(t, tagCountCriterion)
|
|
|
|
|
|
|
|
tagCountCriterion.Modifier = models.CriterionModifierLessThan
|
|
|
|
verifyGalleriesTagCount(t, tagCountCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
func verifyGalleriesTagCount(t *testing.T, tagCountCriterion models.IntCriterionInput) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
TagCount: &tagCountCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Greater(t, len(galleries), 0)
|
|
|
|
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
ids, err := sqb.GetTagIDs(gallery.ID)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
verifyInt(t, len(ids), tagCountCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGalleryQueryPerformerCount(t *testing.T) {
|
|
|
|
const performerCount = 1
|
|
|
|
performerCountCriterion := models.IntCriterionInput{
|
|
|
|
Value: performerCount,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
}
|
|
|
|
|
|
|
|
verifyGalleriesPerformerCount(t, performerCountCriterion)
|
|
|
|
|
|
|
|
performerCountCriterion.Modifier = models.CriterionModifierNotEquals
|
|
|
|
verifyGalleriesPerformerCount(t, performerCountCriterion)
|
|
|
|
|
|
|
|
performerCountCriterion.Modifier = models.CriterionModifierGreaterThan
|
|
|
|
verifyGalleriesPerformerCount(t, performerCountCriterion)
|
|
|
|
|
|
|
|
performerCountCriterion.Modifier = models.CriterionModifierLessThan
|
|
|
|
verifyGalleriesPerformerCount(t, performerCountCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
func verifyGalleriesPerformerCount(t *testing.T, performerCountCriterion models.IntCriterionInput) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
PerformerCount: &performerCountCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Greater(t, len(galleries), 0)
|
|
|
|
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
ids, err := sqb.GetPerformerIDs(gallery.ID)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
verifyInt(t, len(ids), performerCountCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-05-03 03:09:46 +00:00
|
|
|
func TestGalleryQueryAverageResolution(t *testing.T) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
qb := r.Gallery()
|
|
|
|
resolution := models.ResolutionEnumLow
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
2021-08-02 03:22:39 +00:00
|
|
|
AverageResolution: &models.ResolutionCriterionInput{
|
|
|
|
Value: resolution,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
},
|
2021-05-03 03:09:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// not verifying average - just ensure we get at least one
|
|
|
|
galleries := queryGallery(t, qb, &galleryFilter, nil)
|
|
|
|
assert.Greater(t, len(galleries), 0)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-04-29 01:31:51 +00:00
|
|
|
func TestGalleryQueryImageCount(t *testing.T) {
|
|
|
|
const imageCount = 0
|
|
|
|
imageCountCriterion := models.IntCriterionInput{
|
|
|
|
Value: imageCount,
|
|
|
|
Modifier: models.CriterionModifierEquals,
|
|
|
|
}
|
|
|
|
|
|
|
|
verifyGalleriesImageCount(t, imageCountCriterion)
|
|
|
|
|
|
|
|
imageCountCriterion.Modifier = models.CriterionModifierNotEquals
|
|
|
|
verifyGalleriesImageCount(t, imageCountCriterion)
|
|
|
|
|
|
|
|
imageCountCriterion.Modifier = models.CriterionModifierGreaterThan
|
|
|
|
verifyGalleriesImageCount(t, imageCountCriterion)
|
|
|
|
|
|
|
|
imageCountCriterion.Modifier = models.CriterionModifierLessThan
|
|
|
|
verifyGalleriesImageCount(t, imageCountCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
func verifyGalleriesImageCount(t *testing.T, imageCountCriterion models.IntCriterionInput) {
|
|
|
|
withTxn(func(r models.Repository) error {
|
|
|
|
sqb := r.Gallery()
|
|
|
|
galleryFilter := models.GalleryFilterType{
|
|
|
|
ImageCount: &imageCountCriterion,
|
|
|
|
}
|
|
|
|
|
|
|
|
galleries := queryGallery(t, sqb, &galleryFilter, nil)
|
|
|
|
assert.Greater(t, len(galleries), -1)
|
|
|
|
|
|
|
|
for _, gallery := range galleries {
|
|
|
|
pp := 0
|
|
|
|
|
|
|
|
_, count, err := r.Image().Query(&models.ImageFilterType{
|
|
|
|
Galleries: &models.MultiCriterionInput{
|
|
|
|
Value: []string{strconv.Itoa(gallery.ID)},
|
|
|
|
Modifier: models.CriterionModifierIncludes,
|
|
|
|
},
|
|
|
|
}, &models.FindFilterType{
|
|
|
|
PerPage: &pp,
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
verifyInt(t, count, imageCountCriterion)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-01-18 01:23:20 +00:00
|
|
|
// TODO Count
|
|
|
|
// TODO All
|
|
|
|
// TODO Query
|
|
|
|
// TODO Update
|
|
|
|
// TODO Destroy
|