Rooba
/
starlette
mirror of https://github.com/encode/starlette.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Black formatting

This commit is contained in:
Tom Christie 2018-07-12 17:07:20 +01:00
parent 0564e0c1b5
commit e3d090b359
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
starlette/staticfiles.py
View File

@ -23,7 +23,7 @@ class StaticFiles:
if scope["method"] not in ("GET", "HEAD"):
return PlainTextResponse("Method not allowed", status_code=406)
path = os.path.normpath(os.path.join(*scope["path"].split("/")))
if path.startswith('..'):
if path.startswith(".."):
return PlainTextResponse("Not found", status_code=404)
path = os.path.join(self.directory, path)
if self.config_checked:

4
tests/test_staticfiles.py
View File

@ -125,7 +125,7 @@ def test_staticfiles_config_check_occurs_only_once(tmpdir):
def test_staticfiles_prevents_breaking_out_of_directory(tmpdir):
directory = os.path.join(tmpdir, 'foo')
directory = os.path.join(tmpdir, "foo")
os.mkdir(directory)
path = os.path.join(tmpdir, "example.txt")
@ -134,6 +134,6 @@ def test_staticfiles_prevents_breaking_out_of_directory(tmpdir):
app = StaticFiles(directory=directory)
# We can't test this with 'requests', so we call the app directly here.
response = app({'method': 'GET', 'path': '/../example.txt'})
response = app({"method": "GET", "path": "/../example.txt"})
assert response.status_code == 404
assert response.body == b"Not found"