fix(testclient): exclude query sting from `raw_path` (#2716)

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
This commit is contained in:
Hao Guan 2024-11-19 03:28:43 +08:00 committed by GitHub
parent cc1e2d7a2f
commit 9dc9d2e929
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 26 additions and 2 deletions

View File

@ -281,7 +281,7 @@ class _TestClientTransport(httpx.BaseTransport):
scope = {
"type": "websocket",
"path": unquote(path),
"raw_path": raw_path,
"raw_path": raw_path.split(b"?", 1)[0],
"root_path": self.root_path,
"scheme": scheme,
"query_string": query.encode(),
@ -300,7 +300,7 @@ class _TestClientTransport(httpx.BaseTransport):
"http_version": "1.1",
"method": request.method,
"path": unquote(path),
"raw_path": raw_path,
"raw_path": raw_path.split(b"?", 1)[0],
"root_path": self.root_path,
"scheme": scheme,
"query_string": query.encode(),

View File

@ -378,3 +378,27 @@ def test_merge_url(test_client_factory: TestClientFactory) -> None:
client = test_client_factory(app, base_url="http://testserver/api/v1/")
response = client.get("/bar")
assert response.text == "/api/v1/bar"
def test_raw_path_with_querystring(test_client_factory: TestClientFactory) -> None:
async def app(scope: Scope, receive: Receive, send: Send) -> None:
response = Response(scope.get("raw_path"))
await response(scope, receive, send)
client = test_client_factory(app)
response = client.get("/hello-world", params={"foo": "bar"})
assert response.content == b"/hello-world"
def test_websocket_raw_path_without_params(test_client_factory: TestClientFactory) -> None:
async def app(scope: Scope, receive: Receive, send: Send) -> None:
websocket = WebSocket(scope, receive=receive, send=send)
await websocket.accept()
raw_path = scope.get("raw_path")
assert raw_path is not None
await websocket.send_bytes(raw_path)
client = test_client_factory(app)
with client.websocket_connect("/hello-world", params={"foo": "bar"}) as websocket:
data = websocket.receive_bytes()
assert data == b"/hello-world"