Version 0.9.7

docs/release-notes.md

@@ -1,3 +1,7 @@
+## 0.9.7
+
+* Ensure that `AuthenticationMiddleware` handles lifespan messages correctly.
+
 ## 0.9.6
 
 * Add `AuthenticationMiddleware`, and `@requires()` decorator.

starlette/__init__.py

@@ -1 +1 @@
-__version__ = "0.9.6"
+__version__ = "0.9.7"

starlette/middleware/authentication.py

@@ -17,7 +17,9 @@ class AuthenticationMiddleware:
         self.backend = backend
 
     def __call__(self, scope: Scope) -> ASGIInstance:
-        return functools.partial(self.asgi, scope=scope)
+        if scope["type"] in ["http", "websockets"]:
+            return functools.partial(self.asgi, scope=scope)
+        return self.app(scope)
 
     async def asgi(self, receive: Receive, send: Send, scope: Scope) -> None:
         request = Request(scope, receive=receive)

tests/test_authentication.py

@@ -89,52 +89,52 @@ def admin(request):
     )
 
 
-client = TestClient(app)
-
-
 def test_user_interface():
-    response = client.get("/")
+    with TestClient(app) as client:
-    assert response.status_code == 200
+        response = client.get("/")
-    assert response.json() == {"authenticated": False, "user": ""}
+        assert response.status_code == 200
+        assert response.json() == {"authenticated": False, "user": ""}
 
-    response = client.get("/", auth=("tomchristie", "example"))
+        response = client.get("/", auth=("tomchristie", "example"))
-    assert response.status_code == 200
+        assert response.status_code == 200
-    assert response.json() == {"authenticated": True, "user": "tomchristie"}
+        assert response.json() == {"authenticated": True, "user": "tomchristie"}
 
 
 def test_authentication_required():
-    response = client.get("/dashboard")
+    with TestClient(app) as client:
-    assert response.status_code == 403
+        response = client.get("/dashboard")
+        assert response.status_code == 403
 
-    response = client.get("/dashboard", auth=("tomchristie", "example"))
+        response = client.get("/dashboard", auth=("tomchristie", "example"))
-    assert response.status_code == 200
+        assert response.status_code == 200
-    assert response.json() == {"authenticated": True, "user": "tomchristie"}
+        assert response.json() == {"authenticated": True, "user": "tomchristie"}
 
-    response = client.get("/dashboard/sync")
+        response = client.get("/dashboard/sync")
-    assert response.status_code == 403
+        assert response.status_code == 403
 
-    response = client.get("/dashboard/sync", auth=("tomchristie", "example"))
+        response = client.get("/dashboard/sync", auth=("tomchristie", "example"))
-    assert response.status_code == 200
+        assert response.status_code == 200
-    assert response.json() == {"authenticated": True, "user": "tomchristie"}
+        assert response.json() == {"authenticated": True, "user": "tomchristie"}
 
-    response = client.get("/dashboard", headers={"Authorization": "basic foobar"})
+        response = client.get("/dashboard", headers={"Authorization": "basic foobar"})
-    assert response.status_code == 400
+        assert response.status_code == 400
-    assert response.text == "Invalid basic auth credentials"
+        assert response.text == "Invalid basic auth credentials"
 
 
 def test_authentication_redirect():
-    response = client.get("/admin")
+    with TestClient(app) as client:
-    assert response.status_code == 200
+        response = client.get("/admin")
-    assert response.url == "http://testserver/"
+        assert response.status_code == 200
+        assert response.url == "http://testserver/"
 
-    response = client.get("/admin", auth=("tomchristie", "example"))
+        response = client.get("/admin", auth=("tomchristie", "example"))
-    assert response.status_code == 200
+        assert response.status_code == 200
-    assert response.json() == {"authenticated": True, "user": "tomchristie"}
+        assert response.json() == {"authenticated": True, "user": "tomchristie"}
 
-    response = client.get("/admin/sync")
+        response = client.get("/admin/sync")
-    assert response.status_code == 200
+        assert response.status_code == 200
-    assert response.url == "http://testserver/"
+        assert response.url == "http://testserver/"
 
-    response = client.get("/admin/sync", auth=("tomchristie", "example"))
+        response = client.get("/admin/sync", auth=("tomchristie", "example"))
-    assert response.status_code == 200
+        assert response.status_code == 200
-    assert response.json() == {"authenticated": True, "user": "tomchristie"}
+        assert response.json() == {"authenticated": True, "user": "tomchristie"}