657af5f91f
* 🚨 Ignore all existing Mypy errors * 🏗 Add Mypy check to CI * Add types-mock and types-requests as dev requirements * Add additional type ignore directives * Add types packages to dev-only list in reqs test * Add types-dataclasses for python 3.6 * Add ignore to pretrain * 🏷 Improve type annotation on `run_command` helper The `run_command` helper previously declared that it returned an `Optional[subprocess.CompletedProcess]`, but it isn't actually possible for the function to return `None`. These changes modify the type annotation of the `run_command` helper and remove all now-unnecessary `# type: ignore` directives. * 🔧 Allow variable type redefinition in limited contexts These changes modify how Mypy is configured to allow variables to have their type automatically redefined under certain conditions. The Mypy documentation contains the following example: ```python def process(items: List[str]) -> None: # 'items' has type List[str] items = [item.split() for item in items] # 'items' now has type List[List[str]] ... ``` This configuration change is especially helpful in reducing the number of `# type: ignore` directives needed to handle the common pattern of: * Accepting a filepath as a string * Overwriting the variable using `filepath = ensure_path(filepath)` These changes enable redefinition and remove all `# type: ignore` directives rendered redundant by this change. * 🏷 Add type annotation to converters mapping * 🚨 Fix Mypy error in convert CLI argument verification * 🏷 Improve type annotation on `resolve_dot_names` helper * 🏷 Add type annotations for `Vocab` attributes `strings` and `vectors` * 🏷 Add type annotations for more `Vocab` attributes * 🏷 Add loose type annotation for gold data compilation * 🏷 Improve `_format_labels` type annotation * 🏷 Fix `get_lang_class` type annotation * 🏷 Loosen return type of `Language.evaluate` * 🏷 Don't accept `Scorer` in `handle_scores_per_type` * 🏷 Add `string_to_list` overloads * 🏷 Fix non-Optional command-line options * 🙈 Ignore redefinition of `wandb_logger` in `loggers.py` * ➕ Install `typing_extensions` in Python 3.8+ The `typing_extensions` package states that it should be used when "writing code that must be compatible with multiple Python versions". Since SpaCy needs to support multiple Python versions, it should be used when newer `typing` module members are required. One example of this is `Literal`, which is available starting with Python 3.8. Previously SpaCy tried to import `Literal` from `typing`, falling back to `typing_extensions` if the import failed. However, Mypy doesn't seem to be able to understand what `Literal` means when the initial import means. Therefore, these changes modify how `compat` imports `Literal` by always importing it from `typing_extensions`. These changes also modify how `typing_extensions` is installed, so that it is a requirement for all Python versions, including those greater than or equal to 3.8. * 🏷 Improve type annotation for `Language.pipe` These changes add a missing overload variant to the type signature of `Language.pipe`. Additionally, the type signature is enhanced to allow type checkers to differentiate between the two overload variants based on the `as_tuple` parameter. Fixes #8772 * ➖ Don't install `typing-extensions` in Python 3.8+ After more detailed analysis of how to implement Python version-specific type annotations using SpaCy, it has been determined that by branching on a comparison against `sys.version_info` can be statically analyzed by Mypy well enough to enable us to conditionally use `typing_extensions.Literal`. This means that we no longer need to install `typing_extensions` for Python versions greater than or equal to 3.8! 🎉 These changes revert previous changes installing `typing-extensions` regardless of Python version and modify how we import the `Literal` type to ensure that Mypy treats it properly. * resolve mypy errors for Strict pydantic types * refactor code to avoid missing return statement * fix types of convert CLI command * avoid list-set confustion in debug_data * fix typo and formatting * small fixes to avoid type ignores * fix types in profile CLI command and make it more efficient * type fixes in projects CLI * put one ignore back * type fixes for render * fix render types - the sequel * fix BaseDefault in language definitions * fix type of noun_chunks iterator - yields tuple instead of span * fix types in language-specific modules * 🏷 Expand accepted inputs of `get_string_id` `get_string_id` accepts either a string (in which case it returns its ID) or an ID (in which case it immediately returns the ID). These changes extend the type annotation of `get_string_id` to indicate that it can accept either strings or IDs. * 🏷 Handle override types in `combine_score_weights` The `combine_score_weights` function allows users to pass an `overrides` mapping to override data extracted from the `weights` argument. Since it allows `Optional` dictionary values, the return value may also include `Optional` dictionary values. These changes update the type annotations for `combine_score_weights` to reflect this fact. * 🏷 Fix tokenizer serialization method signatures in `DummyTokenizer` * 🏷 Fix redefinition of `wandb_logger` These changes fix the redefinition of `wandb_logger` by giving a separate name to each `WandbLogger` version. For backwards-compatibility, `spacy.train` still exports `wandb_logger_v3` as `wandb_logger` for now. * more fixes for typing in language * type fixes in model definitions * 🏷 Annotate `_RandomWords.probs` as `NDArray` * 🏷 Annotate `tok2vec` layers to help Mypy * 🐛 Fix `_RandomWords.probs` type annotations for Python 3.6 Also remove an import that I forgot to move to the top of the module 😅 * more fixes for matchers and other pipeline components * quick fix for entity linker * fixing types for spancat, textcat, etc * bugfix for tok2vec * type annotations for scorer * add runtime_checkable for Protocol * type and import fixes in tests * mypy fixes for training utilities * few fixes in util * fix import * 🐵 Remove unused `# type: ignore` directives * 🏷 Annotate `Language._components` * 🏷 Annotate `spacy.pipeline.Pipe` * add doc as property to span.pyi * small fixes and cleanup * explicit type annotations instead of via comment Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com> Co-authored-by: svlandeg <sofie.vanlandeghem@gmail.com> Co-authored-by: svlandeg <svlandeg@github.com> |
||
---|---|---|
.. | ||
doc | ||
lang | ||
matcher | ||
morphology | ||
package | ||
parser | ||
pipeline | ||
regression | ||
serialize | ||
tokenizer | ||
training | ||
vocab_vectors | ||
README.md | ||
__init__.py | ||
conftest.py | ||
enable_gpu.py | ||
test_architectures.py | ||
test_cli.py | ||
test_displacy.py | ||
test_errors.py | ||
test_language.py | ||
test_misc.py | ||
test_models.py | ||
test_pickles.py | ||
test_scorer.py | ||
util.py |
README.md
spaCy tests
spaCy uses the pytest framework for testing. For more info on this, see the pytest documentation.
Tests for spaCy modules and classes live in their own directories of the same name. For example, tests for the Tokenizer
can be found in /tests/tokenizer
. All test modules (i.e. directories) also need to be listed in spaCy's setup.py
. To be interpreted and run, all test files and test functions need to be prefixed with test_
.
⚠️ Important note: As part of our new model training infrastructure, we've moved all model tests to the
spacy-models
repository. This allows us to test the models separately from the core library functionality.
Table of contents
- Running the tests
- Dos and don'ts
- Parameters
- Fixtures
- Helpers and utilities
- Contributing to the tests
Running the tests
To show print statements, run the tests with py.test -s
. To abort after the
first failure, run them with py.test -x
.
py.test spacy # run basic tests
py.test spacy --slow # run basic and slow tests
You can also run tests in a specific file or directory, or even only one specific test:
py.test spacy/tests/tokenizer # run all tests in directory
py.test spacy/tests/tokenizer/test_exceptions.py # run all tests in file
py.test spacy/tests/tokenizer/test_exceptions.py::test_tokenizer_handles_emoji # run specific test
Dos and don'ts
To keep the behavior of the tests consistent and predictable, we try to follow a few basic conventions:
- Test names should follow a pattern of
test_[module]_[tested behaviour]
. For example:test_tokenizer_keeps_email
ortest_spans_override_sentiment
. - If you're testing for a bug reported in a specific issue, always create a regression test. Regression tests should be named
test_issue[ISSUE NUMBER]
and live in theregression
directory. - Only use
@pytest.mark.xfail
for tests that should pass, but currently fail. To test for desired negative behavior, useassert not
in your test. - Very extensive tests that take a long time to run should be marked with
@pytest.mark.slow
. If your slow test is testing important behavior, consider adding an additional simpler version. - If tests require loading the models, they should be added to the
spacy-models
tests. - Before requiring the models, always make sure there is no other way to test the particular behavior. In a lot of cases, it's sufficient to simply create a
Doc
object manually. See the section on helpers and utility functions for more info on this. - Avoid unnecessary imports. There should never be a need to explicitly import spaCy at the top of a file, and many components are available as fixtures. You should also avoid wildcard imports (
from module import *
). - If you're importing from spaCy, always use absolute imports. For example:
from spacy.language import Language
. - Try to keep the tests readable and concise. Use clear and descriptive variable names (
doc
,tokens
andtext
are great), keep it short and only test for one behavior at a time.
Parameters
If the test cases can be extracted from the test, always parametrize
them instead of hard-coding them into the test:
@pytest.mark.parametrize('text', ["google.com", "spacy.io"])
def test_tokenizer_keep_urls(tokenizer, text):
tokens = tokenizer(text)
assert len(tokens) == 1
This will run the test once for each text
value. Even if you're only testing one example, it's usually best to specify it as a parameter. This will later make it easier for others to quickly add additional test cases without having to modify the test.
You can also specify parameters as tuples to test with multiple values per test:
@pytest.mark.parametrize('text,length', [("U.S.", 1), ("us.", 2), ("(U.S.", 2)])
To test for combinations of parameters, you can add several parametrize
markers:
@pytest.mark.parametrize('text', ["A test sentence", "Another sentence"])
@pytest.mark.parametrize('punct', ['.', '!', '?'])
This will run the test with all combinations of the two parameters text
and punct
. Use this feature sparingly, though, as it can easily cause unnecessary or undesired test bloat.
Fixtures
Fixtures to create instances of spaCy objects and other components should only be defined once in the global conftest.py
. We avoid having per-directory conftest files, as this can easily lead to confusion.
These are the main fixtures that are currently available:
Fixture | Description |
---|---|
tokenizer |
Basic, language-independent tokenizer. Identical to the xx language class. |
en_tokenizer , de_tokenizer , ... |
Creates an English, German etc. tokenizer. |
en_vocab |
Creates an instance of the English Vocab . |
The fixtures can be used in all tests by simply setting them as an argument, like this:
def test_module_do_something(en_tokenizer):
tokens = en_tokenizer("Some text here")
If all tests in a file require a specific configuration, or use the same complex example, it can be helpful to create a separate fixture. This fixture should be added at the top of each file. Make sure to use descriptive names for these fixtures and don't override any of the global fixtures listed above. From looking at a test, it should immediately be clear which fixtures are used, and where they are coming from.
Helpers and utilities
Our new test setup comes with a few handy utility functions that can be imported from util.py
.
Constructing a Doc
object manually
Loading the models is expensive and not necessary if you're not actually testing the model performance. If all you need is a Doc
object with annotations like heads, POS tags or the dependency parse, you can construct it manually.
def test_doc_token_api_strings(en_vocab):
words = ["Give", "it", "back", "!", "He", "pleaded", "."]
pos = ['VERB', 'PRON', 'PART', 'PUNCT', 'PRON', 'VERB', 'PUNCT']
heads = [0, 0, 0, 0, 5, 5, 5]
deps = ['ROOT', 'dobj', 'prt', 'punct', 'nsubj', 'ROOT', 'punct']
doc = Doc(en_vocab, words=words, pos=pos, heads=heads, deps=deps)
assert doc[0].text == 'Give'
assert doc[0].lower_ == 'give'
assert doc[0].pos_ == 'VERB'
assert doc[0].dep_ == 'ROOT'
Other utilities
Name | Description |
---|---|
apply_transition_sequence(parser, doc, sequence) |
Perform a series of pre-specified transitions, to put the parser in a desired state. |
add_vecs_to_vocab(vocab, vectors) |
Add list of vector tuples ([("text", [1, 2, 3])] ) to given vocab. All vectors need to have the same length. |
get_cosine(vec1, vec2) |
Get cosine for two given vectors. |
assert_docs_equal(doc1, doc2) |
Compare two Doc objects and assert that they're equal. Tests for tokens, tags, dependencies and entities. |
Contributing to the tests
There's still a long way to go to finally reach 100% test coverage – and we'd appreciate your help! 🙌 You can open an issue on our issue tracker and label it tests
, or make a pull request to this repository.
📖 For more information on contributing to spaCy in general, check out our contribution guidelines.