From 709fc5e4ade928a779df3db787056e8e80ed4a57 Mon Sep 17 00:00:00 2001
From: Matthw Honnibal <honnibal+gh@gmail.com>
Date: Mon, 6 Jul 2020 17:50:21 +0200
Subject: [PATCH] Clarify dropout and seed in Tok2Vec

---
 spacy/ml/models/tok2vec.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/spacy/ml/models/tok2vec.py b/spacy/ml/models/tok2vec.py
index d2b70c36e..f1a9c7d1f 100644
--- a/spacy/ml/models/tok2vec.py
+++ b/spacy/ml/models/tok2vec.py
@@ -263,20 +263,20 @@ def build_Tok2Vec_model(
     cols = [ID, NORM, PREFIX, SUFFIX, SHAPE, ORTH]
     with Model.define_operators({">>": chain, "|": concatenate, "**": clone}):
         norm = HashEmbed(
-            nO=width, nV=embed_size, column=cols.index(NORM), dropout=dropout,
+            nO=width, nV=embed_size, column=cols.index(NORM), dropout=None,
             seed=0
         )
         if subword_features:
             prefix = HashEmbed(
-                nO=width, nV=embed_size // 2, column=cols.index(PREFIX), dropout=dropout,
+                nO=width, nV=embed_size // 2, column=cols.index(PREFIX), dropout=None,
                 seed=1
             )
             suffix = HashEmbed(
-                nO=width, nV=embed_size // 2, column=cols.index(SUFFIX), dropout=dropout,
+                nO=width, nV=embed_size // 2, column=cols.index(SUFFIX), dropout=None,
                 seed=2
             )
             shape = HashEmbed(
-                nO=width, nV=embed_size // 2, column=cols.index(SHAPE), dropout=dropout,
+                nO=width, nV=embed_size // 2, column=cols.index(SHAPE), dropout=None,
                 seed=3
             )
         else:
@@ -296,7 +296,7 @@ def build_Tok2Vec_model(
                     >> Maxout(
                         nO=width,
                         nI=width * columns,
-                        nP=maxout_pieces,
+                        nP=3,
                         dropout=0.0,
                         normalize=True,
                     ),
@@ -309,7 +309,7 @@ def build_Tok2Vec_model(
                     >> Maxout(
                         nO=width,
                         nI=width * columns,
-                        nP=maxout_pieces,
+                        nP=3,
                         dropout=0.0,
                         normalize=True,
                     ),
@@ -322,7 +322,7 @@ def build_Tok2Vec_model(
                 >> Maxout(
                     nO=width,
                     nI=width * columns,
-                    nP=maxout_pieces,
+                    nP=3,
                     dropout=0.0,
                     normalize=True,
                 ),
@@ -335,7 +335,7 @@ def build_Tok2Vec_model(
             reduce_dimensions = Maxout(
                 nO=width,
                 nI=nM * nC + width,
-                nP=maxout_pieces,
+                nP=3,
                 dropout=0.0,
                 normalize=True,
             )