From 64ec17abc15539ae07c94002364018083330001a Mon Sep 17 00:00:00 2001 From: ines Date: Sat, 18 Mar 2017 17:20:46 +0100 Subject: [PATCH] Pass xpassing tests and add xfails for failures --- spacy/tests/parser/test_sbd_prag.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/spacy/tests/parser/test_sbd_prag.py b/spacy/tests/parser/test_sbd_prag.py index 0e537122c..ba5571224 100644 --- a/spacy/tests/parser/test_sbd_prag.py +++ b/spacy/tests/parser/test_sbd_prag.py @@ -7,7 +7,7 @@ import pytest TEST_CASES = [ ("Hello World. My name is Jonas.", ["Hello World.", "My name is Jonas."]), ("What is your name? My name is Jonas.", ["What is your name?", "My name is Jonas."]), - ("There it is! I found it.", ["There it is!", "I found it."]), + pytest.mark.xfail(("There it is! I found it.", ["There it is!", "I found it."])), ("My name is Jonas E. Smith.", ["My name is Jonas E. Smith."]), ("Please turn to p. 55.", ["Please turn to p. 55."]), ("Were Jane and co. at the party?", ["Were Jane and co. at the party?"]), @@ -15,7 +15,7 @@ TEST_CASES = [ pytest.mark.xfail(("Let's ask Jane and co. They should know.", ["Let's ask Jane and co.", "They should know."])), ("They closed the deal with Pitt, Briggs & Co. It closed yesterday.", ["They closed the deal with Pitt, Briggs & Co.", "It closed yesterday."]), ("I can see Mt. Fuji from here.", ["I can see Mt. Fuji from here."]), - pytest.mark.xfail(("St. Michael's Church is on 5th st. near the light.", ["St. Michael's Church is on 5th st. near the light."])), + ("St. Michael's Church is on 5th st. near the light.", ["St. Michael's Church is on 5th st. near the light."]), ("That is JFK Jr.'s book.", ["That is JFK Jr.'s book."]), ("I visited the U.S.A. last year.", ["I visited the U.S.A. last year."]), pytest.mark.xfail(("I live in the E.U. How about you?", ["I live in the E.U.", "How about you?"])), @@ -26,10 +26,10 @@ TEST_CASES = [ ("She has $100.00 in her bag.", ["She has $100.00 in her bag."]), ("She has $100.00. It is in her bag.", ["She has $100.00.", "It is in her bag."]), ("He teaches science (He previously worked for 5 years as an engineer.) at the local University.", ["He teaches science (He previously worked for 5 years as an engineer.) at the local University."]), - pytest.mark.xfail(("Her email is Jane.Doe@example.com. I sent her an email.", ["Her email is Jane.Doe@example.com.", "I sent her an email."])), - pytest.mark.xfail(("The site is: https://www.example.50.com/new-site/awesome_content.html. Please check it out.", ["The site is: https://www.example.50.com/new-site/awesome_content.html.", "Please check it out."])), - pytest.mark.xfail(("She turned to him, 'This is great.' she said.", ["She turned to him, 'This is great.' she said."])), - ('She turned to him, "This is great." she said.', ['She turned to him, "This is great." she said.']), + ("Her email is Jane.Doe@example.com. I sent her an email.", ["Her email is Jane.Doe@example.com.", "I sent her an email."]), + ("The site is: https://www.example.50.com/new-site/awesome_content.html. Please check it out.", ["The site is: https://www.example.50.com/new-site/awesome_content.html.", "Please check it out."]), + ("She turned to him, 'This is great.' she said.", ["She turned to him, 'This is great.' she said."]), + pytest.mark.xfail(('She turned to him, "This is great." she said.', ['She turned to him, "This is great." she said.'])), ('She turned to him, "This is great." She held the book out to show him.', ['She turned to him, "This is great."', "She held the book out to show him."]), ("Hello!! Long time no see.", ["Hello!!", "Long time no see."]), ("Hello?? Who is there?", ["Hello??", "Who is there?"]), @@ -38,7 +38,7 @@ TEST_CASES = [ pytest.mark.xfail(("1.) The first item 2.) The second item", ["1.) The first item", "2.) The second item"])), pytest.mark.xfail(("1.) The first item. 2.) The second item.", ["1.) The first item.", "2.) The second item."])), pytest.mark.xfail(("1) The first item 2) The second item", ["1) The first item", "2) The second item"])), - pytest.mark.xfail(("1) The first item. 2) The second item.", ["1) The first item.", "2) The second item."])), + ("1) The first item. 2) The second item.", ["1) The first item.", "2) The second item."]), pytest.mark.xfail(("1. The first item 2. The second item", ["1. The first item", "2. The second item"])), pytest.mark.xfail(("1. The first item. 2. The second item.", ["1. The first item.", "2. The second item."])), pytest.mark.xfail(("• 9. The first item • 10. The second item", ["• 9. The first item", "• 10. The second item"])), @@ -50,7 +50,7 @@ TEST_CASES = [ ("You can find it at N°. 1026.253.553. That is where the treasure is.", ["You can find it at N°. 1026.253.553.", "That is where the treasure is."]), ("She works at Yahoo! in the accounting department.", ["She works at Yahoo! in the accounting department."]), pytest.mark.xfail(("We make a good team, you and I. Did you see Albert I. Jones yesterday?", ["We make a good team, you and I.", "Did you see Albert I. Jones yesterday?"])), - pytest.mark.xfail(("Thoreau argues that by simplifying one’s life, “the laws of the universe will appear less complex. . . .”", ["Thoreau argues that by simplifying one’s life, “the laws of the universe will appear less complex. . . .”"])), + ("Thoreau argues that by simplifying one’s life, “the laws of the universe will appear less complex. . . .”", ["Thoreau argues that by simplifying one’s life, “the laws of the universe will appear less complex. . . .”"]), (""""Bohr [...] used the analogy of parallel stairways [...]" (Smith 55).""", ['"Bohr [...] used the analogy of parallel stairways [...]" (Smith 55).']), pytest.mark.xfail(("If words are left off at the end of a sentence, and that is all that is omitted, indicate the omission with ellipsis marks (preceded and followed by a space) and then indicate the end of the sentence with a period . . . . Next sentence.", ["If words are left off at the end of a sentence, and that is all that is omitted, indicate the omission with ellipsis marks (preceded and followed by a space) and then indicate the end of the sentence with a period . . . .", "Next sentence."])), ("I never meant that.... She left the store.", ["I never meant that....", "She left the store."]),