From 56f8bc73ef1880ded2abe9da5a5ff26ca6babc20 Mon Sep 17 00:00:00 2001
From: Ines Montani <ines@ines.io>
Date: Tue, 29 Sep 2020 15:23:34 +0200
Subject: [PATCH] Add more tests

---
 spacy/tests/pipeline/test_initialize.py | 32 +++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/spacy/tests/pipeline/test_initialize.py b/spacy/tests/pipeline/test_initialize.py
index 974556b1c..1d2e7e5a3 100644
--- a/spacy/tests/pipeline/test_initialize.py
+++ b/spacy/tests/pipeline/test_initialize.py
@@ -9,34 +9,58 @@ from pydantic import StrictBool
 def test_initialize_arguments():
     name = "test_initialize_arguments"
 
+    class CustomTokenizer:
+        def __init__(self, tokenizer):
+            self.tokenizer = tokenizer
+            self.from_initialize = None
+
+        def __call__(self, text):
+            return self.tokenizer(text)
+
+        def initialize(self, get_examples, nlp, custom: int):
+            self.from_initialize = custom
+
     class Component:
         def __init__(self):
-            ...
+            self.from_initialize = None
 
         def initialize(
             self, get_examples, nlp, custom1: str, custom2: StrictBool = False
         ):
-            ...
+            self.from_initialize = (custom1, custom2)
 
     Language.factory(name, func=lambda nlp, name: Component())
 
     nlp = English()
+    nlp.tokenizer = CustomTokenizer(nlp.tokenizer)
     example = Example.from_dict(nlp("x"), {})
     get_examples = lambda: [example]
     nlp.add_pipe(name)
     # The settings here will typically come from the [initialize] block
     with pytest.raises(ConfigValidationError) as e:
         # Empty settings, no required custom1 argument
-        nlp.initialize(get_examples, settings={"components": {name: {}}})
+        settings = {"tokenizer": {"custom": 1}, "components": {name: {}}}
+        nlp.initialize(get_examples, settings=settings)
     errors = e.value.errors
     assert len(errors) == 1
     assert errors[0]["loc"] == ("custom1",)
     assert errors[0]["type"] == "value_error.missing"
     with pytest.raises(ConfigValidationError) as e:
         # Wrong type
-        settings = {"components": {name: {"custom1": "x", "custom2": 1}}}
+        settings = {
+            "tokenizer": {"custom": 1},
+            "components": {name: {"custom1": "x", "custom2": 1}},
+        }
         nlp.initialize(get_examples, settings=settings)
     errors = e.value.errors
     assert len(errors) == 1
     assert errors[0]["loc"] == ("custom2",)
     assert errors[0]["type"] == "value_error.strictbool"
+    settings = {
+        "tokenizer": {"custom": 1},
+        "components": {name: {"custom1": "x", "custom2": True}},
+    }
+    nlp.initialize(get_examples, settings=settings)
+    assert nlp.tokenizer.from_initialize == 1
+    pipe = nlp.get_pipe(name)
+    assert pipe.from_initialize == ("x", True)