From 63b7c2ef619f2cf3f0be29ec8ac0f6903a6801d6 Mon Sep 17 00:00:00 2001 From: Sam Bozek Date: Wed, 26 Oct 2016 18:20:08 -0700 Subject: [PATCH 1/2] Added pull request template. Making following assumptions: * Pull requests do not need to originate from Issues discussion. * But encouraged * No current CONTRIBUTING.md file * honor code that people follow current coding conventions * Tests run and passed * New features require additonal tests for confirmation --- .github/PULL_REQUEST_TEMPLATE.md | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..5d28f0ff2 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,30 @@ + + +## Description + + +## Motivation and Context + + + +## How Has This Been Tested? + + + + +## Screenshots (if appropriate): + +## Types of changes + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to change) + +## Checklist: + + +- [ ] My code follows the code style of this project. +- [ ] My change requires a change to the documentation. +- [ ] I have updated the documentation accordingly. +- [ ] I have added tests to cover my changes. +- [ ] All new and existing tests passed. \ No newline at end of file From 3e1dbbd52a0250d366684dbbbed5529278682642 Mon Sep 17 00:00:00 2001 From: Sam Bozek Date: Wed, 26 Oct 2016 18:27:56 -0700 Subject: [PATCH 2/2] Clarified a few statements on the pull request template. * Added spaCy to several areas to avoid confusion * Simplified a few statements and checkboxes. --- .github/PULL_REQUEST_TEMPLATE.md | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5d28f0ff2..e99d6dadc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,30 +1,30 @@ - + ## Description - + ## Motivation and Context - + ## How Has This Been Tested? - - - + + + ## Screenshots (if appropriate): ## Types of changes - -- [ ] Bug fix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds functionality) -- [ ] Breaking change (fix or feature that would cause existing functionality to change) + +- [ ] Bug fix (non-breaking change fixing an issue) +- [ ] New feature (non-breaking change adding functionality to spaCy) +- [ ] Breaking change (fix or feature causing change to spaCy's existing functionality) +- [ ] Documentation (Addition to documentation of spaCy) ## Checklist: - - -- [ ] My code follows the code style of this project. -- [ ] My change requires a change to the documentation. + +- [ ] My code follows spaCy's code style. +- [ ] My change requires a change to spaCy's documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. \ No newline at end of file