Update br tags (#12882)

* Fix displacy br tag

* Prefer <br>, also update package CLI

spacy/cli/package.py

@@ -403,7 +403,7 @@ def _format_sources(data: Any) -> str:
         if author:
             result += " ({})".format(author)
         sources.append(result)
-    return "<br />".join(sources)
+    return "<br>".join(sources)
 
 
 def _format_accuracy(data: Dict[str, Any], exclude: List[str] = ["speed"]) -> str:

spacy/displacy/render.py

@@ -567,7 +567,7 @@ class EntityRenderer:
             for i, fragment in enumerate(fragments):
                 markup += escape_html(fragment)
                 if len(fragments) > 1 and i != len(fragments) - 1:
-                    markup += "</br>"
+                    markup += "<br>"
             if self.ents is None or label.upper() in self.ents:
                 color = self.colors.get(label.upper(), self.default_color)
                 ent_settings = {
@@ -585,7 +585,7 @@ class EntityRenderer:
         for i, fragment in enumerate(fragments):
             markup += escape_html(fragment)
             if len(fragments) > 1 and i != len(fragments) - 1:
-                markup += "</br>"
+                markup += "<br>"
         markup = TPL_ENTS.format(content=markup, dir=self.direction)
         if title:
             markup = TPL_TITLE.format(title=title) + markup

spacy/tests/test_displacy.py

@@ -113,7 +113,7 @@ def test_issue5838():
     doc = nlp(sample_text)
     doc.ents = [Span(doc, 7, 8, label="test")]
     html = displacy.render(doc, style="ent")
-    found = html.count("</br>")
+    found = html.count("<br>")
     assert found == 4