Rooba
/
spaCy
mirror of https://github.com/explosion/spaCy.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update and add test

This commit is contained in:
Ines Montani 2021-02-10 14:12:00 +11:00
parent 8ed788660b
commit 21176c69b0
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
spacy/tests/pipeline/test_pipe_factories.py
View File

@ -451,13 +451,27 @@ def test_pipe_factories_from_source_config():
assert config["arg"] == "world" assert config["arg"] == "world"
def test_pipe_factories_decorator_idempotent(): class PipeFactoriesIdempotent:
def __init__(self, nlp, name):
...
def __call__(self, doc):
...
@pytest.mark.parametrize(
"i,func,func2",
[
(0, lambda nlp, name: lambda doc: doc, lambda doc: doc),
(1, PipeFactoriesIdempotent, PipeFactoriesIdempotent(None, None)),
],
)
def test_pipe_factories_decorator_idempotent(i, func, func2):
"""Check that decorator can be run multiple times if the function is the """Check that decorator can be run multiple times if the function is the
same. This is especially relevant for live reloading because we don't same. This is especially relevant for live reloading because we don't
want spaCy to raise an error if a module registering components is reloaded. want spaCy to raise an error if a module registering components is reloaded.
""" """
name = "test_pipe_factories_decorator_idempotent" name = f"test_pipe_factories_decorator_idempotent_{i}"
func = lambda nlp, name: lambda doc: doc
for i in range(5): for i in range(5):
Language.factory(name, func=func) Language.factory(name, func=func)
nlp = Language() nlp = Language()
@ -466,7 +480,6 @@ def test_pipe_factories_decorator_idempotent():
# Make sure it also works for component decorator, which creates the # Make sure it also works for component decorator, which creates the
# factory function # factory function
name2 = f"{name}2" name2 = f"{name}2"
func2 = lambda doc: doc
for i in range(5): for i in range(5):
Language.component(name2, func=func2) Language.component(name2, func=func2)
nlp = Language() nlp = Language()

2
spacy/util.py
View File

@ -930,7 +930,7 @@ def is_same_func(func1: Callable, func2: Callable) -> bool:
""" """
if not callable(func1) or not callable(func2): if not callable(func1) or not callable(func2):
return False return False
if not hasattr(func1,"__qualname__") or not hasattr(func2,"__qualname__"): if not hasattr(func1, "__qualname__") or not hasattr(func2, "__qualname__"):
return False return False
same_name = func1.__qualname__ == func2.__qualname__ same_name = func1.__qualname__ == func2.__qualname__
same_file = inspect.getfile(func1) == inspect.getfile(func2) same_file = inspect.getfile(func1) == inspect.getfile(func2)