Rooba
/
spaCy
mirror of https://github.com/explosion/spaCy.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

* Add comment to fill_context

This commit is contained in:
Matthew Honnibal 2015-03-24 04:39:58 +01:00
parent 2741179aff
commit 01c892f583
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spacy/syntax/_parse_features.pyx
View File

@ -7,6 +7,8 @@ out of "context") is in features/extractor.pyx
The atomic feature names are listed in a big enum, so that the feature tuples The atomic feature names are listed in a big enum, so that the feature tuples
can refer to them. can refer to them.
""" """
from libc.string cimport memset
from itertools import combinations from itertools import combinations
from ..tokens cimport TokenC from ..tokens cimport TokenC
@ -53,8 +55,10 @@ cdef inline void fill_token(atom_t* context, const TokenC* token) nogil:
cdef int fill_context(atom_t* context, State* state) except -1: cdef int fill_context(atom_t* context, State* state) except -1:
# This fills in the basic properties of each of our "slot" tokens, e.g. # Take care to fill every element of context!
# word on top of the stack, word at the front of the buffer, etc. # We could memset, but this makes it very easy to have broken features that
# make almost no impact on accuracy. If instead they're unset, the impact
# tends to be dramatic, so we get an obvious regression to fix...
fill_token(&context[S2w], get_s2(state)) fill_token(&context[S2w], get_s2(state))
fill_token(&context[S1w], get_s1(state)) fill_token(&context[S1w], get_s1(state))
fill_token(&context[S1rw], get_right(state, get_s1(state), 1)) fill_token(&context[S1rw], get_right(state, get_s1(state), 1))