2020-07-22 20:18:46 +00:00
|
|
|
from typing import Union, Iterator
|
|
|
|
|
2018-02-05 13:45:05 +00:00
|
|
|
from ...symbols import NOUN, PROPN, PRON
|
2020-05-14 10:58:06 +00:00
|
|
|
from ...errors import Errors
|
2020-07-22 20:18:46 +00:00
|
|
|
from ...tokens import Doc, Span
|
2018-02-05 13:45:05 +00:00
|
|
|
|
|
|
|
|
2020-07-22 20:18:46 +00:00
|
|
|
def noun_chunks(doclike: Union[Doc, Span]) -> Iterator[Span]:
|
|
|
|
"""Detect base noun phrases from a dependency parse. Works on Doc and Span."""
|
|
|
|
# fmt: off
|
|
|
|
labels = ["nsubj", "nsubj:pass", "obj", "iobj", "ROOT", "appos", "nmod", "nmod:poss"]
|
|
|
|
# fmt: on
|
2020-05-21 13:17:39 +00:00
|
|
|
doc = doclike.doc # Ensure works on both Doc and Span.
|
2020-05-14 10:58:06 +00:00
|
|
|
if not doc.is_parsed:
|
|
|
|
raise ValueError(Errors.E029)
|
2018-02-05 13:45:05 +00:00
|
|
|
np_deps = [doc.vocab.strings[label] for label in labels]
|
💫 Tidy up and auto-format .py files (#2983)
<!--- Provide a general summary of your changes in the title. -->
## Description
- [x] Use [`black`](https://github.com/ambv/black) to auto-format all `.py` files.
- [x] Update flake8 config to exclude very large files (lemmatization tables etc.)
- [x] Update code to be compatible with flake8 rules
- [x] Fix various small bugs, inconsistencies and messy stuff in the language data
- [x] Update docs to explain new code style (`black`, `flake8`, when to use `# fmt: off` and `# fmt: on` and what `# noqa` means)
Once #2932 is merged, which auto-formats and tidies up the CLI, we'll be able to run `flake8 spacy` actually get meaningful results.
At the moment, the code style and linting isn't applied automatically, but I'm hoping that the new [GitHub Actions](https://github.com/features/actions) will let us auto-format pull requests and post comments with relevant linting information.
### Types of change
enhancement, code style
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
2018-11-30 16:03:03 +00:00
|
|
|
conj = doc.vocab.strings.add("conj")
|
|
|
|
np_label = doc.vocab.strings.add("NP")
|
2020-05-21 17:15:57 +00:00
|
|
|
prev_end = -1
|
2020-05-21 13:17:39 +00:00
|
|
|
for i, word in enumerate(doclike):
|
2018-02-05 13:45:05 +00:00
|
|
|
if word.pos not in (NOUN, PROPN, PRON):
|
|
|
|
continue
|
|
|
|
# Prevent nested chunks from being produced
|
2020-05-21 17:15:57 +00:00
|
|
|
if word.left_edge.i <= prev_end:
|
2018-02-05 13:45:05 +00:00
|
|
|
continue
|
|
|
|
if word.dep in np_deps:
|
2020-05-21 17:56:56 +00:00
|
|
|
prev_end = word.right_edge.i
|
💫 Tidy up and auto-format .py files (#2983)
<!--- Provide a general summary of your changes in the title. -->
## Description
- [x] Use [`black`](https://github.com/ambv/black) to auto-format all `.py` files.
- [x] Update flake8 config to exclude very large files (lemmatization tables etc.)
- [x] Update code to be compatible with flake8 rules
- [x] Fix various small bugs, inconsistencies and messy stuff in the language data
- [x] Update docs to explain new code style (`black`, `flake8`, when to use `# fmt: off` and `# fmt: on` and what `# noqa` means)
Once #2932 is merged, which auto-formats and tidies up the CLI, we'll be able to run `flake8 spacy` actually get meaningful results.
At the moment, the code style and linting isn't applied automatically, but I'm hoping that the new [GitHub Actions](https://github.com/features/actions) will let us auto-format pull requests and post comments with relevant linting information.
### Types of change
enhancement, code style
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
2018-11-30 16:03:03 +00:00
|
|
|
yield word.left_edge.i, word.right_edge.i + 1, np_label
|
2018-02-05 13:45:05 +00:00
|
|
|
elif word.dep == conj:
|
|
|
|
head = word.head
|
|
|
|
while head.dep == conj and head.head.i < head.i:
|
|
|
|
head = head.head
|
|
|
|
# If the head is an NP, and we're coordinated to it, we're an NP
|
|
|
|
if head.dep in np_deps:
|
2020-05-21 17:56:56 +00:00
|
|
|
prev_end = word.right_edge.i
|
💫 Tidy up and auto-format .py files (#2983)
<!--- Provide a general summary of your changes in the title. -->
## Description
- [x] Use [`black`](https://github.com/ambv/black) to auto-format all `.py` files.
- [x] Update flake8 config to exclude very large files (lemmatization tables etc.)
- [x] Update code to be compatible with flake8 rules
- [x] Fix various small bugs, inconsistencies and messy stuff in the language data
- [x] Update docs to explain new code style (`black`, `flake8`, when to use `# fmt: off` and `# fmt: on` and what `# noqa` means)
Once #2932 is merged, which auto-formats and tidies up the CLI, we'll be able to run `flake8 spacy` actually get meaningful results.
At the moment, the code style and linting isn't applied automatically, but I'm hoping that the new [GitHub Actions](https://github.com/features/actions) will let us auto-format pull requests and post comments with relevant linting information.
### Types of change
enhancement, code style
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
2018-11-30 16:03:03 +00:00
|
|
|
yield word.left_edge.i, word.right_edge.i + 1, np_label
|
2018-02-05 13:45:05 +00:00
|
|
|
|
|
|
|
|
💫 Tidy up and auto-format .py files (#2983)
<!--- Provide a general summary of your changes in the title. -->
## Description
- [x] Use [`black`](https://github.com/ambv/black) to auto-format all `.py` files.
- [x] Update flake8 config to exclude very large files (lemmatization tables etc.)
- [x] Update code to be compatible with flake8 rules
- [x] Fix various small bugs, inconsistencies and messy stuff in the language data
- [x] Update docs to explain new code style (`black`, `flake8`, when to use `# fmt: off` and `# fmt: on` and what `# noqa` means)
Once #2932 is merged, which auto-formats and tidies up the CLI, we'll be able to run `flake8 spacy` actually get meaningful results.
At the moment, the code style and linting isn't applied automatically, but I'm hoping that the new [GitHub Actions](https://github.com/features/actions) will let us auto-format pull requests and post comments with relevant linting information.
### Types of change
enhancement, code style
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
2018-11-30 16:03:03 +00:00
|
|
|
SYNTAX_ITERATORS = {"noun_chunks": noun_chunks}
|