From db9615b19d595c70714fc14619a06cad3408a4d8 Mon Sep 17 00:00:00 2001 From: gpotter2 Date: Tue, 27 Jun 2017 23:20:49 +0200 Subject: [PATCH] Contributing notes --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4f24ae233..e8ca16a0f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -121,6 +121,10 @@ The project aims to provide code that works both on Python 2 and Python 3. There - use scapy.modules.six.range instead of xrange and range - use scapy.modules.six.itervalues(dict) instead of dict.values() or dict.itervalues() - use scapy.modules.six.string_types instead of basestring +- `__bool__ = __nonzero__` must be used when declaring `__nonzero__` methods +- `io.BytesIO` must be used instead of `StringIO` when using bytes +- `__cmp__` must not be used. +- UserDict should be imported via `six.UserDict` ### Code review