Rooba
/
rq
mirror of https://github.com/rq/rq.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove is_done property. 

It is too similar to is_finished.
This commit is contained in:
Vincent Driessen 2012-08-27 12:10:19 +02:00
parent bc7e32bae8
commit 6b0ebe9ceb
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rq/job.py
View File

@ -103,10 +103,6 @@ class Job(object):
def is_failed(self):
return self.status == Status.FAILED
@property
def is_done(self):
return self._status is not None and not self.is_queued
@property
def func(self):
func_name = self.func_name

3
tests/test_worker.py
View File

@ -181,7 +181,6 @@ class TestWorker(RQTestCase):
self.assertEqual(job.is_queued, True)
self.assertEqual(job.is_finished, False)
self.assertEqual(job.is_failed, False)
self.assertEqual(job.is_done, False)
w.work(burst=True)
job = Job.fetch(job.id)
@ -189,7 +188,6 @@ class TestWorker(RQTestCase):
self.assertEqual(job.is_queued, False)
self.assertEqual(job.is_finished, True)
self.assertEqual(job.is_failed, False)
self.assertEqual(job.is_done, True)
# Failed jobs should set status to "failed"
job = q.enqueue(div_by_zero, args=(1,))
@ -199,4 +197,3 @@ class TestWorker(RQTestCase):
self.assertEqual(job.is_queued, False)
self.assertEqual(job.is_finished, False)
self.assertEqual(job.is_failed, True)
self.assertEqual(job.is_done, True)