Rooba
/
rq
mirror of https://github.com/rq/rq.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Support callbacks in enqueue_many (#1686) 

The on_success and on_failure callbacks are currently supported in
Queue.enqueue but not Queue.enqueue_many, despite documentary indicating
the contrary.

This commit brings the bulk enqueuing API back into parity.

Fixes #1680
This commit is contained in:
Yang Yang 2022-08-02 19:09:24 -04:00 committed by GitHub
parent 98c200d07a
commit 3f59a7e6e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rq/queue.py
View File

@ -23,7 +23,7 @@ def compact(lst):
class EnqueueData(namedtuple('EnqueueData', ["func", "args", "kwargs", "timeout",
"result_ttl", "ttl", "failure_ttl",
"description", "job_id",
"at_front", "meta", "retry"])):
"at_front", "meta", "retry", "on_success", "on_failure"])):
"""Helper type to use when calling enqueue_many
NOTE: Does not support `depends_on` yet.
"""
@ -417,14 +417,14 @@ class Queue:
def prepare_data(func, args=None, kwargs=None, timeout=None,
result_ttl=None, ttl=None, failure_ttl=None,
description=None, job_id=None,
at_front=False, meta=None, retry=None):
at_front=False, meta=None, retry=None, on_success=None, on_failure=None):
# Need this till support dropped for python_version < 3.7, where defaults can be specified for named tuples
# And can keep this logic within EnqueueData
return EnqueueData(
func, args, kwargs, timeout,
result_ttl, ttl, failure_ttl,
description, job_id,
at_front, meta, retry
at_front, meta, retry, on_success, on_failure
)
def enqueue_many(
@ -446,7 +446,9 @@ class Queue:
depends_on=None,
job_id=job_data.job_id, meta=job_data.meta, status=JobStatus.QUEUED,
timeout=job_data.timeout,
retry=job_data.retry
retry=job_data.retry,
on_success=job_data.on_success,
on_failure=job_data.on_failure
),
pipeline=pipe,
at_front=job_data.at_front