rich/CONTRIBUTING.md

65 lines
1.5 KiB
Markdown
Raw Normal View History

2020-06-20 18:43:10 +00:00
# Contributing to Rich
2020-12-02 22:38:23 +00:00
This project welcomes contributions in the form of Pull Requests.
For clear bug-fixes / typos etc. just submit a PR.
For new features or if there is any doubt in how to fix a bug, you might want
to open an issue prior to starting work, or email willmcgugan+rich@gmail.com
2020-11-28 12:32:15 +00:00
to discuss it first.
2020-06-20 18:43:10 +00:00
## Development Environment
2020-12-02 22:38:23 +00:00
Rich uses [poetry](https://python-poetry.org/docs/) for packaging and
dependency management. To start developing with Rich, install Poetry
using the [recommended method](https://python-poetry.org/docs/#installation) or run:
2020-11-30 08:43:53 +00:00
```
pip install poetry
```
2020-12-02 22:38:23 +00:00
Once Poetry is installed, install the dependencies with the following command:
2020-06-20 18:43:10 +00:00
```
poetry install
```
### Tests
Run tests with the following command:
```
2020-06-21 11:26:08 +00:00
make test
2020-06-20 18:43:10 +00:00
```
Or if you don't have `make`, run the following:
2020-06-20 18:43:10 +00:00
```
pytest --cov-report term-missing --cov=rich tests/ -vv
```
New code should ideally have tests and not break existing tests.
### Type Checking
2020-12-02 22:38:23 +00:00
Rich uses type annotations throughout, and `mypy` to do the checking.
2020-11-28 12:32:15 +00:00
Run the following to type check Rich:
2020-06-20 18:43:10 +00:00
```
make typecheck
```
Or if you don't have `make`:
```
mypy -p rich --ignore-missing-imports --warn-unreachable
```
Please add type annotations for all new code.
### Code Formatting
Rich uses [`black`](https://github.com/psf/black) for code formatting.
I recommend setting up black in your editor to format on save.
To run black from the command line, use `make format-check` to check your formatting,
2020-12-02 22:38:23 +00:00
and use `make format` to format and write to the files.