Commit Graph

5 Commits

Author SHA1 Message Date
Gyeongjae Choi 21625f0fa5
Fix recipes that do not link to their dependencies correctly (#4878)
Split off from #4876.

What this PR does is basically fixing incorrect shared library dependencies.

For instance, `cryptography` package depends on `openssl`, so the python
extension should link to `libssl.so`.

However, before this PR, it was not linked correctly.

```sh
$  pyodide auditwheel show cryptography-42.0.5-cp312-cp312-pyodide_2024_0_wasm32.whl
{'cryptography\\hazmat\\bindings\\_rust.cpython-312-wasm32-emscripten.so': []}
```

After this PR, it is linked correctly.

```bash
$ pyodide auditwheel show cryptography-42.0.5-cp312-cp312-pyodide_2024_0_wasm32.whl
{
│   'cryptography\\hazmat\\bindings\\_rust.cpython-312-wasm32-emscripten.so': [
│   │   'libssl.so',
│   │   'libcrypto.so'
│   ]
}
```

__Why do we need this change?__

Because it is how shared libraries should work.

__Why was this working before?__

Because we loaded dependencies globally. `openssl` is loaded globally, so its
symbols were visible to `cryptography` even if they are not linked. However,
#4876 will change all library loading mechanism to local, so all shared
libraries should now have correct dependencies to work.
2024-06-21 12:56:21 -07:00
Gyeongjae Choi cc6b585d09
Add missing library dependencies to packages (#4735)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-05-03 20:22:40 +09:00
Gyeongjae Choi 06bbb38ee8
Remove version suffix from shared libraries (#4353) 2023-12-25 09:40:16 +01:00
Gyeongjae Choi b41b9ea3d5
CI Split package build steps as a temporary solution for CI timeout (#4106) 2023-09-01 20:31:24 +09:00
Juniper Tyree 313bc4bb72
Add `netcdf4` package (#3910) 2023-06-26 21:20:53 +09:00