From e1eed81a61eae4d7a3fb76843f693a39b4e53983 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Mon, 29 Mar 2021 16:52:01 -0400 Subject: [PATCH] MAINT Fix test failures due to negative refcounts by using selenium_standalone (#1387) --- src/tests/test_jsproxy.py | 9 ++++++--- src/tests/test_typeconversions.py | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/tests/test_jsproxy.py b/src/tests/test_jsproxy.py index ec6ab383b..71890d21c 100644 --- a/src/tests/test_jsproxy.py +++ b/src/tests/test_jsproxy.py @@ -376,7 +376,8 @@ def test_window_isnt_super_weird_anymore(): @pytest.mark.skip_refcount_check -def test_mount_object(selenium): +def test_mount_object(selenium_standalone): + selenium = selenium_standalone result = selenium.run_js( """ function x1(){ @@ -458,7 +459,8 @@ def test_unregister_jsmodule_error(selenium): @pytest.mark.skip_refcount_check -def test_nested_import(selenium): +def test_nested_import(selenium_standalone): + selenium = selenium_standalone assert ( selenium.run_js( """ @@ -478,7 +480,8 @@ def test_nested_import(selenium): @pytest.mark.skip_refcount_check -def test_register_jsmodule_docs_example(selenium): +def test_register_jsmodule_docs_example(selenium_standalone): + selenium = selenium_standalone selenium.run_js( """ let my_module = { diff --git a/src/tests/test_typeconversions.py b/src/tests/test_typeconversions.py index 27a032d6a..b2f361fa7 100644 --- a/src/tests/test_typeconversions.py +++ b/src/tests/test_typeconversions.py @@ -1,11 +1,12 @@ # See also test_pyproxy, test_jsproxy, and test_python. import pytest -from hypothesis import given +from hypothesis import given, settings from hypothesis.strategies import text from conftest import selenium_context_manager @given(s=text()) +@settings(deadline=600) def test_string_conversion(selenium_module_scope, s): with selenium_context_manager(selenium_module_scope) as selenium: # careful string escaping here -- hypothesis will fuzz it.