From da49fe57de853bbe234a1aaec6c2244c02cac38d Mon Sep 17 00:00:00 2001 From: Grimmer Kang Date: Sun, 28 Nov 2021 03:43:31 +0800 Subject: [PATCH] MAINT use npm ci to make sure the consistent dependencies installed (#1999) --- .circleci/config.yml | 4 ++-- Makefile | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 0dcf648da..fe7b1fe48 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -227,14 +227,14 @@ jobs: command: | cd src/js npx tsd - npm install + npm ci npm test - run: name: check if webpack cli works well with load-pyodide.js command: | git clone https://github.com/pyodide/pyodide-webpack-example.git cd pyodide-webpack-example - npm install + npm ci cp ../src/js/load-pyodide.js node_modules/pyodide/load-pyodide.js head -20 node_modules/pyodide/load-pyodide.js npx webpack diff --git a/Makefile b/Makefile index 7fcb5999b..854b96594 100644 --- a/Makefile +++ b/Makefile @@ -67,8 +67,8 @@ env: env -node_modules/.installed : src/js/package.json - cd src/js && npm install --save-dev +node_modules/.installed : src/js/package.json src/js/package-lock.json + cd src/js && npm ci ln -sfn src/js/node_modules/ node_modules touch node_modules/.installed