From b886ed2065d60754d96fc311ef6a418c7288b1ce Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Mon, 22 Apr 2024 06:12:44 -0400 Subject: [PATCH] fix: support cmake command mode (#4705) --- docs/project/changelog.md | 2 ++ pyodide-build/pyodide_build/pywasmcross.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/project/changelog.md b/docs/project/changelog.md index 43f5508bc..4e8dfbee0 100644 --- a/docs/project/changelog.md +++ b/docs/project/changelog.md @@ -16,6 +16,8 @@ myst: ## Unreleased +- {{ Fix }} Pass through `-E` (command mode) arguments in CMake wrapper {pr}`4705`. + - {{ Fix }} Fix exception handling in dynamic linking of int64 functions {pr}`4698`. - {{ Enhancement }} `str(jsproxy)` has been adjusted to not raise an error if diff --git a/pyodide-build/pyodide_build/pywasmcross.py b/pyodide-build/pyodide_build/pywasmcross.py index 64af4f3c6..3c77b8345 100755 --- a/pyodide-build/pyodide_build/pywasmcross.py +++ b/pyodide-build/pyodide_build/pywasmcross.py @@ -479,7 +479,7 @@ def handle_command_generate_args( # noqa: C901 return line elif cmd == "cmake": # If it is a build/install command, or running a script, we don't do anything. - if "--build" in line or "--install" in line or "-P" in line: + if "--build" in line or "--install" in line or "-P" in line or "-E" in line: return line flags = get_cmake_compiler_flags()