Rooba
/
pyodide
mirror of https://github.com/pyodide/pyodide.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

python3.12-compatibile python2js bigint conversion (#3918) 

Using `Py_SIZE` on `PyLongObject` is no longer allowed in Python 3.12. Less
importantly, we are minorly overestimating the size of very large numbers here
since each digit has only 30 bits, so a 16 "digit" number has 480 bits and fits
into 15 u32s.
This commit is contained in:
Hood Chatham 2023-06-10 19:00:24 -07:00 committed by GitHub
parent dea990420e
commit 1b8dd35081
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/python2js.c
View File

@ -99,7 +99,11 @@ _python2js_long(PyObject* x)
if (!overflow) {
FAIL_IF_ERR_OCCURRED();
} else {
size_t ndigits = Py_ABS(Py_SIZE(x));
// We want to group into u32 chunks for convenience of
// hiwire_int_from_digits. If the number of bits is evenly divisible by
// 32, we overestimate the number of needed u32s by one.
size_t nbits = _PyLong_NumBits(x);
size_t ndigits = (nbits >> 5) + 1;
unsigned int digits[ndigits];
FAIL_IF_MINUS_ONE(_PyLong_AsByteArray((PyLongObject*)x,
(unsigned char*)digits,