From 3f9f2dc37fd8a82b7f7c7688d9bc633c67e55738 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?K=C3=B3kai=20P=C3=A9ter?= <peter.kokai@balabit.com>
Date: Tue, 7 Nov 2017 23:29:44 +0100
Subject: [PATCH] fix(github): Handle curl exceptions and bad status codes
 (#811)

If any error occurs, a warning is logged and -1
is displayed as the number of notifications
---
 include/modules/github.hpp |  5 ++++-
 src/modules/github.cpp     | 45 ++++++++++++++++++++++++++------------
 2 files changed, 35 insertions(+), 15 deletions(-)

diff --git a/include/modules/github.hpp b/include/modules/github.hpp
index 84db9107..845569d1 100644
--- a/include/modules/github.hpp
+++ b/include/modules/github.hpp
@@ -1,7 +1,7 @@
 #pragma once
 
-#include "settings.hpp"
 #include "modules/meta/timer_module.hpp"
+#include "settings.hpp"
 #include "utils/http.hpp"
 
 POLYBAR_NS
@@ -18,6 +18,9 @@ namespace modules {
     bool build(builder* builder, const string& tag) const;
 
    private:
+    void update_label(const int);
+    int get_number_of_notification();
+    string request();
     static constexpr auto TAG_LABEL = "<label>";
 
     label_t m_label{};
diff --git a/src/modules/github.cpp b/src/modules/github.cpp
index 9eb04379..dab58c93 100644
--- a/src/modules/github.cpp
+++ b/src/modules/github.cpp
@@ -25,11 +25,7 @@ namespace modules {
     if (m_formatter->has(TAG_LABEL)) {
       m_label = load_optional_label(m_conf, name(), TAG_LABEL, "Notifications: %notifications%");
 
-      if (m_empty_notifications) {
-        m_label->replace_token("%notifications%", "0");
-      } else {
-        m_label->clear();
-      }
+      update_label(0);
     }
   }
 
@@ -37,9 +33,17 @@ namespace modules {
    * Update module contents
    */
   bool github_module::update() {
-    string content{m_http->get("https://api.github.com/notifications?access_token=" + m_accesstoken)};
-    long response_code{m_http->response_code()};
+    auto notification = get_number_of_notification();
 
+    update_label(notification);
+
+    return true;
+  }
+
+  string github_module::request() {
+    string content{m_http->get("https://api.github.com/notifications?access_token=" + m_accesstoken)};
+
+    long response_code{m_http->response_code()};
     switch (response_code) {
       case 200:
         break;
@@ -51,6 +55,18 @@ namespace modules {
         throw module_error("Unspecified error (" + to_string(response_code) + ")");
     }
 
+    return content;
+  }
+
+  int github_module::get_number_of_notification() {
+    string content;
+    try {
+      content = request();
+    } catch (application_error& e) {
+      m_log.warn("%s: cannot complete the request to github: %s", name(), e.what());
+      return -1;
+    }
+
     size_t pos{0};
     size_t notifications{0};
 
@@ -58,25 +74,26 @@ namespace modules {
       notifications++;
     }
 
-    if (notifications || m_empty_notifications) {
+    return notifications;
+  }
+
+  void github_module::update_label(const int notifications) {
+    if (0 != notifications || m_empty_notifications) {
       m_label->reset_tokens();
       m_label->replace_token("%notifications%", to_string(notifications));
     } else {
       m_label->clear();
     }
-
-    return true;
   }
 
   /**
    * Build module content
    */
   bool github_module::build(builder* builder, const string& tag) const {
-    if (tag == TAG_LABEL) {
-      builder->node(m_label);
-    } else {
+    if (tag != TAG_LABEL)
       return false;
-    }
+
+    builder->node(m_label);
     return true;
   }
 }