Rooba
/
pokeemerald
mirror of https://github.com/pret/pokeemerald.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Created Surfing Dismount Ground Effects (markdown)

ghoulslash 2020-07-23 22:52:17 -06:00
parent 0e162cddeb
commit 9b74414935
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Surfing-Dismount-Ground-Effects.md Normal file

@ -0,0 +1,16 @@
### Fix Surfing Dismount Ground Effects Bug
In vanilla emerald, the ground effects are not updated at the end of the surf dismount code. So if you dismount into tall grass, for example, you will appear over the grass. This is subtle but easily fixable so why not do so for consistency!
**Before**                                                **After**
<a href="https://imgur.com/tzppyWl"><img src="https://i.imgur.com/tzppyWl.gif" title="source: imgur.com" /></a> <a href="https://imgur.com/0VdHg2d"><img src="https://i.imgur.com/0VdHg2d.gif" title="source: imgur.com" /></a>
This fix is very simple. Open [src/field_player_avatar.c](../blob/master/src/field_player_avatar.c) and find the function `Task_WaitStopSurfing`. Before the line `DestroyTask(taskId)`, add the following:
```c
playerObjEvent->triggerGroundEffectsOnMove = TRUE;
MovementType_Player(&gSprites[gPlayerAvatar.spriteId]);
```
That's it!