From 5fa8ca55b07dd5e5fb0f8cdbc111c36087eade3f Mon Sep 17 00:00:00 2001
From: GriffinR <griffin.g.richards@gmail.com>
Date: Tue, 17 May 2022 17:12:45 -0400
Subject: [PATCH] Clean up some additional unknowns

---
 data/battle_ai_scripts.s | 9 ++++++---
 graphics_file_rules.mk   | 3 ---
 src/item.c               | 6 ------
 3 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/data/battle_ai_scripts.s b/data/battle_ai_scripts.s
index d856b926a2..c211c4dd21 100644
--- a/data/battle_ai_scripts.s
+++ b/data/battle_ai_scripts.s
@@ -1099,15 +1099,18 @@ AI_CV_AttackDown3:
 	score -2
 AI_CV_AttackDown4:
 	get_target_type1
-	if_in_bytes AI_CV_AttackDown_UnknownTypeList, AI_CV_AttackDown_End
+	if_in_bytes AI_CV_AttackDown_PhysicalTypeList, AI_CV_AttackDown_End
 	get_target_type2
-	if_in_bytes AI_CV_AttackDown_UnknownTypeList, AI_CV_AttackDown_End
+	if_in_bytes AI_CV_AttackDown_PhysicalTypeList, AI_CV_AttackDown_End
 	if_random_less_than 50, AI_CV_AttackDown_End
 	score -2
 AI_CV_AttackDown_End:
 	end
 
-AI_CV_AttackDown_UnknownTypeList:
+@ If the target is not of any type in this list then using the move may be discouraged.
+@ It seems likely this was meant to be "discourage reducing the target's attack if they're
+@ not a physical type", but they've left out Flying, Poison, and Ghost.
+AI_CV_AttackDown_PhysicalTypeList:
     .byte TYPE_NORMAL
     .byte TYPE_FIGHTING
     .byte TYPE_GROUND
diff --git a/graphics_file_rules.mk b/graphics_file_rules.mk
index 9e5c191930..7049431267 100644
--- a/graphics_file_rules.mk
+++ b/graphics_file_rules.mk
@@ -665,9 +665,6 @@ $(WALLPAPERGFXDIR)/ludicolo/tiles.4bpp: $(WALLPAPERGFXDIR)/friends_frame2.4bpp $
 $(WALLPAPERGFXDIR)/whiscash/tiles.4bpp: $(WALLPAPERGFXDIR)/friends_frame2.4bpp $(WALLPAPERGFXDIR)/whiscash/bg.4bpp
 	@cat $^ >$@
 
-$(OBJEVENTGFXDIR)/pics/effects/unknown_4F6D38/0.4bpp: %.4bpp: %.png
-	$(GFX) $< $@ -num_tiles 11
-
 $(INTERFACEGFXDIR)/selector_outline.4bpp: %.4bpp: %.png
 	$(GFX) $< $@ -num_tiles 8
 	
diff --git a/src/item.c b/src/item.c
index 63287693a8..8d0f45fedc 100644
--- a/src/item.c
+++ b/src/item.c
@@ -15,20 +15,14 @@
 #include "constants/items.h"
 #include "constants/hold_effects.h"
 
-extern u16 gUnknown_0203CF30[];
-
-// this file's functions
 static bool8 CheckPyramidBagHasItem(u16 itemId, u16 count);
 static bool8 CheckPyramidBagHasSpace(u16 itemId, u16 count);
 
-// EWRAM variables
 EWRAM_DATA struct BagPocket gBagPockets[POCKETS_COUNT] = {0};
 
-// rodata
 #include "data/text/item_descriptions.h"
 #include "data/items.h"
 
-// code
 static u16 GetBagItemQuantity(u16 *quantity)
 {
     return gSaveBlock2Ptr->encryptionKey ^ *quantity;