From 4e2886db8179072badaad0a3ff131b95dd0a7e94 Mon Sep 17 00:00:00 2001 From: Diegoisawesome Date: Fri, 11 May 2018 00:33:32 -0500 Subject: [PATCH] Use song constants --- src/battle_main.c | 4 ++-- src/battle_script_commands.c | 2 +- src/egg_hatch.c | 4 ++-- src/pokemon_summary_screen.c | 2 +- src/title_screen.c | 3 ++- 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/battle_main.c b/src/battle_main.c index 70eebed854..495aa3302f 100644 --- a/src/battle_main.c +++ b/src/battle_main.c @@ -1830,7 +1830,7 @@ static void FreeRestoreBattleData(void) gScanlineEffect.state = 3; gMain.inBattle = 0; ZeroEnemyPartyMons(); - m4aSongNumStop(0x5A); + m4aSongNumStop(SE_HINSI); FreeMonSpritesGfx(); FreeBattleSpritesData(); FreeBattleResources(); @@ -5224,7 +5224,7 @@ static void ReturnFromBattleToOverworld(void) SetRoamerInactive(); } - m4aSongNumStop(0x5A); + m4aSongNumStop(SE_HINSI); SetMainCallback2(gMain.savedCallback); } diff --git a/src/battle_script_commands.c b/src/battle_script_commands.c index d1a18e38f0..c382daaf4d 100644 --- a/src/battle_script_commands.c +++ b/src/battle_script_commands.c @@ -3357,7 +3357,7 @@ static void atk23_getexp(void) if (!(gBattleTypeFlags & BATTLE_TYPE_TRAINER) && gBattleMons[0].hp && !gBattleStruct->wildVictorySong) { BattleStopLowHpSound(); - PlayBGM(0x161); + PlayBGM(MUS_KACHI2); gBattleStruct->wildVictorySong++; } diff --git a/src/egg_hatch.c b/src/egg_hatch.c index 08767c68f2..8914d6ff36 100644 --- a/src/egg_hatch.c +++ b/src/egg_hatch.c @@ -574,10 +574,10 @@ static void Task_EggHatchPlayBGM(u8 taskID) play_some_sound(); } if (gTasks[taskID].data[0] == 1) - PlayBGM(376); + PlayBGM(MUS_ME_SHINKA); if (gTasks[taskID].data[0] > 60) { - PlayBGM(377); + PlayBGM(MUS_SHINKA); DestroyTask(taskID); // UB: task is destroyed, yet the value is incremented } diff --git a/src/pokemon_summary_screen.c b/src/pokemon_summary_screen.c index f77b7c38c9..4ce4cca5b9 100644 --- a/src/pokemon_summary_screen.c +++ b/src/pokemon_summary_screen.c @@ -1825,7 +1825,7 @@ void sub_81C174C(u8 taskId) } else { - PlaySE(0x20); + PlaySE(SE_HAZURE); sub_81C18F4(taskId); } } diff --git a/src/title_screen.c b/src/title_screen.c index 4e25c8152c..15a0482dca 100644 --- a/src/title_screen.c +++ b/src/title_screen.c @@ -19,6 +19,7 @@ #include "gpu_regs.h" #include "trig.h" #include "constants/rgb.h" +#include "constants/songs.h" #define VERSION_BANNER_SHAPE 1 #define VERSION_BANNER_RIGHT_TILEOFFSET 64 @@ -574,7 +575,7 @@ void CB2_InitTitleScreen(void) | DISPCNT_OBJ_ON | DISPCNT_WIN0_ON | DISPCNT_OBJWIN_ON); - m4aSongNumStart(0x19D); + m4aSongNumStart(MUS_TITLE3); gMain.state = 5; break; case 5: