Rangi
f59f1bdb88
Standardize capitalization of ".Jumptable"
2021-06-19 19:52:05 -04:00
Rangi
316fa4b695
Use rgbds 0.5.0
2021-04-19 16:31:37 -04:00
Rangi
dc18e188b2
Sync some files with pokegold
2021-03-24 10:24:52 -04:00
Rangi
8daf8fe19c
The radio's "Places & People" does not comment on Mysticalman Eusine
2021-03-21 21:07:45 -04:00
Rangi
3684296583
Revise some constant definitions
2021-03-16 18:06:18 -04:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
7d3ea88611
Rename GetFarHalfword to GetFarWord
...
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
97e981985b
Correct some filename comments
2020-11-17 11:12:21 -05:00
Rangi
17894e5f39
Replace $0 with 0 for "ld l, a / ld h, 0" idiom
2020-11-09 15:20:40 -05:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
c85ba78b77
Use more assertions to ensure correct code and data
2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
2e90df15b7
Update battle anim bg function comments, and identify more unnamed labels
2020-10-06 18:09:33 -04:00
Rangi
6b7ade66da
Identify more unnamed labels
2020-10-05 16:15:57 -04:00
Rangi
d9603e3e33
Identify more unnamed labels
2020-10-04 22:34:50 -04:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master
...
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
Rangi
7729dcd204
Consistent constants for radio data table sizes (could still be better)
2020-08-13 13:47:50 -04:00
mid-kid
248763b238
Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed
...
That should cause no real problems because of a range check right after
it.
2020-08-03 22:56:49 +02:00
Rangi
d96f914315
Define JOHTO_FLYPOINT like KANTO_FLYPOINT
2020-07-21 12:15:14 -04:00
Rangi
a9941e28cc
Define NUM_FLYPOINTS
2020-07-21 11:48:39 -04:00
Rangi
fce6243b43
Identify more labels, and use the jumptable macro when possible
2020-07-01 13:13:49 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
be93ab33a7
Harmonize engine/{phone, pokedex, pokegear, printer, rtc, tilesets} with pokegold
...
To do: engine/{menus, movie, overworld, pokemon}
2020-06-17 11:29:00 -04:00
Rangi
79184bc718
Miscellaneous fixes:
...
- `hSecondsBackup` -> `hUnusedBackup`
- `ld bc, hBGMapAddress + 1` -> `bccoord -1, -2, 0`
- Identify some `.asm_XXX` labels
2020-04-04 15:43:10 -04:00
Rangi
ad50e94b50
Add a `LANDMARK_` prefix to landmark constants
...
Resolves #697
2020-03-15 19:50:39 -04:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470
InitSpriteAnimStruct <-> _InitSpriteAnimStruct
...
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
ceadab8cd1
PnP_HiddenPlaces -> PnP_Places
...
The "Places & People" radio station does not avoid these maps; it only describes these maps.
2020-02-06 11:07:42 -05:00
Rangi
80cf859cd3
PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entries
2020-01-19 14:10:10 -05:00
mid-kid
739a60b33c
Make the map setup commands match the actual function names better
...
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
mid-kid
ad299b1635
Apply suggested changes
2019-06-10 01:52:46 +02:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi
3202c4f3df
Resolve issue #575 : Rename text commands
2018-11-18 12:41:11 -05:00
mid-kid
940256569b
text_jump → text_far
...
The previous name for this was rather misleading. It isn't an actual
jump like you'd expect the `jp` instruction to behave as. Instead, it
behaves more like a `farcall`.
This also makes it consistent with its current command ID name of
`TX_FAR`.
2018-11-05 22:26:18 +01:00
Rangi
ae022e1420
Curr -> Cur
2018-09-09 15:09:51 -04:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
mid-kid
f98a95b8ee
wWeeklyFlags -> wDailyFlags2
...
These are by far not always checked each week, and as such shouldn't be
called that.
Since they're almost always used through the `bit` instruction, it's
very inconvenient to just make wDailyFlags a `dw` instead.
2018-08-07 09:46:21 +02:00
Rangi
9dec80b07e
Add meaningful aliases for wd265
...
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
2018-07-29 00:25:52 -04:00
mid-kid
1fc7430a2b
Fix misnamed character codes
...
Some character codes were erroneously named after their text command
counterparts. This has caused a lot of confusion with naming their
functions and with other things.
I've also removed the `dict2` macro and expanded the `dict` macro. This
really isn't something we should be doing for macros but I can't deny it
looks a lot neater than repeated code.
2018-07-18 10:55:30 +02:00
Rangi
9ed402c4a2
Use charmap “ and ”
2018-06-25 13:54:30 -04:00
Rangi
5693cc49cf
Single newline at the end of files
2018-06-25 12:07:35 -04:00
Rangi
67d1364c7a
Fix triple newlines left over from removing address comments
2018-06-24 23:22:50 -04:00
mid-kid
5efce10789
Remove even more address comments
...
That should be all of them this time
2018-06-25 02:10:37 +02:00
mid-kid
1d9a68dbdd
Remove all address comments
2018-06-24 16:13:22 +02:00
yenatch
0fbc8362b6
Merge pull request #526 from atasro2/master
...
reword
2018-06-20 19:25:39 -04:00
MCboy
5c662be182
fixed a typo
...
being the grammar nazi i am i noticed a grammar error so i forked pokecrystal to fix it ;)
2018-06-14 00:34:24 +04:30
Rangi
fbe82a7fe0
Note which labels are only needed for locating banks (relevant to issue #485 )
2018-06-12 23:29:15 -04:00