Commit Graph

1225 Commits

Author SHA1 Message Date
Rangi cf37abd3ec Remove wKickCounter and wPresentPower aliases for wBattleAnimParam 2020-08-29 20:35:49 -04:00
mid-kid 3b43f79dc6 Use hex for tile IDs in engine/movie/splash.asm 2020-08-27 18:03:54 +02:00
mid-kid 353f78f493 GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:13:41 +02:00
mid-kid 15c08ad8a3 Small changes to better match pokegold 2020-08-27 14:52:27 +02:00
mid-kid 13c4a93cea Fix some constants surrounding sprite animations
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 13:59:33 +02:00
mid-kid 733664b18f Document splash screen animation 2020-08-27 13:59:33 +02:00
mid-kid 2b2c1ac649 Split engine/movie/intro.asm into itself and splash.asm 2020-08-27 13:59:31 +02:00
mid-kid 926e231849 Move all splash screen files to gfx/splash 2020-08-27 13:58:54 +02:00
mid-kid e40f421ffb Document weird code involving link trades of mew and celebi
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
2020-08-19 16:00:00 +02:00
Rangi 0b31d12dac
Merge pull request #756 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
mid-kid 315d6c665e Add wTitleScreenSelectedOption constants 2020-08-18 22:20:16 +02:00
Rangi 7729dcd204 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:50 -04:00
Rangi f65448a4c0 Factor out gfx/pack/pack_menu.tilemap 2020-08-12 20:59:54 -04:00
Rangi ed3e70b97c Identify some time-related data 2020-08-11 14:12:59 -04:00
mid-kid 8befc889ad Remove a verifiably false comment
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.

Its purpose is unknown, as this value is used nowhere else.
2020-08-05 16:02:48 +02:00
mid-kid aabfc0b413 `d` is the multiplier for Sprites_Sine 2020-08-05 16:02:48 +02:00
mid-kid b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid ac48d65498 Document wTitleScreenSelectedOption variable 2020-08-05 16:02:44 +02:00
mid-kid 2d2a7dec7d Label some mobile battle screen functions 2020-08-03 23:35:18 +02:00
mid-kid 58b45443e8 Minor title screen fixes 2020-08-03 23:35:18 +02:00
mid-kid 79bb2784e9 Better label 2D menu data 2020-08-03 22:56:49 +02:00
mid-kid 248763b238 Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed
That should cause no real problems because of a range check right after
it.
2020-08-03 22:56:49 +02:00
Rangi 0de7808ded Identify constant in NamingScreen_IsTargetBox 2020-08-03 15:22:28 -04:00
Rangi 35821ec58c Correct constants in DoNPCTrade 2020-07-25 18:36:49 -04:00
Rangi dcb24bc724 Use def_* macros for automatic map event counts
Resolves #742
2020-07-24 09:57:16 -04:00
Rangi dd369f3199 Move EngineFlags and SpecialsPointers into data/engine/ 2020-07-22 20:24:53 -04:00
Rangi 11dc805de0 Revert "Factor out tables into data/overworld/"
This reverts commit b5a7e7de3e.
2020-07-22 20:21:26 -04:00
Rangi b5a7e7de3e Factor out tables into data/overworld/
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi 212846af57 Treat map setup commands like trade script commands
Fixes #736
2020-07-22 13:37:43 -04:00
Rangi bb25c1074c Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:45:25 -04:00
Rangi d96f914315 Define JOHTO_FLYPOINT like KANTO_FLYPOINT 2020-07-21 12:15:14 -04:00
Rangi a9941e28cc Define NUM_FLYPOINTS 2020-07-21 11:48:39 -04:00
Rangi fc99117d88 " " → $7f 2020-07-21 11:12:56 -04:00
Rangi de073374a6 Port pokered's more local system for trade animation scripts
Also factor out trade tilemaps
2020-07-17 16:53:22 -04:00
Rangi 59d9932255 SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE 2020-07-17 13:01:48 -04:00
Rangi ef452ccbc7 return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:03 -04:00
Rangi eca33ef190 Define map setup commands as macros like other script commands 2020-07-13 20:44:16 -04:00
Rangi e239aa4aba Disassemble the final English debug ROM 2020-07-13 15:18:28 -04:00
Rangi c086de0c98 Use const_skip and const_next macros for brevity 2020-07-10 20:03:46 -04:00
Rangi 6ca82e5c86 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-08 15:30:23 -04:00
Rangi 43a9295789 add_tm, add_hm, and add_mt define TM##_MOVE, HM##_MOVE, and MT##_MOVE constants, to avoid repeating the move names in tmhm_moves.asm 2020-07-06 16:53:05 -04:00
Rangi ddf1163a21 Define SERIAL_PREAMBLE_LENGTH 2020-07-06 15:49:01 -04:00
Rangi 7eef66af3f Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc
Also make .gitignore consistent with pokered
2020-07-05 15:12:53 -04:00
Rangi f5ac9b0eb7 SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT 2020-07-04 16:18:16 -04:00
Rangi fce6243b43 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
Rangi e171c84c29 Identify more labels and constants 2020-06-29 19:35:47 -04:00
Rangi f2efda1f68 Identify more unnamed labels 2020-06-29 12:25:58 -04:00
Rangi 022f9e6af1 Reformat gfx/trade/game_boy.png and fix tools/gfx --preserve 2020-06-28 19:56:06 -04:00
Rangi 61847b3596 Identify some more labels 2020-06-22 16:30:13 -04:00
Rangi e0d07fba3f Sync PokeFluteTerminator with pokegold 2020-06-21 19:01:54 -04:00