Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,873 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

91 Commits

Author SHA1 Message Date
Rangi 3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros 
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
 2021-03-04 00:15:03 -05:00
Rangi 7d3ea88611 Rename GetFarHalfword to GetFarWord 
Fixes #796
 2021-01-09 15:16:05 -05:00
Rangi 5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi 17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi 62b756c46e Rename "dummy game" to "memory game" 2020-11-08 19:32:57 -05:00
Rangi 6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi 4a323cf591 UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims 2020-10-30 17:41:03 -04:00
Rangi 9b0002161b Extract more RGB data to .pal files 2020-10-30 16:12:25 -04:00
Rangi fe1a58deea Identify wSpriteAnimDict key constants 2020-10-30 15:39:08 -04:00
Rangi 1237156948 Identify mobile Name Card exchange labels 2020-10-30 10:45:31 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi a2b6befd7d Identify some more labels, mostly WRAM 2020-10-23 16:04:15 -04:00
Rangi 15f6a0af43 Identify a few more labels and data 2020-10-22 12:55:46 -04:00
Rangi b9a74ff777 Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels 2020-10-22 10:54:53 -04:00
Rangi 42d0a2567a Identify some more unnamed labels 2020-10-05 20:10:01 -04:00
Rangi 6b7ade66da Identify more unnamed labels 2020-10-05 16:15:57 -04:00
Rangi d9603e3e33 Identify more unnamed labels 2020-10-04 22:34:50 -04:00
Rangi 306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi 5a546068a8 Identify SGB blk/pal packets 2020-10-04 18:32:33 -04:00
mid-kid 353f78f493 GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE 
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
 2020-08-27 15:13:41 +02:00
mid-kid 15c08ad8a3 Small changes to better match pokegold 2020-08-27 14:52:27 +02:00
mid-kid 13c4a93cea Fix some constants surrounding sprite animations 
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
 2020-08-27 13:59:33 +02:00
mid-kid 733664b18f Document splash screen animation 2020-08-27 13:59:33 +02:00
mid-kid 926e231849 Move all splash screen files to gfx/splash 2020-08-27 13:58:54 +02:00
mid-kid 8befc889ad Remove a verifiably false comment 
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.

Its purpose is unknown, as this value is used nowhere else.
 2020-08-05 16:02:48 +02:00
mid-kid aabfc0b413 `d` is the multiplier for Sprites_Sine 2020-08-05 16:02:48 +02:00
mid-kid b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
Rangi bb25c1074c Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:45:25 -04:00
Rangi f5ac9b0eb7 SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT 2020-07-04 16:18:16 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM) 
To do: engine/{menus, overworld}
 2020-06-17 17:03:38 -04:00
Rangi 8019db3ea9 Harmonize engine/{gfx, items, link, math} with pokegold 2020-06-17 10:39:17 -04:00
Rangi 7b2515d1e4 [in progress] Harmonize more constant and data files with pokegold 2020-06-16 14:32:57 -04:00
Rangi b9f2b93c17 Harmonize some more symbols with pokegold 2020-06-16 11:28:52 -04:00
Rangi 60c71add58 Define pokeanim setup commands like std scripts, predefs, and specials 
No need for a macro workaround in rgbds 0.4.0
 2020-06-10 17:15:53 -04:00
Rangi 4259b0f934 Separate UnusedBattleObjectPals from PartyMenuOBPals 2020-06-03 12:20:34 -04:00
Rangi 156f2cc3ef Update some routine labels, including unreferenced ones 2020-05-18 11:59:48 -04:00
Rangi e32cf1bfd1 Miscellaneous cleanup noted in #709 2020-05-17 20:59:15 -04:00
Rangi 20464d1bfb Miscellaneous updates 
- `PREDEFPAL_00` -> `PREDEFPAL_ROUTES` (observed from `LoadSGBLayout.GetMapPalsIndex.route`)
- `$0` -> `PLAYER` (standard person ID)
- Fix some whitespace formatting
 2020-04-30 11:27:32 -04:00
Rangi 576cbf5b3e Miscellaneous fixes, including one for the Pokédex design flaw by ax6 2020-04-18 17:31:51 -04:00
Rangi 865d623846 Remove unused nonmatching files for electro_ball.png and sgb_border.bin 
electro_ball.png needed to preserve one whitespace tile which tools/gfx would normally remove. Preserving a list of tile indexes has been added as a general feature to tools/gfx.

sgb_border.bin needed to remove the 20x18 center area of $00 bytes. This is achievable with the standard tr utility.
 2020-04-08 12:14:37 -04:00
Rangi 3144b54bd1 Enable rgbds warnings and remove CFLAGS=-O2 (default is now -O3) 2020-04-06 12:41:07 -04:00
Rangi 6a6ba10315 rgbds supports 'X - 1' instead of 'X + -1' 2020-03-21 14:01:05 -04:00
Rangi 447da80615 Identify remaining gfx/unknown files 2020-02-28 09:23:41 -05:00
Rangi 81eaf83cd7 Identify gfx/unknown/4985a.asm as gfx/tilesets/forest-tree/unused.png 2020-02-26 15:41:22 -05:00
mid-kid 26b8bf003e Standardize on lowercase Tilemap and Attrmap 
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
 2020-02-13 18:31:10 +01:00