Commit Graph

122 Commits

Author SHA1 Message Date
Rangi bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi d8310c166d Identify some more map object labels and constants 2020-10-22 17:41:48 -04:00
Rangi b9a74ff777 Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels 2020-10-22 10:54:53 -04:00
Rangi 2e90df15b7 Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:33 -04:00
Rangi fc08ff2c38 Identify some unnamed labels 2020-10-06 13:50:02 -04:00
Rangi 42d0a2567a Identify some more unnamed labels 2020-10-05 20:10:01 -04:00
Rangi 6b7ade66da Identify more unnamed labels 2020-10-05 16:15:57 -04:00
Rangi ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
Rangi 306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi 0b31d12dac
Merge pull request #756 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
Rangi 7729dcd204 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:50 -04:00
mid-kid b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
Rangi dcb24bc724 Use def_* macros for automatic map event counts
Resolves #742
2020-07-24 09:57:16 -04:00
Rangi 11dc805de0 Revert "Factor out tables into data/overworld/"
This reverts commit b5a7e7de3e.
2020-07-22 20:21:26 -04:00
Rangi b5a7e7de3e Factor out tables into data/overworld/
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi 212846af57 Treat map setup commands like trade script commands
Fixes #736
2020-07-22 13:37:43 -04:00
Rangi fc99117d88 " " → $7f 2020-07-21 11:12:56 -04:00
Rangi ef452ccbc7 return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:03 -04:00
Rangi eca33ef190 Define map setup commands as macros like other script commands 2020-07-13 20:44:16 -04:00
Rangi e239aa4aba Disassemble the final English debug ROM 2020-07-13 15:18:28 -04:00
Rangi 6ca82e5c86 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-08 15:30:23 -04:00
Rangi 61847b3596 Identify some more labels 2020-06-22 16:30:13 -04:00
Rangi c3c18dd196 Comment more ROM labels as unreferenced
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi 50e182e831 Harmonize engine/overworld with pokegold 2020-06-17 22:12:04 -04:00
Rangi cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi f2550fc3c2 ReplaceKrisSprite -> UpdatePlayerSprite 2020-06-16 19:38:00 -04:00
Rangi b9f2b93c17 Harmonize some more symbols with pokegold 2020-06-16 11:28:52 -04:00
Rangi 4342ced31f Identify wObjectPriorities 2020-06-15 23:28:24 -04:00
Rangi 401aa383e2 make DEBUG=1 logs all symbols in the .map and .sym files 2020-06-14 21:52:33 -04:00
Rangi 20464d1bfb Miscellaneous updates
- `PREDEFPAL_00` -> `PREDEFPAL_ROUTES` (observed from `LoadSGBLayout.GetMapPalsIndex.route`)
- `$0` -> `PLAYER` (standard person ID)
- Fix some whitespace formatting
2020-04-30 11:27:32 -04:00
Rangi 576cbf5b3e Miscellaneous fixes, including one for the Pokédex design flaw by ax6 2020-04-18 17:31:51 -04:00
Rangi 22615cecc5 More miscellaneous fixes (see #709) 2020-04-17 10:52:59 -04:00
Rangi 58b377f25b Fix #709 miscellaneous issues 2020-04-16 09:30:50 -04:00
Rangi ad50e94b50 Add a `LANDMARK_` prefix to landmark constants
Resolves #697
2020-03-15 19:50:39 -04:00
Rangi c3f389d615 Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead" 2020-02-23 18:51:32 -05:00
mid-kid 9a927c1b3e
Merge pull request #685 from mid-kid/master
Moshi moshi? minoru enhansumentsu desu
2020-02-21 21:11:36 +01:00
Rangi 88bbdb6a2f Define TileCollisionTable as a standard 'db' series 2020-02-13 19:07:19 -05:00
mid-kid 26b8bf003e Standardize on lowercase Tilemap and Attrmap
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
Rangi fb9cbe7d1e
Merge pull request #650 from pret/audio-macros
Update audio macros and arguments
2020-02-05 18:51:20 -05:00
Rangi 24a23b1922 Use CMDQUEUE constants 2020-02-04 11:11:43 -05:00
dannye e7be25948d Merge branch 'master' into audio-macros 2020-01-06 22:07:33 -06:00
Rangi 94ebdab6d3
Merge pull request #660 from mid-kid/master
Make the map setup commands match the actual function names better
2020-01-04 20:08:43 -05:00
Rangi fa7261a8ee Update some labels 2019-12-03 09:17:21 -05:00
mid-kid 739a60b33c Make the map setup commands match the actual function names better
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
Rangi 4d32035d4f Bit 6 of PrintNum left-aligns numbers 2019-11-03 20:17:04 -05:00
Rangi 0c7b309f7f Suggested formatting changes 2019-11-03 20:07:25 -05:00
Rangi 717cf3f458 Identify PLAYERMOVEMENT_* constants 2019-11-03 14:30:33 -05:00
Rangi 4aeab6b879 Rename buttonsound to promptbutton 2019-11-03 12:48:54 -05:00
Rangi 5134266b9a Rename OBJECT_LENGTH to MAPOBJECT_LENGTH and OBJECT_STRUCT_LENGTH to OBJECT_LENGTH 2019-11-03 12:26:38 -05:00