Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,965 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

465 Commits

Author SHA1 Message Date
mid-kid 1dc88cb585 Enumerate MobileAPI function constants 2022-01-23 18:13:41 +00:00
Rangi ce16317f33 `ClearWindowData` clears four menu data buffers, each the same size 2022-01-22 21:43:09 -05:00
Rangi a6cffc04c3 Use `MAP_LENGTH` in `GetMapPointer` 2021-12-30 18:16:22 -05:00
Rangi e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Andrew Cook 588cf88257
Label wram variables for in home/mobile and lib/mobile (#843) 2021-09-05 12:47:24 -04:00
Rangi b1dbadbdd3 Require rgbds 0.5.1 
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
 2021-05-09 12:26:28 -04:00
Rangi 4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi 3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros 
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
 2021-03-04 00:15:03 -05:00
Rangi 4401d24074 Identify link sync buffers, separate from link action bytes 
Fixes #803
 2021-02-22 12:02:52 -05:00
Rangi 7d3ea88611 Rename GetFarHalfword to GetFarWord 
Fixes #796
 2021-01-09 15:16:05 -05:00
Rangi 5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi 99e66c2557 Rename some labels 
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
 2020-12-23 16:29:30 -05:00
Rangi 098903fc97 FarString -> PlaceFarString, and document a BrokenPlaceFarString bug 2020-12-07 13:32:08 -05:00
aljohnston112 7b9d8767d4
Identified two magic numbers and cleaned up some comments (#783) 
Improve the audio engine's comments and replace some magic numbers with constants
 2020-12-07 12:44:16 -05:00
Rangi 9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi 17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi 01d6e6c758 Group some link.asm code into "paragraphs" 2020-11-02 19:32:14 -05:00
Rangi ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi 7883e8f431 Define SERIAL_LINK_BYTE_TIMEOUT 2020-10-29 16:43:28 -04:00
Rangi bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi d8310c166d Identify some more map object labels and constants 2020-10-22 17:41:48 -04:00
Rangi ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
Rangi ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
Rangi 306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi 0b31d12dac
Merge pull request #756 from mid-kid/master 
Rub a dub dub, thanks for the grub
 2020-08-18 16:35:15 -04:00
ISSOtm e0b783bb7b Enable compatibility with upcoming RGBASM version 
This is additionally required, because an `elif`'s condition is evaluated even
when it's about to be skipped over, and this `"\2"` will become an error
 2020-08-18 13:41:59 +02:00
Rangi 9d6ac04c9d "<NULL>" -> 0, for 'and a' 2020-08-17 16:29:08 -04:00
Rangi 328a6737db Use ISCONST for future rgbds lexer compatibility 2020-08-17 13:02:49 -04:00
mid-kid b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid 6f30d79620 TX_NUM -> TX_DECIMAL 2020-08-03 23:35:18 +02:00
mid-kid 79bb2784e9 Better label 2D menu data 2020-08-03 22:56:49 +02:00
Rangi e239aa4aba Disassemble the final English debug ROM 2020-07-13 15:18:28 -04:00
Rangi b3bd682366 text_linkpromptbutton -> text_waitbutton 
Removes support for text_waitbutton as a legacy alias for text_promptbutton.
 2020-07-06 12:55:31 -04:00
Rangi f5ac9b0eb7 SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT 2020-07-04 16:18:16 -04:00
Rangi fce6243b43 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
Rangi e171c84c29 Identify more labels and constants 2020-06-29 19:35:47 -04:00
Rangi 61847b3596 Identify some more labels 2020-06-22 16:30:13 -04:00
Rangi e0d07fba3f Sync PokeFluteTerminator with pokegold 2020-06-21 19:01:54 -04:00
Rangi c3c18dd196 Comment more ROM labels as unreferenced 
(Some unreferenced labels are above code which is still used via fallthrough!)
 2020-06-21 18:33:31 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM) 
To do: engine/{menus, overworld}
 2020-06-17 17:03:38 -04:00
Rangi f2550fc3c2 ReplaceKrisSprite -> UpdatePlayerSprite 2020-06-16 19:38:00 -04:00
Rangi c552390a15 Harmonize home/ with pokegold 2020-06-16 15:49:32 -04:00
Rangi b9f2b93c17 Harmonize some more symbols with pokegold 2020-06-16 11:28:52 -04:00