Commit Graph

487 Commits

Author SHA1 Message Date
Rangi42 23183bb9bb Rename wram_constants.asm to ram_constants.asm 2024-05-22 21:07:37 -04:00
Rangi42 b81e339f33 Use constants for VBlank handlers 2024-05-22 21:02:55 -04:00
Idain 4432df05cb
Add more assert cases in the codebase (#1115)
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
2024-04-27 12:17:07 -05:00
vulcandth b0b5ed2eb8
Fix/update sprite y-coord offscreen definitions (#1108) 2024-04-14 15:55:46 -05:00
xCrystal e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal 7f3b87950a more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
xCrystal f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal 5be9856f3a In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
xCrystal cd28c44ff3 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
2024-01-07 13:36:28 +01:00
xCrystal bd6ceec193 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-07 13:36:05 +01:00
Rangi dbf6044650
Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
SnorlaxMonster a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
mid-kid 4c4fd7258c Define SERIAL_PATCH_PREAMBLE_LENGTH 2023-04-19 19:12:14 +02:00
vulcandth c01409be5a
Relabel some `map_object` struct fields (#1029) 2023-01-03 22:16:08 -05:00
Rangi 8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Rangi 41d5ea0482
Rename the `object_struct` field labels and constants (#1005)
Fixes #990
2022-09-12 09:15:44 -04:00
Colton G. Rushton 145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth ef9b9bb437
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
vulcandth 3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth a4d346cc8c
Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
Rangi 82e315e483 gfx.py was removed 2022-04-19 18:12:58 -04:00
vulcandth 31c3c94d64
Build the Virtual Console patch with `make crystal11_vc` (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
mid-kid 1dc88cb585 Enumerate MobileAPI function constants 2022-01-23 18:13:41 +00:00
Rangi ce16317f33 `ClearWindowData` clears four menu data buffers, each the same size 2022-01-22 21:43:09 -05:00
Rangi a6cffc04c3 Use `MAP_LENGTH` in `GetMapPointer` 2021-12-30 18:16:22 -05:00
Rangi e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Andrew Cook 588cf88257
Label wram variables for in home/mobile and lib/mobile (#843) 2021-09-05 12:47:24 -04:00
Rangi b1dbadbdd3 Require rgbds 0.5.1
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi 4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi 3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi 4401d24074 Identify link sync buffers, separate from link action bytes
Fixes #803
2021-02-22 12:02:52 -05:00
Rangi 7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi 5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi 99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi 098903fc97 FarString -> PlaceFarString, and document a BrokenPlaceFarString bug 2020-12-07 13:32:08 -05:00
aljohnston112 7b9d8767d4
Identified two magic numbers and cleaned up some comments (#783)
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:16 -05:00
Rangi 9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi 17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi 01d6e6c758 Group some link.asm code into "paragraphs" 2020-11-02 19:32:14 -05:00
Rangi ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi 7883e8f431 Define SERIAL_LINK_BYTE_TIMEOUT 2020-10-29 16:43:28 -04:00
Rangi bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi d8310c166d Identify some more map object labels and constants 2020-10-22 17:41:48 -04:00
Rangi ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00