Commit Graph

356 Commits

Author SHA1 Message Date
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi 62b756c46e Rename "dummy game" to "memory game" 2020-11-08 19:32:57 -05:00
Rangi c88c4a8340 Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
Rangi 6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi 9b0002161b Extract more RGB data to .pal files 2020-10-30 16:12:25 -04:00
Rangi c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi 306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi 5a546068a8 Identify SGB blk/pal packets 2020-10-04 18:32:33 -04:00
Rangi 427f491e2e Pan Docs: "When sending three or more data sets, data is continued in further packet(s). Unused bytes at the end of the last packet should be set to zero." 2020-09-01 12:24:14 -04:00
mid-kid 926e231849 Move all splash screen files to gfx/splash 2020-08-27 13:58:54 +02:00
Rangi f65448a4c0 Factor out gfx/pack/pack_menu.tilemap 2020-08-12 20:59:54 -04:00
Rangi ed3e70b97c Identify some time-related data 2020-08-11 14:12:59 -04:00
Rangi de073374a6 Port pokered's more local system for trade animation scripts
Also factor out trade tilemaps
2020-07-17 16:53:22 -04:00
Rangi 59d9932255 SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE 2020-07-17 13:01:48 -04:00
Rangi 022f9e6af1 Reformat gfx/trade/game_boy.png and fix tools/gfx --preserve 2020-06-28 19:56:06 -04:00
aaaaaa123456789 5e99f9390a Fix lzcomp flags after fixing uninitialized read bug 2020-06-28 05:23:09 -03:00
Rangi c3c18dd196 Comment more ROM labels as unreferenced
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi b9f2b93c17 Harmonize some more symbols with pokegold 2020-06-16 11:28:52 -04:00
Rangi 0d683ea0c7 Remove redundant tile graphics file, reuse others 2020-06-11 10:55:32 -04:00
Rangi 4259b0f934 Separate UnusedBattleObjectPals from PartyMenuOBPals 2020-06-03 12:20:34 -04:00
aaaaaa123456789 2b7237e299
Match LZ compressed files (#724)
Replace lzcomp with new version and match all LZ compressed files
2020-05-23 13:30:04 -04:00
Rangi 20464d1bfb Miscellaneous updates
- `PREDEFPAL_00` -> `PREDEFPAL_ROUTES` (observed from `LoadSGBLayout.GetMapPalsIndex.route`)
- `$0` -> `PLAYER` (standard person ID)
- Fix some whitespace formatting
2020-04-30 11:27:32 -04:00
Rangi 164e1b89af Rename pokecrystal.link to layout.link
This is independent of the project name, and clearly applies to pokecrystal11, pokecrystal-au, etc.
2020-04-17 11:02:29 -04:00
Rangi 865d623846 Remove unused nonmatching files for electro_ball.png and sgb_border.bin
electro_ball.png needed to preserve one whitespace tile which tools/gfx would normally remove. Preserving a list of tile indexes has been added as a general feature to tools/gfx.

sgb_border.bin needed to remove the 20x18 center area of $00 bytes. This is achievable with the standard tr utility.
2020-04-08 12:14:37 -04:00
Rangi 0ee9d7a48b Upgrade to rgbds 0.4.0
- fail for rgbds < 0.4.0
- `rst <Label>`
- `ds <count>, <byte>`
- `shift <N>`
- ASCII "\r"
- Sorted .sym file
2020-04-04 15:15:02 -04:00
Rangi 6a6ba10315 rgbds supports 'X - 1' instead of 'X + -1' 2020-03-21 14:01:05 -04:00
Rangi 624864307e Combine Celebi frames into one PNG 2020-03-16 08:58:28 -04:00
Rangi f09b68d945 Change how some PNG graphics are formatted 2020-03-01 17:00:57 -05:00
Rangi 447da80615 Identify remaining gfx/unknown files 2020-02-28 09:23:41 -05:00
Rangi 81eaf83cd7 Identify gfx/unknown/4985a.asm as gfx/tilesets/forest-tree/unused.png 2020-02-26 15:41:22 -05:00
Rangi a73ced3b69 unused_dark_cave -> unused_johto (goes with the beta Johto town+city maps) 2020-02-25 19:18:24 -05:00
Rangi ef48ae98b5 Separate tilesets.o goes with pics.o and sprites.o 2019-11-23 20:43:33 -05:00
Rangi 2239593f3c 128px is the standard tileset width 2019-11-03 15:05:29 -05:00
Rangi 3633e0e541 Correct question_mark.2bpp hash and rgbgfx flags 2019-11-03 14:52:18 -05:00
Rangi d5e1b5a628 The $C9 byte in page2.tilemap is a ret opcode 2019-11-03 14:18:23 -05:00
Rangi e669f22e9e GFX_17eb7e -> PokemonNewsTileAttrmap 2019-11-03 13:55:29 -05:00
Rangi 61887c8c07 sgb_border_nonmatching.bin has the 20x18 screen bytes within the 32x28 tilemap 2019-11-03 13:44:55 -05:00
Rangi 3e7c7d5fff Identify intro tilemaps and attrmaps 2019-11-03 13:38:40 -05:00
Rangi 01f68fcc6a Rename TILESET_BATTLE_TOWER to TILESET_BATTLE_TOWER_INSIDE 2019-11-03 12:03:37 -05:00
Rangi 3e056a6862 Store a mobile tilemap+tilemap in its own files 2019-08-11 22:20:26 -04:00
Rangi 6962d843a3 Store Magnet Train tilemaps in their own files 2019-08-11 18:48:26 -04:00
mid-kid 7b47aeaf79 Redump slots_1.png with 16 as width. 2019-06-09 00:17:05 +02:00
mid-kid 3e78e5b2b6 TextBox -> Textbox
Homogenizing names.
2019-04-09 16:09:18 +02:00
mid-kid 5f60cc24cf Fix some constants
Glass ting SFX were added in crystal.
PicAnimations and UnownAnimations are expected to be in the same bank as
their pointers, because the pointers are not BANK()-referenced
separately.
2019-01-15 13:06:16 +01:00
Rangi 0ce8dd75cd gfx/roofs/*.png filenames match ROOF_* constants 2018-10-31 17:46:18 -04:00
Rangi 2e7e5ca67b PREDEFPAL_4D -> PREDEFPAL_GAMEFREAK_LOGO_OB 2018-09-22 13:40:37 -04:00
Rangi 03cb8c53f1 Identify some Spaceworld beta content 2018-09-16 13:40:47 -04:00
Rangi 67d1364c7a Fix triple newlines left over from removing address comments 2018-06-24 23:22:50 -04:00