Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,182 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

174 Commits

Author SHA1 Message Date
Rangi eb1e3636bb Use labels instead of constants for HRAM 
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
 2018-08-25 14:28:22 -04:00
Rangi 33ff8f2aed asm → diff 2018-08-23 10:07:05 -04:00
mid-kid 0e0f43747d Fix docs 2018-08-19 12:17:54 +02:00
Rangi e346cc7b41 Every diff line starts with +, -, or space 2018-07-29 19:52:30 -04:00
Rangi 20ffc8bd8b Reformat some bugfix diffs 2018-07-29 00:27:13 -04:00
Thomas Winwood 533fdd8b4c Add fix for battle transition bug 2018-07-28 19:01:02 +01:00
Rangi cdfdfed17b Crystal fixed TruncateHL_BC in single player 2018-07-27 21:32:14 -04:00
Rangi a2f63043d4 Separate Beat Up bugs 2018-07-27 17:53:26 -04:00
Rangi b58f82e12f Reword bug docs now that they use diffs 2018-07-27 13:11:30 -04:00
mid-kid 0aac0f9cfc "Explain" diff format in bugs_and_glitches 2018-07-27 11:25:29 +02:00
mid-kid a91b59ab5d Remove a documented bug that's not really a bug 
I mean, technically, being able to read beyond a data table's size is
bad practice, but there's so many cases of this that it's not worth
mentioning.

For most of these cases, at least, it's safe to assume the index won't
ever get high enough to surpass such a table's length, because it's
either hardcoded or decided by the game without the use of
uncontrollable data. As such, they don't expose any actual bugs.
 2018-07-26 23:34:05 +02:00
mid-kid e43c89bc80 Consistently use the diff format in bugs_and_glitches 2018-07-26 23:34:03 +02:00
Rangi 60ffde3752
Merge pull request #489 from i0brendan0/i0brendan0-patch-5 
Add Fix for Lock-On Bug
 2018-07-26 16:20:52 -04:00
Rangi dc1d0217a1
Merge pull request #522 from ketsuban/the-diffening 
Convert code samples to diffs
 2018-07-26 16:20:33 -04:00
i0brendan0 8755a88458
turns out none of the code is needed 2018-07-21 05:05:40 -05:00
i0brendan0 6e62eabb42
final change 2018-07-21 03:36:03 -05:00
IIMarckus 8aebc7ba56 Merge branch 'master' of hyperdriveguy/pokecrystal 2018-07-21 00:41:56 -06:00
Thomas Winwood 23ef2f50a7
Merge branch 'master' into the-diffening 2018-07-21 02:06:31 +01:00
Hyperdriveguy 57fc81d44e Add Counter and Mirror Coat bugfix 2018-07-20 17:39:53 -07:00
Rangi 67d1364c7a Fix triple newlines left over from removing address comments 2018-06-24 23:22:50 -04:00
Rangi 6e44095c2a Remove address comments in docs 2018-06-24 21:45:12 -04:00
i0brendan0 57efc4b392
final fix 2018-06-18 00:32:36 -05:00
Rangi fbe82a7fe0 Note which labels are only needed for locating banks (relevant to issue #485) 2018-06-12 23:29:15 -04:00
Thomas Winwood 17a4d0540a
Fix small bug 2018-06-10 00:21:34 +01:00
Thomas Winwood ff1c9f36da
Convert code samples in bugs_and_glitches.md to diffs 2018-06-09 23:35:50 +01:00
Thomas Winwood 62439a95a1
Convert code samples in design_flaws.md to diffs 2018-06-09 23:27:47 +01:00
Rangi c7bb2d15cf Create empty sections for the remaining FixPicBank array entries 2018-06-03 23:25:21 -04:00
Rangi 7cd5bcbae4 Change FixPicBank bank array 2018-06-03 23:18:31 -04:00
i0brendan0 158144f9cb
undo protect message bug 2018-06-02 01:12:52 -05:00
Rangi 3927bcdb9d Function6ec1 → CanObjectMoveInDirection 2018-05-24 12:36:35 -04:00
Rangi 1840af8b4f Identify more sprite move data flag bits 2018-05-23 22:01:21 -04:00
Rangi e01a86fe84 Fix doc links 2018-05-09 12:10:50 -04:00
mid-kid acdb302035 Fix rest of the givepokeitem/checkpokeitem references 2018-05-06 13:48:04 +02:00
mid-kid c82deab86f fix-various-little-things 
A compilation of suggestions from the discord that don't deserve
separate commits and are not questionable at all™.
 2018-05-05 09:19:04 +02:00
Rangi 7307fc8dce Use constants for bit/set/res more 2018-04-05 11:44:02 -04:00
yenatch f750d4f418
Merge pull request #505 from mid-kid/battlecommands 
Battle command fixes
 2018-04-04 21:18:15 -04:00
mid-kid 38107209a6 Update docs and comments to reflect renames 2018-04-04 23:44:24 +02:00
mid-kid 2958188fc6 Document more Beat Up-related bugs 
Two bugs related to not raising the substitute when it should, one bug
related to not running king's rock when it should, and the other related
to running king's rock when it shouldn't. Fun.
 2018-04-04 22:41:18 +02:00
mid-kid 91a768b243 Update file paths in constants/ and docs/ 2018-04-01 17:01:51 +02:00
Rangi ab2677277e 201 -> 200 2018-03-04 02:30:31 -05:00
Rangi 159a0ef7b4 Bug docs match code 2018-03-04 02:29:39 -05:00
i0brendan0 51bbfee891
Reflect Rangi's suggestion 2018-03-01 04:06:46 -06:00
i0brendan0 82ffb584c8 Add Protect Bug and Fix 
Moves 'miss' when opponent uses Protect.
 2018-03-01 04:08:54 -06:00
Rangi f0b01a4eea Document more quirks and bugs 2018-02-26 13:41:48 -05:00
Rangi 5959548c01 Document HOF Master bug (close #494) 2018-02-26 11:51:16 -05:00
Rangi 335c2699f0 Merge branch 'master' of https://github.com/pret/pokecrystal 
# Conflicts:
#	constants/map_constants.asm
#	constants/wram_constants.asm
#	data/radio/oaks_pkmn_talk_routes.asm
#	data/radio/pnp_hidden_places.asm
#	engine/battle/core.asm
#	engine/breeding.asm
#	engine/phone/phone_scripts.asm
#	engine/radio.asm
#	maps/BattleTower1F.asm
#	maps/OlivineLighthouse2F.asm
#	maps/OlivineLighthouse6F.asm
#	maps/PokemonFanClub.asm
#	maps/RadioTower1F.asm
#	maps/RadioTower2F.asm
#	maps/Route30BerryHouse.asm
#	maps/Route34IlexForestGate.asm
#	maps/Route36NationalParkGate.asm
#	maps/RuinsOfAlphKabutoChamber.asm
#	maps/RuinsOfAlphResearchCenter.asm
#	maps/VermilionPort.asm
#	maps/VictoryRoad.asm
 2018-02-25 20:39:54 -05:00
Rangi f964d04a87 * loadmenuheader -> loadmenu (ead103d) 
* objectface -> turnobject (c834bda)
 2018-02-25 20:05:37 -05:00
mid-kid e8bc86d1fe Pkmn -> Mon 
Since we're aiming for consistency across the codebase, I believe it
includes a uniform way to refer to the creatures this game consists of
in the labels of the code.
The only exceptions to this rule are labels referring to things named
through the use of the <PK><MN> or <PKMN> characters, in which case PKMN
is used.

Most of this was already consistent enough™, I just picked the
convention with the most occurences and fixed the outliers.
 2018-02-22 17:39:06 +01:00
i0brendan0 a99adb0e5a Fix 
I did a dumb and used the wrong check instruction. Should actually work.
 2018-02-20 01:48:22 -06:00
i0brendan0 0e45563497 Add Fix for Lock On Status Moves 
These changes should fix the status move and secondary effects not working if the opponent is flying or digging but has been locked on.
 2018-02-19 02:54:13 -06:00